New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738618 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 3
Type: Feature
Team-Security-UX



Sign in to add a comment

Record Chrome channel information in certificate reports

Project Member Reported by sperigo@google.com, Jun 30 2017

Issue description

The Chrome channel is a useful piece of information for debugging certificate errors. We currently lose the channel information when certificate reports are anonymized.

Feature request: add another field to processed and anonymized certificate reports denoting whether the report is coming from the "DEV", "BETA", "CANARY", "STABLE channel, etc.
 

Comment 1 by mea...@chromium.org, Jun 30 2017

Components: Internals>CertAnalysis
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f80e9efd510215e723a29e6260b98a6c5d5e403

commit 6f80e9efd510215e723a29e6260b98a6c5d5e403
Author: sperigo <sperigo@chromium.org>
Date: Wed Jul 12 20:09:57 2017

Add chrome channel to cert logger reports.

The cert logger reports are used to gather information on certificate
failures, and are helpful for background research for the Enamel team's
interstitials. We've added chrome channels to these certificate logs in
order to better isolate the root of problems we might see arise.

BUG= 738618 

TEST=Unit test added in components/certificate_reporting/error_report_unittest.cc.

Review-Url: https://codereview.chromium.org/2964283002
Cr-Commit-Position: refs/heads/master@{#486069}

[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/chrome/browser/ssl/cert_report_helper.cc
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/chrome/browser/ssl/certificate_reporting_test_utils.cc
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/chrome/browser/ssl/certificate_reporting_test_utils.h
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/components/certificate_reporting/BUILD.gn
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/components/certificate_reporting/DEPS
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/components/certificate_reporting/cert_logger.proto
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/components/certificate_reporting/error_report.cc
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/components/certificate_reporting/error_report.h
[modify] https://crrev.com/6f80e9efd510215e723a29e6260b98a6c5d5e403/components/certificate_reporting/error_report_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment