New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

WebUI: [Metabug] Migrate to Polymer 2.

Project Member Reported by dpa...@chromium.org, Jun 30 2017

Issue description

Currently all of Chrome's Polymer WebUIs use Polymer 1, which is using Shadow DOM v0 and will eventually get removed from Chrome (unclear when exactly). Polymer 2 is out for a few months now, and besides using Shadow DOM v1, it has many benefits over Polymer 1.

Should we migrate to Polymer2?
I think so, because Polymer 2 has incorporated basically all the feedback that we (and other early adopters of Polymer) gave back to the Polymer team, and as a result is a big improvement.

 - Its API is cleaner (less idiomatic).
 - Uses the new Shadow DOM v1 (which has consensus from other major browsers).
 - Is more modular (no more including unnecessary polyfils), will help with performance by loading smaller amounts of code.

If others agree (we can talk about this here, or an a separate thread), we should start thinking and documenting the work necessary to migrate all of Polymer WebUIs to Polymer 2, since it will require a long and co-ordinated effort.

Some of my initial findings/suggestions:
A possible viable approach (based on [1]) would be to
 1) Modify our code to conform to "hybrid" mode, while still using Polymer 1.
 2) Add Polymer2 to somewhere under third_party/polymer/ along side with existing Polymer1.
 3) Start migrating WebUI pages to use Polymer2 core instead of Polymer1 core.
 4) Once all pages are migrated, delete Polymer1 from third_party/polymer

Regarding step 1, we need to roll a bunch of paper-*, iron-* elements to their latest versions, which conform to "hybrid" mode, see for example [2] where paper-button was updated to "hybrid".

Thinking of keeping this bug as a metabug, tracking the high level discussion/approach, and file dependent bugs for all discovered work items.

[1] https://www.polymer-project.org/2.0/docs/upgrade
[2] https://github.com/PolymerElements/paper-button/commit/008c39267dae35c6a74920132b515fa231ace512?diff=split
 
SGTM.

What about a set 0.5 or 1.5 to replace some paper-* classes with cr-* or settings-* classes? Or would that come at a later step?

Sidebar that will be relevant to a few people (please ignore this if it doesn't make sense): 
I'd done some research on Polymer 2 and Harmony UX to determine if updating Polymer is necessary to move from the Material Design to the Harmony Design style. Based on the current (non-final) Harmony specs, updating to Polymer 2 is independent from the UX changes (Polymer can be changed before or after Harmony, IMO).
Replacing paper-* elements with our own implementations has already happened independently of this bug, For example we've already migrated:

 - paper-item -> div
 - paper-dialog -> cr-dialog
 - paper-dropdown-menu -> md-select
 - iron-dropdown-menu (and friends)-> cr-action-menu

These migrations don't seem that they should block migrating to Polymer 2.
Blockedon: 739532

Comment 4 by dpa...@chromium.org, Jul 18 2017

Blockedon: 731881

Comment 5 by dpa...@chromium.org, Jan 17 2018

Blockedon: 802912
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a40026d3b0704173d56dbfc7fc597c31a73c36

commit 62a40026d3b0704173d56dbfc7fc597c31a73c36
Author: dpapad <dpapad@chromium.org>
Date: Wed Jan 17 17:57:31 2018

WebUI Polymer: Re-generate gyp and GN files, to update licence's year.

The auto-generation script uses Python's "date.today().year" to populate
the licence header, which causes some churn when reproduce.sh is run.
This is just a step to isolate trivial diff to its own CL, in preparation
of other work needed to use Polymer 2 in Chromium.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I12e721ee0a81086016e776d49302a17abf258d73
Reviewed-on: https://chromium-review.googlesource.com/869055
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529798}
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-a11y-announcer/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-a11y-announcer/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-a11y-keys/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-a11y-keys/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-behaviors/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-behaviors/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-collapse/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-collapse/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-dropdown/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-icon/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-icon/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-iconset-svg/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-iconset-svg/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-input/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-input/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-list/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-list/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-location/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-location/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-media-query/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-media-query/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-meta/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-meta/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-pages/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-pages/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-range-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-range-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-selector/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-selector/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/neon-animation/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/neon-animation/animations/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/neon-animation/animations/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-behaviors/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-behaviors/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-button/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-button/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-checkbox/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-checkbox/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-fab/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-fab/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-icon-button/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-icon-button/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-input/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-input/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-item/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-item/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-listbox/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-listbox/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-menu/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-progress/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-progress/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-radio-button/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-radio-button/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-radio-group/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-radio-group/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-ripple/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-ripple/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-slider/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-slider/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-spinner/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-tabs/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-tabs/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-toggle-button/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-toggle-button/compiled_resources2.gyp
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-tooltip/BUILD.gn
[modify] https://crrev.com/62a40026d3b0704173d56dbfc7fc597c31a73c36/third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp

Comment 7 by dpa...@chromium.org, Jan 24 2018

Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Status update:
Last week I performed more investigation on necessary steps to migrate. Listing
my current findings below:

1) Update all paper-*, iron-* element dependencies to their 2.x versions.
See example CLs
https://chromium-review.googlesource.com/c/chromium/src/+/882465
https://chromium-review.googlesource.com/c/chromium/src/+/882446

While doing so, it is likely that Closure compilation will fail with the new
code, and some PRs need to be sent upstream, for example see [1].

Note that the 2.x elements should work fine with our current version of Polymer
in third_party, whic his 1.11.2.


2) Find a paper-icon-button-light replacement and migrate over.
Type extensions are not supported in Polymer 2, see [2]. For that reason
paper-icon-button-light has not been ported to 2.x, see notice at [3]. There are
70+ occurrences of that element.

3) Develop replacements for all our cr-* elements that do use type extensions
and migrate to those.
Basically these are:
- cr-lazy-render
- cr-drawer
- cr-dialog
- cr-action-menu
- cr-link-row

4) Put Polymer 2 code somewhere under third_party/polymer.
There are two different approaches here.
 - Provide a flag that flips all WebUIs to Polymer2 all at once, and keep that flag off until all issues are
fixed.
 - No flag, just migrate WebUI pages one-by-one until all are on P2.


External issues:
5) https://github.com/Polymer/polymer-css-build/issues/16
6) Fix for https://github.com/Polymer/polymer/issues/4984 needs to be ported to Polymer 2.0.

There are some more findings, that I am omitting for now, since I am not 100%
sure if they will be relevant after previous items are addressed.

[1] https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fclosure_compilation%2F14800%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
[2]
https://www.polymer-project.org/2.0/docs/upgrade#remove-type-extension-elements
[3] https://github.com/PolymerElements/paper-icon-button#changes-in-20

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb42e883c1c87b51d63929d5a10903c89522300c

commit bb42e883c1c87b51d63929d5a10903c89522300c
Author: dpapad <dpapad@chromium.org>
Date: Thu Jan 25 08:53:48 2018

WebUI: Update Polymer paper-button version 1.0.13 -> 2.0.0

Also had to update paper-styles version 1.1.4 -> 1.3.1, and removed
the deprecated and unused shadow-layout.html.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I43fc909502ac321e3a6a512ca6b00c93a98abab2
Reviewed-on: https://chromium-review.googlesource.com/882446
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531851}
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-button/bower.json
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-button/paper-button.html
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-styles/bower.json
[delete] https://crrev.com/9030bb3ea938a0c982461e295f117f37ffa66e8f/third_party/polymer/v1_0/components-chromium/paper-styles/classes/shadow-layout.html
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-styles/classes/typography.html
[add] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-styles/element-styles/paper-item-styles.html
[add] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-styles/element-styles/paper-material-styles.html
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components-chromium/paper-styles/shadow.html
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/bb42e883c1c87b51d63929d5a10903c89522300c/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b416c2b5fce2d768925fbdaf7f5a70489140e86

commit 3b416c2b5fce2d768925fbdaf7f5a70489140e86
Author: dpapad <dpapad@chromium.org>
Date: Thu Jan 25 09:04:18 2018

WebUI: Update Polymer paper-fab version 1.2.0 -> 2.0.0

Also removing paper-material, since the previous paper-fab version was the last
usage of it.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic1ec8e70d5c5189ead7cb62c9e25f8f8dde5afee
Reviewed-on: https://chromium-review.googlesource.com/883565
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531855}
[modify] https://crrev.com/3b416c2b5fce2d768925fbdaf7f5a70489140e86/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/3b416c2b5fce2d768925fbdaf7f5a70489140e86/third_party/polymer/v1_0/components-chromium/paper-fab/bower.json
[modify] https://crrev.com/3b416c2b5fce2d768925fbdaf7f5a70489140e86/third_party/polymer/v1_0/components-chromium/paper-fab/paper-fab.html
[delete] https://crrev.com/dd9f5030ff04b33707cc2e94952db450dae9c814/third_party/polymer/v1_0/components-chromium/paper-material/bower.json
[delete] https://crrev.com/dd9f5030ff04b33707cc2e94952db450dae9c814/third_party/polymer/v1_0/components-chromium/paper-material/paper-material-shared-styles.html
[modify] https://crrev.com/3b416c2b5fce2d768925fbdaf7f5a70489140e86/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/3b416c2b5fce2d768925fbdaf7f5a70489140e86/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/3b416c2b5fce2d768925fbdaf7f5a70489140e86/ui/webui/resources/polymer_resources.grdp

Comment 10 by kochi@chromium.org, Jan 26 2018

Blocking: 806159
Summary: WebUI: [Metabug] Migrate to Polymer 2. (was: WebUI: [Metabug] track work necessary to migrate to Polymer 2.)
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 27 2018

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7909ce40db9c09507c7011b1977529564d501096

commit 7909ce40db9c09507c7011b1977529564d501096
Author: dpapad <dpapad@chromium.org>
Date: Sat Jan 27 19:55:37 2018

WebUI: Update Polymer paper-{tabs,spinner,listbox} to 2.x.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic3ebeca61c483721c96b597c406910637d920fcb
Reviewed-on: https://chromium-review.googlesource.com/887558
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532248}
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-listbox/paper-listbox.html
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-spinner/bower.json
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-behavior-extracted.js
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-lite.html
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-styles.html
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-tabs/bower.json
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tab.html
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tabs.html
[modify] https://crrev.com/7909ce40db9c09507c7011b1977529564d501096/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9ecc0100b490742b497305b97a68ca27756837e

commit c9ecc0100b490742b497305b97a68ca27756837e
Author: dpapad <dpapad@chromium.org>
Date: Mon Jan 29 20:10:13 2018

WebUI: Update Polymer paper-{progress,tooltip,item} to 2.x.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I92e07bca0041ed84a9b45339c89b61d05e8158de
Reviewed-on: https://chromium-review.googlesource.com/887779
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532564}
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-item/bower.json
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-item/paper-icon-item.html
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-body.html
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-item/paper-item.html
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-progress/bower.json
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress-extracted.js
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress.html
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-tooltip/bower.json
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components-chromium/paper-tooltip/paper-tooltip.html
[modify] https://crrev.com/c9ecc0100b490742b497305b97a68ca27756837e/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 29 2018

Blockedon: 807475
Blockedon: 808542
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a996cb5db5471df79d93bf39d5dec400ceb752de

commit a996cb5db5471df79d93bf39d5dec400ceb752de
Author: dpapad <dpapad@chromium.org>
Date: Sat Feb 03 03:00:45 2018

WebUI: Update Polymer iron-media-query version 1.0.8 -> 2.0.0.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icfcf0ee1b46ff4b16fd8ace0e21de6f27bef0f1a
Reviewed-on: https://chromium-review.googlesource.com/898242
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534245}
[modify] https://crrev.com/a996cb5db5471df79d93bf39d5dec400ceb752de/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/a996cb5db5471df79d93bf39d5dec400ceb752de/third_party/polymer/v1_0/components-chromium/iron-media-query/bower.json
[modify] https://crrev.com/a996cb5db5471df79d93bf39d5dec400ceb752de/third_party/polymer/v1_0/components-chromium/iron-media-query/iron-media-query.html
[modify] https://crrev.com/a996cb5db5471df79d93bf39d5dec400ceb752de/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bcb3cf992bd1f218550938169c6fb8da92d96d4

commit 3bcb3cf992bd1f218550938169c6fb8da92d96d4
Author: dpapad <dpapad@chromium.org>
Date: Thu Feb 08 22:04:41 2018

WebUI: Update Polymer iron-scroll-threshold, iron-collapse to 2.x.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib1a4680ce7ce15e945fd3a73dffa3f17a58ff2cb
Reviewed-on: https://chromium-review.googlesource.com/906974
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535538}
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components-chromium/iron-collapse/bower.json
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse.html
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/bower.json
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/iron-scroll-threshold-extracted.js
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/iron-scroll-threshold.html
[modify] https://crrev.com/3bcb3cf992bd1f218550938169c6fb8da92d96d4/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21cc91114458c940478d2712e2adcf17b5aec24e

commit 21cc91114458c940478d2712e2adcf17b5aec24e
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 09 23:36:33 2018

WebUI: Update Polymer papar-radio-{button,group} to 2.x.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iad4686cc3f09acb94834596be741d1b2d2e39bac
Reviewed-on: https://chromium-review.googlesource.com/910313
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535882}
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components-chromium/paper-radio-group/bower.json
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group-extracted.js
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group.html
[modify] https://crrev.com/21cc91114458c940478d2712e2adcf17b5aec24e/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e69f046f3192e36fe960484b85a0dfb5525a13c

commit 6e69f046f3192e36fe960484b85a0dfb5525a13c
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 13 20:19:14 2018

WebUI: Update Polymer iron-icons version 1.1.3 -> 2.0.1

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5a6f438554cfc6334000ef086f5b390d63224e25
Reviewed-on: https://chromium-review.googlesource.com/914711
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536442}
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/av-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/bower.json
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/communication-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/device-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/editor-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/hardware-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/image-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/iron-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/maps-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/notification-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/places-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components-chromium/iron-icons/social-icons.html
[modify] https://crrev.com/6e69f046f3192e36fe960484b85a0dfb5525a13c/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 14 2018

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbf4d6cce495d5797ffde3fdd04006b3e4000e39

commit dbf4d6cce495d5797ffde3fdd04006b3e4000e39
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Feb 14 22:02:10 2018

WebUI: Update Polymer paper-input version 1.1.21 -> 2.1.0.

In addition to the paper-input update this CL will:
 - Fix mis-styled components
 - Address TODOs that should be taken care of by update

R=dpapad@chromium.org

Bug: 738611,  807475 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cc1bdd22ea23e48f0c37db60bb5eb6163b0a55c
Reviewed-on: https://chromium-review.googlesource.com/902898
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536836}
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/chromeos/login/gaia_input.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/chromium.patch
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-addon-behavior-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-error.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/ui/file_manager/gallery/gallery.html

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8502d301e410b09c8b5859268fc297814fbdbb

commit 2c8502d301e410b09c8b5859268fc297814fbdbb
Author: dpapad <dpapad@chromium.org>
Date: Thu Feb 15 01:36:32 2018

WebUI: Update Polymer iron-collapse, iron-overlay-behavior to 2.x.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f3649304443c82c7604d4ba4c9e2ef0b966c5f1
Reviewed-on: https://chromium-review.googlesource.com/919643
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536919}
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/BUILD.gn
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-scroll-manager-extracted.js
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-scroll-manager.html
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown.html
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/BUILD.gn
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/compiled_resources2.gyp
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-focusables-helper-extracted.js
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-backdrop.html
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior.html
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[add] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-scroll-manager-extracted.js
[add] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-scroll-manager.html
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/2c8502d301e410b09c8b5859268fc297814fbdbb/ui/webui/resources/polymer_resources.grdp

Blockedon: 812926
Project Member

Comment 29 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89baf7e1ec7b0491de5a2e44f80283537cb955e3

commit 89baf7e1ec7b0491de5a2e44f80283537cb955e3
Author: dpapad <dpapad@chromium.org>
Date: Wed Feb 21 22:57:22 2018

WebUI: Update Polymer neon-animation version 1.2.4 -> 2.1.0

The Web Animations API polyfil is no longer included by default, so need to
manually import it in all places that use neon-animation.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie5b7ce2defcb7196162606e0cd1a3cc0baea2632
Reviewed-on: https://chromium-review.googlesource.com/927806
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538240}
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/login/active_directory_password_change.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/md_user_manager/user_manager_pages.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/BUILD.gn
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/BUILD.gn
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/compiled_resources2.gyp
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/fade-in-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/fade-out-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/hero-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/opaque-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/reverse-ripple-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/ripple-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-down-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-up-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-bottom-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-left-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-right-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-top-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-left-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-right-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-up-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/transform-animation.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/bower.json
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable-behavior-extracted.js
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages-extracted.js
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-behavior-extracted.js
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-behavior.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior.html
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components-chromium/neon-animation/neon-shared-element-animation-behavior-extracted.js
[modify] https://crrev.com/89baf7e1ec7b0491de5a2e44f80283537cb955e3/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 22 2018

Blockedon: 815009
Project Member

Comment 32 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f5c5a14f96d8404dc5aa69331437377137e679

commit 46f5c5a14f96d8404dc5aa69331437377137e679
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 23 18:31:12 2018

WebUI: Update Polymer iron-selector version 1.5.2 -> 2.0.1

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id88cb1a89d7eed7e2993dbf5f690708b61cc4143
Reviewed-on: https://chromium-review.googlesource.com/932978
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538831}
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/chrome/test/data/webui/settings/settings_menu_test.js
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/third_party/polymer/v1_0/components-chromium/iron-selector/bower.json
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/third_party/polymer/v1_0/components-chromium/iron-selector/iron-multi-selectable-extracted.js
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/third_party/polymer/v1_0/components-chromium/iron-selector/iron-selectable-extracted.js
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/third_party/polymer/v1_0/components-chromium/iron-selector/iron-selection-extracted.js
[modify] https://crrev.com/46f5c5a14f96d8404dc5aa69331437377137e679/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 33 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/196420416da3c3a963015626b027044c09359445

commit 196420416da3c3a963015626b027044c09359445
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 27 03:22:14 2018

WebUI: Update Polymer iron-autogrow-textarea version 1.0.13 -> 2.1.1

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I03971f6770bd35264d2162d93f5a9dcaa239c864
Reviewed-on: https://chromium-review.googlesource.com/938632
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539388}
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/BUILD.gn
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/bower.json
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/compiled_resources2.gyp
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea-extracted.js
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea.html
[modify] https://crrev.com/196420416da3c3a963015626b027044c09359445/third_party/polymer/v1_0/components_summary.txt

Blockedon: 818279
Project Member

Comment 35 by bugdroid1@chromium.org, Mar 5 2018

Project Member

Comment 37 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29e26f84ee58dade74a9da8cbfcd38b13433a2a0

commit 29e26f84ee58dade74a9da8cbfcd38b13433a2a0
Author: dpapad <dpapad@chromium.org>
Date: Thu Mar 22 23:31:50 2018

WebUI: Update various Polymer behaviors to 2.x.

 - paper-behaviors
 - iron-checked-element-behavior
 - iron-form-element-behavior

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaf9205f0dc45c85c3bfbbe6eb875af241ca647b9
Reviewed-on: https://chromium-review.googlesource.com/974567
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545288}
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/bower.json
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/bower.json
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/iron-form-element-behavior-extracted.js
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/paper-behaviors/BUILD.gn
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/paper-behaviors/bower.json
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/paper-behaviors/compiled_resources2.gyp
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior.html
[modify] https://crrev.com/29e26f84ee58dade74a9da8cbfcd38b13433a2a0/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 39 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a16826a63671a1c55d297a391bf52aeedda863a

commit 6a16826a63671a1c55d297a391bf52aeedda863a
Author: dpapad <dpapad@chromium.org>
Date: Tue Mar 27 03:40:05 2018

WebUI: Update Polymer paper-styles 1.3.1 -> 2.1.0.

Also removing a few paper-styles related files from polymer_resources.grdp
that are not used anywhere.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9eca1db59f522dea03738843e40c4e3e1aee6d38
Reviewed-on: https://chromium-review.googlesource.com/978651
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545988}
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/bower.json
[delete] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/third_party/polymer/v1_0/components-chromium/paper-styles/classes/global.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/classes/shadow.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/classes/typography.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/color.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/default-theme.html
[delete] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/third_party/polymer/v1_0/components-chromium/paper-styles/demo.css
[delete] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/third_party/polymer/v1_0/components-chromium/paper-styles/element-styles/paper-item-styles.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/element-styles/paper-material-styles.html
[delete] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/third_party/polymer/v1_0/components-chromium/paper-styles/paper-styles-classes.html
[delete] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/third_party/polymer/v1_0/components-chromium/paper-styles/paper-styles.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/shadow.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components-chromium/paper-styles/typography.html
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/6a16826a63671a1c55d297a391bf52aeedda863a/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 40 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58257f04aab00ba70ffc008e9fb3342acca02ac9

commit 58257f04aab00ba70ffc008e9fb3342acca02ac9
Author: dpapad <dpapad@chromium.org>
Date: Tue Mar 27 21:59:07 2018

WebUI: Update Polymer paper-ripple 1.0.9 -> 2.0.1.

This change does not actually modify the paper-ripple code at all, since WebUI
maintains a forked paper-ripple anyway. Only bower.json files are updated to
unblock further element upgrades.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I42bc76207c851a3fd287ecf6345e8476a1b87951
Reviewed-on: https://chromium-review.googlesource.com/982378
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546280}
[modify] https://crrev.com/58257f04aab00ba70ffc008e9fb3342acca02ac9/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/58257f04aab00ba70ffc008e9fb3342acca02ac9/third_party/polymer/v1_0/components-chromium/paper-ripple/bower.json
[modify] https://crrev.com/58257f04aab00ba70ffc008e9fb3342acca02ac9/third_party/polymer/v1_0/components_summary.txt

Cc: kochi@chromium.org
What's the status of this and is there any estimate for finishing?
(context: I'm planning the date for deprecating Shadow DOM V0 API)
This is an ongoing effort, and one of the top OKRs of our team. The goal is to finish it within Q2. There was a lot of progress in Q1 already. Let me know if you need more detail (also see "blocked on" bugs). 
Thanks for the update!  The plan sounds good, and if you see any
technical difficulty stemming from Shadow DOM V0 itself, please let me know.
Project Member

Comment 45 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8783880aca5fdd1089a172b00f86f44f50bf249

commit f8783880aca5fdd1089a172b00f86f44f50bf249
Author: dpapad <dpapad@chromium.org>
Date: Tue May 01 20:14:13 2018

WebUI: Update Polymer iron-scroll-target-behavior version 1.1.0 -> 2.1.1

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I231420748dc882a780100e3b7c1ac1f35fdc0b5c
Reviewed-on: https://chromium-review.googlesource.com/1022632
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555165}
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/bower.json
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/iron-scroll-target-behavior-extracted.js
[modify] https://crrev.com/f8783880aca5fdd1089a172b00f86f44f50bf249/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 46 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84baff3f501e0430ffe004ba4a2eee257c63e810

commit 84baff3f501e0430ffe004ba4a2eee257c63e810
Author: dpapad <dpapad@chromium.org>
Date: Fri May 11 03:40:58 2018

WebUI: Update a few Polymer iron-* elements to 2.x versions.

Specifically:
 - iron-a11y-announcer - 2.1.0
 - iron-a11y-keys-behavior - 2.1.1
 - iron-validatable-behavior - 2.1.0

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iad7ccbf1022cdc394d01272bd9cb75c8f41265e3
Reviewed-on: https://chromium-review.googlesource.com/1052911
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557783}
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/components-chromium/iron-a11y-announcer/bower.json
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/bower.json
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/iron-validatable-behavior-extracted.js
[modify] https://crrev.com/84baff3f501e0430ffe004ba4a2eee257c63e810/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 47 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d25ccaa969346c027fb03006218e0aaa2b82fd31

commit d25ccaa969346c027fb03006218e0aaa2b82fd31
Author: dpapad <dpapad@chromium.org>
Date: Tue May 22 19:33:15 2018

PDF Viewer: Remove unnecessary usage of iron-flex-layout.html.

This is in preparation of rolling iron-flex-layout.html to its latest version.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I25d400daa74fe9357a1be072fafaaa4237ed8dd3
Reviewed-on: https://chromium-review.googlesource.com/1068208
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560732}
[modify] https://crrev.com/d25ccaa969346c027fb03006218e0aaa2b82fd31/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html

Project Member

Comment 48 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d22d3736dc71822df139ec80adcb0a21ce7c67dd

commit d22d3736dc71822df139ec80adcb0a21ce7c67dd
Author: dpapad <dpapad@chromium.org>
Date: Wed May 23 17:54:41 2018

WebUI Polymer: Update iron-meta version 1.1.2 -> 2.1.1

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4099ab0cdc650c7fe702c5ebebca5977812a1ad8
Reviewed-on: https://chromium-review.googlesource.com/1069680
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561152}
[modify] https://crrev.com/d22d3736dc71822df139ec80adcb0a21ce7c67dd/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/d22d3736dc71822df139ec80adcb0a21ce7c67dd/third_party/polymer/v1_0/components-chromium/iron-meta/bower.json
[modify] https://crrev.com/d22d3736dc71822df139ec80adcb0a21ce7c67dd/third_party/polymer/v1_0/components-chromium/iron-meta/iron-meta-extracted.js
[modify] https://crrev.com/d22d3736dc71822df139ec80adcb0a21ce7c67dd/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 49 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ad82759072e98e6c5685d534c799e9225843e4b

commit 1ad82759072e98e6c5685d534c799e9225843e4b
Author: dpapad <dpapad@chromium.org>
Date: Wed May 23 19:18:11 2018

WebUI Polymer: Update iron-flex-layout version 1.3.1 -> 2.0.3.

Also updating chromium.patch to remove an unnecessary (for Chromium) backwards
compatibility change that was added to iron-flex-layout.html, which otherwise
would result in an unnecessary iron-flex-layout-extracted.js file.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4a7f03ead4f7f75ecbdb0670c6690f3b9139d117
Reviewed-on: https://chromium-review.googlesource.com/1069447
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561198}
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/chromium.patch
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/components-chromium/iron-flex-layout/bower.json
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/components-chromium/iron-flex-layout/iron-flex-layout-classes.html
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/components-chromium/iron-flex-layout/iron-flex-layout.html
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/reproduce.sh
[modify] https://crrev.com/1ad82759072e98e6c5685d534c799e9225843e4b/third_party/polymer/v1_0/rsync_exclude.txt

Blockedon: 846980
Blockedon: 847979
Blockedon: 848518
Blockedon: 849465
Blockedon: 849788
Blockedon: 850664
Project Member

Comment 56 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab80496c6a1084e7addd06fc9cca218642094f32

commit ab80496c6a1084e7addd06fc9cca218642094f32
Author: dpapad <dpapad@chromium.org>
Date: Sat Jun 09 03:44:11 2018

Bookmarks WebUI: Fix typos in closing dom-module tags.

This is causing the latest version of polymer-css-build (necessary for
Polymer 2) to blow up.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I04033b113cbd5350e033593b548e13adbd8392ed
Reviewed-on: https://chromium-review.googlesource.com/1094137
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565839}
[modify] https://crrev.com/ab80496c6a1084e7addd06fc9cca218642094f32/chrome/browser/resources/md_bookmarks/dnd_chip.html
[modify] https://crrev.com/ab80496c6a1084e7addd06fc9cca218642094f32/chrome/browser/resources/md_bookmarks/item.html

Blockedon: 852069
Blockedon: 852098
Project Member

Comment 59 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d3fbe7c1b77174a770d9cad9c0313e2d3a015f1

commit 8d3fbe7c1b77174a770d9cad9c0313e2d3a015f1
Author: dpapad <dpapad@chromium.org>
Date: Wed Jun 13 01:09:35 2018

Settings Polymer 2: Update dom-if logic in settings-animated-pages.

Polymer 2 automatically converts <template is="dom-if"> to
<dom-if><template>, so the query selector needs to be updated. Also
the way to get cached <template> contents is slightly different.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5625295e4138fa92a6a4b728123a7f58e3e06c0e
Reviewed-on: https://chromium-review.googlesource.com/1096476
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566669}
[modify] https://crrev.com/8d3fbe7c1b77174a770d9cad9c0313e2d3a015f1/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Cc: rbpotter@chromium.org
FYI, besides the dependent bugs the next big task is to get all automated tests passing with Polymer 2. Failures can be seen at [1], also attaching the list. Example CLs fixing some test can be seen at [2] and [3].

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_dbg_ng/2560
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1098299
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1097514

failing_tests.txt
4.9 KB View Download
Project Member

Comment 61 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76dc7b8037d74754af37cbb39209ba07b820fb6d

commit 76dc7b8037d74754af37cbb39209ba07b820fb6d
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jun 14 16:16:05 2018

Print Preview: Fix tests for Polymer2

Setting the plugin before attaching print-preview-app to the document
will no longer work in Polymer2. Add an interface for the plugin,
similar to the approach for the NativeLayer, and use this to stub out
checks for plugin compatibility and other plugin functions.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8428fba35ff5783e18679f99cc02f8d085f82a2e
Reviewed-on: https://chromium-review.googlesource.com/1097514
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567291}
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/browser/resources/print_preview/new/BUILD.gn
[add] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/browser/resources/print_preview/new/plugin_proxy.html
[add] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/browser/resources/print_preview/new/plugin_proxy.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/plugin_stub.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/76dc7b8037d74754af37cbb39209ba07b820fb6d/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 62 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43083f01e2eb804a7d0d13dd8b917c14bd0ad8b3

commit 43083f01e2eb804a7d0d13dd8b917c14bd0ad8b3
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 14 22:02:40 2018

WebUI Polymer 2: Fix a few Bookmarks tests.

Specifically fixing the following tests:
MaterialBookmarksActionsTest.All
MaterialBookmarksAppTest.All
MaterialBookmarksCommandManagerTest.All
MaterialBookmarksFolderNodeTest.All
MaterialBookmarksItemTest.All
MaterialBookmarksListTest.All
MaterialBookmarksPolicyTest.All
MaterialBookmarksReducersTest.All
MaterialBookmarksToastManagerTest.All
MaterialBookmarksToolbarTest.All
MaterialBookmarksUtilTest.All

Remaining bookmarks tests will be fixed in a follow up.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I62bd58f80208e024953b7f44a110a28db07d7cb4
Reviewed-on: https://chromium-review.googlesource.com/1100108
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567437}
[modify] https://crrev.com/43083f01e2eb804a7d0d13dd8b917c14bd0ad8b3/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/43083f01e2eb804a7d0d13dd8b917c14bd0ad8b3/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/43083f01e2eb804a7d0d13dd8b917c14bd0ad8b3/chrome/test/data/webui/md_bookmarks/test_util.js

Project Member

Comment 63 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d33d841ba9903ec8ad2a6874b181cfa2efe260ca

commit d33d841ba9903ec8ad2a6874b181cfa2efe260ca
Author: dpapad <dpapad@chromium.org>
Date: Tue Jun 19 00:23:07 2018

WebUI Polymer 2: Fixing some Settings tests to work with Polymer 2, part 1.

CrElementsLazyRenderTest.All
CrElementsPolicyIndicatorBehaviorTest.All
CrSettingsDropdownMenuTest.All
CrSettingsPeoplePageTest.All
CrSettingsPrefsTest.All
CrSettingsSystemPageTest.All

Note that in Polymer 2 (unlike Polymer 1), an element's local DOM is not ready,
until after the element is attached to the document. Several tests currently:

 - Either test UI elements not in the document, or
 - Interact with UI elements before they are appended to the document.

which leads to failures.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If8b05c283afa18b0e08b16365d1a8f53352765e6
Reviewed-on: https://chromium-review.googlesource.com/1098299
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568255}
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/browser/resources/settings/controls/extension_controlled_indicator.js
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/browser/resources/settings/people_page/sync_account_control.js
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/test/data/webui/cr_elements/cr_policy_indicator_behavior_tests.js
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/test/data/webui/settings/dropdown_menu_tests.js
[modify] https://crrev.com/d33d841ba9903ec8ad2a6874b181cfa2efe260ca/chrome/test/data/webui/settings/prefs_tests.js

Project Member

Comment 64 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02521e4bdacb277dbc4682c495139a8e9d7e6c06

commit 02521e4bdacb277dbc4682c495139a8e9d7e6c06
Author: dpapad <dpapad@chromium.org>
Date: Tue Jun 19 19:20:17 2018

WebUI Polymer 2 migration: Fix most History tests.

Specifically fixing:
MaterialHistoryItemTest.All
MaterialHistoryMetricsTest.All
MaterialHistoryRoutingTest.All
MaterialHistorySupervisedUserTest.All
MaterialHistorySyncedTabsTest.All
MaterialHistoryToolbarTest.All

Polymer.dom(element).querySelector no longer returns an Array. Instead it returns
an NodeList, and therefore there is no advantage of using it, compared
to using the native querySelector.

MaterialHistoryRoutingWithQueryParamTest.All will be addressed in separate CL.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ic46c25c87b7d9fcbd06ef21de4c07090e4014ba6
Reviewed-on: https://chromium-review.googlesource.com/1105488
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568559}
[modify] https://crrev.com/02521e4bdacb277dbc4682c495139a8e9d7e6c06/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/02521e4bdacb277dbc4682c495139a8e9d7e6c06/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/02521e4bdacb277dbc4682c495139a8e9d7e6c06/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/02521e4bdacb277dbc4682c495139a8e9d7e6c06/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/02521e4bdacb277dbc4682c495139a8e9d7e6c06/chrome/test/data/webui/md_history/test_util.js

Project Member

Comment 65 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6720b27ebcf35b1a045ae4a8e6cc9cd0d0cfbea4

commit 6720b27ebcf35b1a045ae4a8e6cc9cd0d0cfbea4
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jun 19 20:43:55 2018

Fix Downloads tests to work with Polymer2

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I516abef88d784a8936667b3c8b42a1ee4bda7efd
Reviewed-on: https://chromium-review.googlesource.com/1105285
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568593}
[modify] https://crrev.com/6720b27ebcf35b1a045ae4a8e6cc9cd0d0cfbea4/chrome/browser/resources/md_downloads/item.js
[modify] https://crrev.com/6720b27ebcf35b1a045ae4a8e6cc9cd0d0cfbea4/chrome/test/data/webui/md_downloads/item_tests.js
[modify] https://crrev.com/6720b27ebcf35b1a045ae4a8e6cc9cd0d0cfbea4/chrome/test/data/webui/md_downloads/manager_tests.js

Comment 66 by aee@chromium.org, Jun 20 2018

Blocking: 836773
Project Member

Comment 67 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe3eaf210ae31aa6a657d9d879cfd24016d55c82

commit fe3eaf210ae31aa6a657d9d879cfd24016d55c82
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jun 22 23:07:18 2018

WebUI Polymer2: Fix Extensions tests

Fix failing extensions browser tests for Polymer2.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I00cb68204fa3206f29e50d7044e50f1e6b8cc753
Reviewed-on: https://chromium-review.googlesource.com/1109450
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569822}
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/extension_code_section_test.js
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/extension_detail_view_test.js
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/extension_error_page_test.js
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/extension_item_test.js
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/extension_sidebar_test.js
[modify] https://crrev.com/fe3eaf210ae31aa6a657d9d879cfd24016d55c82/chrome/test/data/webui/extensions/extension_test_util.js

Project Member

Comment 68 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7345e7ef447fb5f13940b00fc343d85c4681a26

commit f7345e7ef447fb5f13940b00fc343d85c4681a26
Author: dpapad <dpapad@chromium.org>
Date: Tue Jun 26 22:46:33 2018

WebUI Polymer 2: Fixing some Settings tests to work with Polymer 2, part 2.

Specifically fixing:
CrSettingsCertificateManagerTest.All
CrSettingsLanguagesPageTest.Spellcheck
CrSettingsLanguagesPageTest.InputMethods
CrSettingsLanguagesPageTest.LanguageMenu

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie79c53113577172fe6f55cecda9a22562606c9a5
Reviewed-on: https://chromium-review.googlesource.com/1114283
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570563}
[modify] https://crrev.com/f7345e7ef447fb5f13940b00fc343d85c4681a26/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/f7345e7ef447fb5f13940b00fc343d85c4681a26/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/f7345e7ef447fb5f13940b00fc343d85c4681a26/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/f7345e7ef447fb5f13940b00fc343d85c4681a26/chrome/test/data/webui/settings/languages_page_tests.js

Project Member

Comment 69 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c50804763309c2b12c68c680ab71f479ce40a2f4

commit c50804763309c2b12c68c680ab71f479ce40a2f4
Author: dpapad <dpapad@chromium.org>
Date: Wed Jun 27 02:46:17 2018

WebUI Polymer 2: Fixing some Settings tests to work with Polymer 2, part 3.

Specifically fixing:
CrSettingsAppearanceFontsPageTest.All
CrSettingsAppearancePageTest.All
CrSettingsCategoryDefaultSettingTest.All
CrSettingsCategorySettingExceptionsTest.All
CrSettingsSiteDetailsPermissionTest.All
CrSettingsSiteDetailsTest.All
CrSettingsSiteListTest.SiteList

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0e45615eee75d823c2aaf7c6fca65e90ee222b4a
Reviewed-on: https://chromium-review.googlesource.com/1115499
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570645}
[modify] https://crrev.com/c50804763309c2b12c68c680ab71f479ce40a2f4/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/c50804763309c2b12c68c680ab71f479ce40a2f4/chrome/browser/resources/settings/controls/settings_slider.js
[modify] https://crrev.com/c50804763309c2b12c68c680ab71f479ce40a2f4/chrome/browser/resources/settings/site_settings/category_default_setting.js
[modify] https://crrev.com/c50804763309c2b12c68c680ab71f479ce40a2f4/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/c50804763309c2b12c68c680ab71f479ce40a2f4/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/c50804763309c2b12c68c680ab71f479ce40a2f4/chrome/test/data/webui/settings/appearance_page_test.js

FYI, the remaining failing tests are:

CrElementsPolicyPrefIndicatorTest.All
CrElementsScrollableBehaviorTest.All
CrSettingsMenuTest.SettingsMenu
CrSettingsPeoplePageSyncAccountControlTest.All
CrSettingsPeoplePageSyncPageTest.All
CrSettingsSliderTest.All
MaterialBookmarksDNDManagerTest.All
MaterialBookmarksRouterTest.All
MaterialBookmarksStoreTest.All
MaterialHistoryRoutingWithQueryParamTest.All
MediaRouterElementsBrowserTest.MediaRouterContainerCastModeList
MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1
MediaRouterElementsBrowserTest.MediaRouterContainerFirstRunFlow
MediaRouterElementsBrowserTest.MediaRouterContainerSinkList
MediaRouterElementsBrowserTest.MediaRouterRouteDetails
PasswordsAndFormsBrowserTest.uiTests
SettingsAutofillSectionBrowserTest.CreditCardTests

I am looking at CrSettings/CrElements, PasswordsAndFormsBrowserTest and SettingsAutofillSectionBrowserTest.
Project Member

Comment 71 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149b2c3bf037d1d7d9ee64ee93822bb47e9bb962

commit 149b2c3bf037d1d7d9ee64ee93822bb47e9bb962
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 28 19:25:01 2018

WebUI: Make cr-slider work with Polymer 2.

Users of cr-slider rely on a bubbling immediate-value-changed event to be
fired. In Polymer 2 this event does not bubble by default, and needs to be
re-fired.

As a result of this change CrSettingsSliderTest.All passes with Polymer 2.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifc5bf914fe57c61a7ad7360e9ee0c6a2fb859daf
Reviewed-on: https://chromium-review.googlesource.com/1117626
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571220}
[modify] https://crrev.com/149b2c3bf037d1d7d9ee64ee93822bb47e9bb962/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[add] https://crrev.com/149b2c3bf037d1d7d9ee64ee93822bb47e9bb962/chrome/test/data/webui/cr_elements/cr_slider_test.js
[modify] https://crrev.com/149b2c3bf037d1d7d9ee64ee93822bb47e9bb962/ui/webui/resources/cr_elements/cr_slider/cr_slider.js

Project Member

Comment 72 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa30df55af2e09937a287985e680e2fc202af7df

commit aa30df55af2e09937a287985e680e2fc202af7df
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 28 22:26:41 2018

WebUI: Fixing various UI elements and tests to pass with Polymer 2, part 4.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2a3058d0df03faba6b4975672ecfc3557c05d73a
Reviewed-on: https://chromium-review.googlesource.com/1117863
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571301}
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/md_extensions/item_list.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/md_user_manager/control_bar.html
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/browser/resources/settings/people_page/import_data_dialog.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/test/data/webui/settings/controlled_radio_button_tests.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/aa30df55af2e09937a287985e680e2fc202af7df/ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js

Project Member

Comment 73 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df9afcca2f5e11e556f01b626ac820fde76c58ce

commit df9afcca2f5e11e556f01b626ac820fde76c58ce
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jun 28 23:14:23 2018

WebUI Polymer2 Migration: fix 2 MD Bookmarks tests

Fixing MaterialBookmarksDNDManagerTest.All
and MaterialBookmarksStoreTest.All

Bug: 738611
Change-Id: I651e9ad57dbd0bd6bf3b453ee2e5dc5a656773ec
Reviewed-on: https://chromium-review.googlesource.com/1117891
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571317}
[modify] https://crrev.com/df9afcca2f5e11e556f01b626ac820fde76c58ce/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/df9afcca2f5e11e556f01b626ac820fde76c58ce/chrome/test/data/webui/md_bookmarks/store_test.js

Blockedon: 859689
Project Member

Comment 75 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff13ec2034d5d9e6f254d9b7f12eca0dadf57e33

commit ff13ec2034d5d9e6f254d9b7f12eca0dadf57e33
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jul 03 01:41:27 2018

WebUI Polymer2: Fix Bookmarks and History Routing

Fix routing in bookmarks and history to work with Polymer2, where the
race between iron-location and iron-query-params will cause queries
from the URL to be lost. This causes MaterialBookmarksRouterTest and
MaterialHistoryRoutingWithQueryParamTest to pass with Polymer2.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib5aad55c25f8f29b25cd56cd11f2d4110d5b9b48
Reviewed-on: https://chromium-review.googlesource.com/1121589
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572080}
[modify] https://crrev.com/ff13ec2034d5d9e6f254d9b7f12eca0dadf57e33/chrome/browser/resources/md_bookmarks/router.html
[modify] https://crrev.com/ff13ec2034d5d9e6f254d9b7f12eca0dadf57e33/chrome/browser/resources/md_bookmarks/router.js
[modify] https://crrev.com/ff13ec2034d5d9e6f254d9b7f12eca0dadf57e33/chrome/browser/resources/md_history/router.html
[modify] https://crrev.com/ff13ec2034d5d9e6f254d9b7f12eca0dadf57e33/chrome/browser/resources/md_history/router.js

Blockedon: 860069
FYI, I spawned a CrOS tryjob,  which revealed more failing tests, pasting below:

AudioPlayerBrowserTest.ChangeTracks
AudioPlayerBrowserTest.ChangeTracksPlayList
AudioPlayerBrowserTest.ChangeTracksPlayListIcon
AudioPlayerBrowserTest.ChangeVolumeLevel
AudioPlayerBrowserTestInGuestMode.OpenAudioOnDownloads
AudioPlayerBrowserTest.OpenAudioOnDownloads
AudioPlayerBrowserTest.OpenAudioOnDrive
AudioPlayerBrowserTest.TogglePlayState
BluetoothPairingDialogTest.Basic
CrComponentsNetworkConfigTest.All
CrElementsPolicyNetworkIndicatorTest.All
CrSettingsBluetoothPageTest.All
CrSettingsDevicePageTest.DisplayTest
CrSettingsDevicePageTest.KeyboardTest
CrSettingsDevicePageTest.PointersTest
CrSettingsDevicePageTest.PowerTest
CrSettingsFingerprintProgressArcTest.All
CrSettingsInternetDetailPageTest.InternetDetailPage
CrSettingsInternetPageTest.InternetPage
CrSettingsLanguagesPageTest.AddLanguagesDialog
CrSettingsLanguagesPageTest.InputMethods
CrSettingsLanguagesPageTest.LanguageMenu
CrSettingsLanguagesPageTest.Spellcheck
CrSettingsPeoplePageLockScreenTest.All
CrSettingsPeoplePageQuickUnlockAuthenticateTest.All
CrSettingsPeoplePageSetupPinDialogTest.All
CrSettingsRouteDynamicParametersTest.All
EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_DistinguishedName
EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_ErrorCard
EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_UIErrors
EulaTest.LoadOffline
EulaTest.LoadOnline
FileManagerJsTest.FilesTooltip
MultiDeviceSetupBrowserTest.Integration
MultiDeviceSetupBrowserTest.StartSetupPage
OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads
OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads_GuestMode
OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive
OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive_DriveFs
OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeMultipleFileDrive
OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeSingleFileDrive
OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeMultipleFileDrive
OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeSingleFileDrive
SettingsIdleLoadBrowserTest.All
TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads
TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads_GuestMode
TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDrive
TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDrive_DriveFs

Project Member

Comment 78 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9

commit 0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jul 10 02:07:10 2018

WebUI Polymer2: Remove use of /deep/ and bubble event in extensions

Remove usage of deep, and ensure that some events needed by the
manager bubble from the view manager.

Bug: 738611, 860069
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I687ba18b94595703fc859bcdc41c85bddf483a1e
Reviewed-on: https://chromium-review.googlesource.com/1125507
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573597}
[modify] https://crrev.com/0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9/chrome/browser/resources/md_extensions/item_list.js
[modify] https://crrev.com/0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9/chrome/browser/resources/md_extensions/view_manager.js
[modify] https://crrev.com/0be5a3a1a4a22ef97d74df4e5c6b4433d5772dd9/chrome/test/data/webui/extensions/extension_item_test.js

Blockedon: 862472
Project Member

Comment 80 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/881d2227a29f7a201140abf31f5a71f7e4bd5913

commit 881d2227a29f7a201140abf31f5a71f7e4bd5913
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jul 11 06:30:30 2018

Extensions: Add test to ensure that view change events bubble

This is currently broken in Polymer2.

Bug: 738611
Change-Id: I813b1b8aa6b4b4cfa31d1735f3b3b35f318e4c3a
Reviewed-on: https://chromium-review.googlesource.com/1125501
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574090}
[modify] https://crrev.com/881d2227a29f7a201140abf31f5a71f7e4bd5913/chrome/test/data/webui/extensions/extension_view_manager_test.js

Project Member

Comment 81 by bugdroid1@chromium.org, Jul 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd1a01297b427a3d95bed8a6c3dd0cffef27154

commit 7cd1a01297b427a3d95bed8a6c3dd0cffef27154
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Jul 14 05:59:58 2018

WebUI Polymer2 Migration: Fix pref indicator inheritance issue

Overriding Polymer properties defined in a behavior was never fully
specified, and could lead to weird corner cases, which Polymer 2
explicitly decided to address. One new specification is that
properties declared as computed in a behavior should not be overridden
in elements implementing the behavior.

As a result the indicatorTooltip property in CrPolicyIndicatorBehavior
can no longer be overridden in Polymer2. Remove this property from
the behavior and put it in the 3 elements implementing the behavior
individually, while retaining the behavior's computation method since
it is used by all 3.

This causes
CrElementsPolicyNetworkIndicatorTest.All (CrOS only) and
CrElementsPolicyPrefIndicatorTest.All
to pass with Polymer 2.

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iab7824c5d69c59b00fa0f1a173e3d5c85ec7d2e4
Reviewed-on: https://chromium-review.googlesource.com/1135631
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575155}
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/chrome/test/data/webui/cr_elements/cr_policy_indicator_behavior_tests.js
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_indicator.html
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_indicator.js
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/7cd1a01297b427a3d95bed8a6c3dd0cffef27154/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js

Labels: M-71
Blockedon: 875443
Blockedon: 881104
Blockedon: 879261
Blockedon: 885294
Labels: -M-71 M-72
Project Member

Comment 88 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/177774d57a744b75630cba5507c3bf1ed419aea3

commit 177774d57a744b75630cba5507c3bf1ed419aea3
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 17 01:18:56 2018

WebUI: Enable WebUIPolymer2 flag by default on Desktop.

The only remaining automated tests failing with Polymer 2 are ChromeOS-only
tests (see crbug.com/875443).

Enabling by default on ToT will help us identify breakages that are not caught
by automated tests. This CL might get reverted/relanded a couple of
times as breakages not covered by tests are discovered.

Also expecting/hoping ChromeOS test failures to be addressed soon.

Bug: 738611
Change-Id: I456f2bb9bc2022d575cf56a099dee0b3a26401e5
Reviewed-on: https://chromium-review.googlesource.com/c/1279191
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600225}
[modify] https://crrev.com/177774d57a744b75630cba5507c3bf1ed419aea3/content/public/common/content_features.cc

Blockedon: 896748
Blockedon: 899855
Project Member

Comment 91 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adc50b30e3cbd6a42b26b53357c3be48f7688ef4

commit adc50b30e3cbd6a42b26b53357c3be48f7688ef4
Author: dpapad <dpapad@chromium.org>
Date: Fri Nov 16 18:29:18 2018

WebUI Polymer: Cleanup reproduce.sh and remove TODO.

 - Several "rm" commands are unnecessary because of rsync_exclude.txt.
 - Audited code that was replacing NBSP in polymer-mini.html (added in
   r332329). Seems to have no effect (no diff exists after running
   the command). Removed related TODO for Polymer 2.
 - Remove unused files from third_party/web-animations-js/. These files
   are not included in the build anyway.

Bug: 738611
Change-Id: I372143a9bc1fd3f18d5aa6fb7fe735fdbdb82015
Reviewed-on: https://chromium-review.googlesource.com/c/1338334
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608860}
[modify] https://crrev.com/adc50b30e3cbd6a42b26b53357c3be48f7688ef4/third_party/polymer/v1_0/reproduce.sh
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/.bower.json
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/CONTRIBUTING.md
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/History.md
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/README.md
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/bower.json
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/web-animations-next-lite.min.js.map
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/web-animations-next.min.js
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/web-animations-next.min.js.map
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/web-animations.html
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/web-animations.min.js
[delete] https://crrev.com/5f12700c92d5ea851a0cf52cb6f18971dcc0b543/third_party/web-animations-js/sources/web-animations.min.js.map

Project Member

Comment 92 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dab98eb1468afdbdf9b8b2c62291cff10f6ad17f

commit dab98eb1468afdbdf9b8b2c62291cff10f6ad17f
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Nov 27 23:19:09 2018

WebUI: Roll shadycss to version 1.6.0

This improves Web UI load times with Polymer 2 by 11-14%.

Bug: 738611
Change-Id: I2bf47a8b72730d019772824f8af9359dad30b364
Reviewed-on: https://chromium-review.googlesource.com/c/1351421
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611398}
[modify] https://crrev.com/dab98eb1468afdbdf9b8b2c62291cff10f6ad17f/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/dab98eb1468afdbdf9b8b2c62291cff10f6ad17f/third_party/polymer/v1_0/components-chromium/polymer2/polymer-extracted.js

Blockedon: 921788

Comment 94 by yoichio@chromium.org, Today (20 hours ago)

Labels: -Pri-2 -M-72 M-74 Pri-1

Comment 95 by yoichio@chromium.org, Today (20 hours ago)

FYI, this is the patch that removes Shadow DOM V0, Custom Element V0 and HTML Imports APIs that would be shipped since M74
https://chromium-review.googlesource.com/c/chromium/src/+/1420637

As you might know, the patch that reenables the APIs for WebUI on the patch was shipped:
https://chromium-review.googlesource.com/c/chromium/src/+/1362713
This is a last-resort for the removal and should be reverted.

So we need both to patch 1420637 and revert 1362713 to confirm if migration works.


Comment 96 by dpa...@chromium.org, Today (20 hours ago)

@yoichio: The migration referred in this bug does not include moving away from HTML imports. It only includes moving off of Shadow DOMv0 (Polymer1->Polymer2).

There is (a lot) of work remaining for moving away from HTML imports, and I've asked our PM to contact you for more specifics. I think it would be useful if we sync about current status and future work sometime soon.

Thanks!

Sign in to add a comment