New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738598 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

New autotest lxc unit tests fail on moblab

Project Member Reported by kenobi@chromium.org, Jun 30 2017

Issue description

Running the new autotest lxc unit tests fails on moblab.  For example:

sudo python site_utils/lxc/container_unittest.py -v

The reason for this is that unit tests attempt to run in a separate directory from the regular lxc directory, and the container_bucket code for setting up the base image fails on moblab in this scenario.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d8542a8d5620deb087af921d08a03e70baa446e7

commit d8542a8d5620deb087af921d08a03e70baa446e7
Author: Ben Kwa <kenobi@google.com>
Date: Tue Jul 11 07:39:02 2017

Address container differences on moblab vs shard.

Moblab and shards use different images, and the container setup code
works for the latter but not the former, specifically when specifying a
custom lxc path.  This causes unit tests to fail on moblab.

Fix the offending code, and add tests.

BUG= chromium:738598 

TEST=sudo python site_utils/lxc/container_bucket_unittest.py

Change-Id: I971e42f6054f094ceb5de6c0203f198847e5a11e
Reviewed-on: https://chromium-review.googlesource.com/558015
Commit-Ready: Ben Kwa <kenobi@chromium.org>
Tested-by: Ben Kwa <kenobi@chromium.org>
Reviewed-by: Ben Kwa <kenobi@chromium.org>

[modify] https://crrev.com/d8542a8d5620deb087af921d08a03e70baa446e7/site_utils/lxc/container_bucket.py
[modify] https://crrev.com/d8542a8d5620deb087af921d08a03e70baa446e7/site_utils/lxc/container_bucket_unittest.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1b617599f43e88a40eabbd2570e90649c0ede990

commit 1b617599f43e88a40eabbd2570e90649c0ede990
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Jul 11 22:51:51 2017

autotest: revert recent lxc changes

This CL reverts d8542a8d5620deb087af921d08a03e70baa446e7 and
966db080d632ab2b7c6534e717762173dad3938b.

which correspond to
https://chromium-review.googlesource.com/c/558015/ and
https://chromium-review.googlesource.com/c/538127/

BUG=chromium:741139,  chromium:738598 , chromium:720219
TEST=None

Change-Id: I478804455eca0775b04ede5152d8345408ee9468
Reviewed-on: https://chromium-review.googlesource.com/567057
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[delete] https://crrev.com/2bfd243650cb866174efddc65c0e8271f6e28f7b/site_utils/lxc/unittest_cleanup.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/site_utils/lxc/container.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/site_utils/lxc/utils.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/site_utils/lxc/lxc_functional_test.py
[delete] https://crrev.com/2bfd243650cb866174efddc65c0e8271f6e28f7b/site_utils/lxc/unittest_logging.py
[delete] https://crrev.com/2bfd243650cb866174efddc65c0e8271f6e28f7b/site_utils/lxc/container_bucket_unittest.py
[delete] https://crrev.com/2bfd243650cb866174efddc65c0e8271f6e28f7b/site_utils/lxc/zygote_unittest.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/global_config.ini
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/site_utils/lxc/constants.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/site_utils/lxc/container_bucket.py
[delete] https://crrev.com/2bfd243650cb866174efddc65c0e8271f6e28f7b/site_utils/lxc/zygote.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/utils/unittest_suite.py
[modify] https://crrev.com/1b617599f43e88a40eabbd2570e90649c0ede990/site_utils/lxc/__init__.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c0ce5456d710eb5f9410e183fe768c216509e4b1

commit c0ce5456d710eb5f9410e183fe768c216509e4b1
Author: Ben Kwa <kenobi@google.com>
Date: Thu Jul 13 18:44:40 2017

autotest: reland recent lxc changes

This reverts commit 1b617599f43e88a40eabbd2570e90649c0ede990, which effectively
relands the following commits:

d8542a8d5 Address container differences on moblab vs shard.
d3498cc07 Create Zygote, a configurable container.
966db080d Create a new module for lxc code.

i.e.
https://chromium-review.googlesource.com/c/558015/
https://chromium-review.googlesource.com/c/557061/
https://chromium-review.googlesource.com/c/538127/

It also fixes the problem introduced by those CLs, and adds new unittests (see
new container_unittest.py) for those conditions.

BUG=chromium:741139,  chromium:738598 , chromium:720219
TEST=sudo python site_utils/lxc/container_unittest.py -v
TEST=sudo python site_utils/lxc/lxc_functional_test.py -v
TEST=sudo python site_utils/lxc/zygote_unittest.py -v
TEST=sudo python site_utils/lxc/container_bucket_unittest.py -v

Change-Id: I6c1c23426a4baf4e12135c4ef8b25fdefabbf46b
Reviewed-on: https://chromium-review.googlesource.com/566741
Commit-Ready: Ben Kwa <kenobi@chromium.org>
Tested-by: Ben Kwa <kenobi@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[add] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/unittest_cleanup.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/container.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/utils.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/lxc_functional_test.py
[add] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/unittest_logging.py
[add] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/container_bucket_unittest.py
[add] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/zygote_unittest.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/global_config.ini
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/constants.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/container_bucket.py
[add] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/zygote.py
[add] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/container_unittest.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/utils/unittest_suite.py
[modify] https://crrev.com/c0ce5456d710eb5f9410e183fe768c216509e4b1/site_utils/lxc/__init__.py

Comment 4 by kenobi@chromium.org, Jul 17 2017

Status: Fixed (was: Started)

Sign in to add a comment