New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738591 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cbuildbot bootstrap: Fails to cherry-pick a chromite CL if it depends on a non-chromite CL

Project Member Reported by pprabhu@chromium.org, Jun 30 2017

Issue description

Seen for these two CLs:

chromite: https://chromium-review.googlesource.com/c/553462/
depends on
crosutils: https://chromium-review.googlesource.com/c/553404/

This pre-cq build complained in the BootstrapStage: 
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/41946
https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Fpre_cq%2F41946%2F%2B%2F%2A%2A%2Fstdout&s=chromeos%2Fbb%2Fchromiumos.tryserver%2Fpre_cq%2F41946%2F%2B%2F%2A%2A%2Fstderr

but then moved on.
My reading of the code suggests that a paladin builder will actually fail at this point.


I dug a bit and my current understanding is:
(http://cs/chromeos_public/chromite/cbuildbot/stages/sync_stages.py?l=187&rcl=8fbe8f9f69c19213551eccb9adcc31fd6a6df18e)

- Bootstrap looks for all changes that need to be applied
- filters to just the chromite changes
- creates a manifest containing just the chromite project
- tries to apply the _transaction_ for the chosen changes
- At this point, the transaction contains the crosutils change as well. This is supposed to be skipped / failed
- But I see that it fetches the crosutils change, and perhaps tries to apply it to the chromite project (and fails).


This will only happen when a chromite change depends on a non chromite change, i.e., very rarely.

To test this theory, bmgordon@ is going to remove the chromite --> crosutils dependence and try the pre-cq again.
 
I removed the dependency from 553404 -> 553462 and confirmed that the pre-cq makes it past bootstrap now for 553404 (http://uberchromegw/i/chromiumos.tryserver/builders/pre_cq/builds/41955).

pre-cq still shows the same error for 553462 (http://uberchromegw/i/chromiumos.tryserver/builders/pre_cq/builds/41964).

The chromite -> crosutils dependency is needed, but I can just wait for 553404 to be merged.
Labels: OS-Chrome
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Hi, this bug has no status updates recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be closed. Thank you.

Sign in to add a comment