New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738583 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

NTP shows "about:blank" in VR mode

Project Member Reported by est...@chromium.org, Jun 30 2017

Issue description

Chrome Version: 61.0.3145.0
OS: Android

What steps will reproduce the problem?
(1) Visit the NTP in VR mode

What is the expected result?
Omnibox is blank or doesn't show up

What happens instead?
Omnibox says about:blank (unnecessarily syntax-y/confusing to non-technical users)


 
This might be related to code in chrome_toolbar_model_delegate.cc.  Example:

return !search::IsInstantNTP(GetActiveWebContents())
Cc: cjgrant@chromium.org
Owner: mthiesse@chromium.org
Michael, I think we want whatever signal hides the URL to come from ToolbarModel if possible, and if not that, we can override the "show URL" property with extra logic in our new ToolbarHelper class.
Labels: VR-BBB

Comment 5 by tiborg@chromium.org, Jul 12 2017

Cc: mthiesse@chromium.org
Owner: tiborg@chromium.org

Comment 6 by tiborg@chromium.org, Jul 12 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf

commit 2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jul 17 16:46:22 2017

[vr] Add e2e test for native UI

This should let us confirm our URL behavior on NTP and friends.
It also provides a convenient place to do more testing of
native UI in VR.

Bug:  738583 
Change-Id: I983016bdcef62ab83e0265929e7b00230a1a661f
Reviewed-on: https://chromium-review.googlesource.com/571948
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487116}
[modify] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/android/BUILD.gn
[modify] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[add] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNativeUiTest.java
[modify] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/2230cfaa7af10a8cf0aeae6c1e2262517f6ae7cf/chrome/browser/android/vr_shell/vr_shell.h

Status: Fixed (was: Started)
Looks like this is fixed! Please reopen if I've got that wrong.
Cc: joshcarpenter@chromium.org
 Issue 691576  has been merged into this issue.
Labels: Test-Manual

Sign in to add a comment