New issue
Advanced search Search tips

Issue 738580 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Restrict height of Media Router device list

Project Member Reported by sko...@chromium.org, Jun 30 2017

Issue description

During UI review of local media casting, the UX team requested that we limit the height of the Media Router dialog to max 5 entries (including the search box), and provide scroll bars if the device count exceeds this limit.  Currently the dialog will stretch to fill up most of the vertical space of the browser window, but UX felt this was not correct.

Note that dialog height should be shorter still if the browser window height cannot accommodate five items.
 
Owner: taku...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3027bb105137b6c1c519b9d48ddb802089f33999

commit 3027bb105137b6c1c519b9d48ddb802089f33999
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Jul 18 17:14:27 2017

[Media Router] Limit dialog height to 5 sink list items

This CL limits the height of the sink list view in the Media Router dialog to 5
items (including the search box).

This CL also adds margin-bottom to #sink-list-view instead of dynamically
adding padding-bottom to various elements.

Screenshots:
https://docs.google.com/document/d/12e2KFrz_sltuGsI6VcB_0W7FdgQD8_Z3j3xQXHXOiTU/edit

Bug:  738580 
Change-Id: Ie97e4d04faec148ceb9a2870cbcebce494738f78
Reviewed-on: https://chromium-review.googlesource.com/574972
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Jennifer Apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487509}
[modify] https://crrev.com/3027bb105137b6c1c519b9d48ddb802089f33999/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/3027bb105137b6c1c519b9d48ddb802089f33999/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Status: Fixed (was: Assigned)
This was the subject of a long debate, following implementations that went both ways, when we implemented MR to begin with (though I don't have a reference to this).

I'd like to make sure that a passing comment in a review of an unrelated feature doesn't reverse this behavior unintentionally.

As a user with many devices, I find this behavior to be strictly worse than the old one.  It's a jarring change from old behavior (where you naturally assume the device has not been discovered), and even once you get used to it, if your most commonly used device is below the fold, it requires extra interactions every single time you cast.  I'm unclear why any user with >5 devices would find this to be beneficial.  Can we revisit?

Comment 5 by mfo...@chromium.org, Mar 31 2018

Labels: -Hotlist-Fixit-PE2017

Sign in to add a comment