New issue
Advanced search Search tips

Issue 738578 link

Starred by 1 user
Status: WontFix
Owner:
cjgrant@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Info (i) icon is missing from VR browser on Canary

Project Member Reported by est...@chromium.org, Jun 30 2017 
Chrome Version: 61 canary (sorry, watching someone else test and don't have exact version)
OS: Android

What steps will reproduce the problem?
(1) Visit http://example.com in VR browser

What is the expected result?
Info (i) icon is shown next to http://example.com

What happens instead?
No security indicator icon

I don't think this is necessarily a blocker (it matches regular Clank) but want to check if it was an intentional change.

Comment 1 by cjgrant@chromium.org, Jun 30 2017 

This came with the ToolbarModel change.  That change was an opportunity to make the icon more consistent with clank, but I should have checked.

The icon is now only drawn if not security_state::NONE (and we have an icon available).  See:

https://cs.chromium.org/chromium/src/chrome/browser/android/vr_shell/textures/url_bar_texture.cc?q=url_bar_texture.cc+package:%5Echromium$&dr&l=222

Comment 2 by cjgrant@chromium.org, Jun 30 2017 

Emily, I should have asked explicitly whether you want the icon restored, or prefer the new behavior.  Either is fine with me.

Comment 3 by est...@chromium.org, Jul 1 2017

Status: WontFix (was: Assigned)
I'd be fine either way; I think it's okay not to show it since we don't on Clank and you can't click on it in VR mode anyway. I'll WontFix this. Thanks for the clarification.
►

Sign in to add a comment