New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738531 link

Starred by 2 users
Status: Fixed
Owner:
shuchen@chromium.org
Closed: Aug 15
Cc:
█ nona@chromium.org
satorux@chromium.org
msw@chromium.org
shend@chromium.org
osh...@chromium.org
yhanada@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 756059



Sign in to add a comment

Move IME mode indicator bubble into //ash ?

Project Member Reported by jamescook@chromium.org, Jun 30 2017 
Filing mostly for discussion. See https://chromium-review.googlesource.com/c/552902/

IMEs are implemented as extensions in //chrome/browser. However, the IME system has to show UI like the candidate window and the little "mode indicator" bubble. These are more like system-ui than browser UI. For example, you can use IMEs to type into the login screen, network connect dialogs, etc.

The candidate window and mode indicator bubble code lives in //ui/chromeos/ime, probably from the Athena days. It used to live in //ash.

For mustash I had to add a delegate to the mode indicator bubble so it can parent itself correctly (it needs to know about ash containers). I think a better solution would be to move this UI code out of //ui/chromeos/ime back into //ash/ime.

Thoughts?

Comment 1 by satorux@chromium.org, Jul 4 2017

Cc: yhanada@chromium.org nona@chromium.org
+yhanada +nona.  Sounds reasonable to me.

Comment 2 by osh...@chromium.org, Jul 5 2017 

sg

Comment 3 by omrilio@chromium.org, Aug 9 2017 

sounds reasonable to me too.

Comment 4 by omrilio@chromium.org, Aug 9 2017

Status: Available (was: Untriaged)

Comment 5 by afakhry@chromium.org, Aug 15 2017

Owner: shuchen@chromium.org
Status: Assigned (was: Available)
<please triage>

Comment 6 by satorux@chromium.org, Aug 16 2017

Cc: shuchen@chromium.org
Owner: blakeo@chromium.org
may be a good item?

Comment 7 by blakeo@chromium.org, Dec 26 2017

Blocking: 756059

Comment 8 by blakeo@chromium.org, Feb 27 2018

Owner: shend@chromium.org

Comment 9 by shend@chromium.org, Jul 30

Cc: -shuchen@chromium.org shend@chromium.org
Owner: shuchen@chromium.org
Assigning to shuchen@ for triage as it is related to 756059.

Comment 10 by dxie@google.com, Aug 13

Labels: Proj-Mustash
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96

commit 3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96
Author: Shu Chen <shuchen@google.com>
Date: Wed Aug 15 04:18:47 2018

Moves the IME mode indicator view to ash.

This cl also removes the unnecessary ModeIndicatorController, because
1) Init widget container can be done directly in ash.
2) ImeControllerClient has already listened to InputMethodChanged event.
3) The anchor bounds can be got via the IMECandidateWindowHandlerInterface.

Bug:  738531 
Change-Id: Ieee87fde776be2f33121da52293b886933106205
Reviewed-on: https://chromium-review.googlesource.com/1170717
Commit-Queue: Shu Chen <shuchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583164}
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/BUILD.gn
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/ime_controller.cc
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/ime_controller.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/ime_controller_unittest.cc
[add] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/ime_mode_indicator_view.cc
[add] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/ime_mode_indicator_view.h
[add] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/mode_indicator_observer.cc
[add] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/mode_indicator_observer.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/test_ime_controller.cc
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/ime/test_ime_controller.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ash/public/interfaces/ime_controller.mojom
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/browser/chromeos/input_method/candidate_window_controller_impl.h
[delete] https://crrev.com/d4bef8119c4af33a847311174ef651d01c61318f/chrome/browser/chromeos/input_method/mode_indicator_browsertest.cc
[delete] https://crrev.com/d4bef8119c4af33a847311174ef651d01c61318f/chrome/browser/chromeos/input_method/mode_indicator_controller.cc
[delete] https://crrev.com/d4bef8119c4af33a847311174ef651d01c61318f/chrome/browser/chromeos/input_method/mode_indicator_controller.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/browser/ui/ash/ime_controller_client.cc
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/browser/ui/ash/ime_controller_client.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/browser/ui/ash/ime_controller_client_unittest.cc
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/chrome/test/BUILD.gn
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ui/base/ime/chromeos/ime_candidate_window_handler_interface.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ui/base/ime/chromeos/mock_ime_candidate_window_handler.cc
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ui/base/ime/chromeos/mock_ime_candidate_window_handler.h
[modify] https://crrev.com/3cb6c3fe93adc68f418c0d6867e45a8bd0c9ba96/ui/chromeos/BUILD.gn
[delete] https://crrev.com/d4bef8119c4af33a847311174ef651d01c61318f/ui/chromeos/ime/mode_indicator_view.cc
[delete] https://crrev.com/d4bef8119c4af33a847311174ef651d01c61318f/ui/chromeos/ime/mode_indicator_view.h

Comment 12 by shuchen@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment