New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Ignore non HTTP/HTTPS resource loads in page load metrics

Project Member Reported by bmcquade@chromium.org, Jun 30 2017

Issue description

We don't want to count non-network activity (blobs, data uris, etc) as loaded bytes, so we should ignore these resources.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6f62c738b9b3717139bd41deb0fde1cba4a206

commit 0d6f62c738b9b3717139bd41deb0fde1cba4a206
Author: Bryan McQuade <bmcquade@chromium.org>
Date: Fri Jun 30 20:00:56 2017

[page load metrics]: Ignore non HTTP/HTTPS resource loads

Bug:  738509 
Change-Id: I0ee67acbfcda4d6ad608a8ecc194bc094ce381d6
Reviewed-on: https://chromium-review.googlesource.com/558425
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483797}
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/0d6f62c738b9b3717139bd41deb0fde1cba4a206/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

Owner: bmcquade@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment