New issue
Advanced search Search tips

Issue 738506 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 714735



Sign in to add a comment

Different default browser breaks webapk affinity

Project Member Reported by yfried...@chromium.org, Jun 30 2017

Issue description

1. Have chrome stable installed
2. Install a webapk from chrome canary.
3. Launch the new webapk.

It launches with Stable as its host browser.

We believe this is beause when querying for browsers, webapk only returns the default browser.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0afceb5ed2c32fcc061e2ad0d8d9df87261d3d46

commit 0afceb5ed2c32fcc061e2ad0d8d9df87261d3d46
Author: hanxi <hanxi@chromium.org>
Date: Fri Jun 30 22:18:54 2017

Fix Different default browser breaks webapk affinity.

On L+, when a default browser is set, PackageManager#queryIntentActivities()
with flag |PackageManager.MATCH_DEFAULT_ONLY| will return only the ResolvedInfo
of the default browser, rather than the ones of all installed browsers. This makes
WebApkUtils#getInstalledBrowserResolveInfos() returns wrong resutls. To fix it,
we pass in |PackageManager.MATCH_ALL| as flag.

BUG= 738506 

Review-Url: https://codereview.chromium.org/2964273002
Cr-Commit-Position: refs/heads/master@{#483843}

[modify] https://crrev.com/0afceb5ed2c32fcc061e2ad0d8d9df87261d3d46/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/0afceb5ed2c32fcc061e2ad0d8d9df87261d3d46/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkUtils.java

Status: fix (was: Assigned)
Status: Fixed (was: Fix)

Sign in to add a comment