New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738505 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocked on:
issue 490074



Sign in to add a comment

OT: Migrate content/renderer/origin_trials/

Project Member Reported by aval...@chromium.org, Jun 30 2017

Issue description

For the mojo migration, https://goo.gl/809bwy

content/renderer/origin_trials/ 

needs to migrate to 

core/origin_trials/
 
Need to find a new home for content/common/origin_trials/ which was called by content/{browser,renderer}/origin_trials/.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af67da3835ba7bad617216e7b64dc464d03a6347

commit af67da3835ba7bad617216e7b64dc464d03a6347
Author: Alex Vallée <avallee@google.com>
Date: Thu Jul 27 23:38:23 2017

[OriginTrials] Create origin_trials subfolder in WebKit/common.

Add origin_trials owners for common code to be migrated from
content/common that will be referenced from blink.

BUG:  738505 
Change-Id: I498b6b516b2c159e18047c31c21ef9e4e25f9c37
Reviewed-on: https://chromium-review.googlesource.com/587458
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490114}
[add] https://crrev.com/af67da3835ba7bad617216e7b64dc464d03a6347/third_party/WebKit/common/origin_trials/OWNERS

Comment 3 by cha...@chromium.org, Aug 21 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db4232d04f791905c88919cf9b845137cf65b125

commit db4232d04f791905c88919cf9b845137cf65b125
Author: Alex Vallée <avallee@chromium.org>
Date: Thu Oct 12 01:17:05 2017

[OriginTrials] Migrate content/common/origin_trials.

This common code must be moved to the new folder under WebKit/common
which can be included by both content and blink.

Used tools/git/mass-rename.py to keep things building with the file
rename.

Follow up: Delete content/renderer/origin_trials and rewrite to call
this code directly. Requires conversion from WebSecurityOrigin to
url::Origin.

Details of this patch in https://docs.google.com/document/d/1FXWqvh8QDZS4BMJWrGHfEcCOHnoBF1DjN3AN8lo6Puc/edit

Bug:  738505 
Change-Id: I52763e32c7b4ac3ac7a3194e0c40bd9d4350aa9a
Reviewed-on: https://chromium-review.googlesource.com/591932
Commit-Queue: Alex Vallee <avallee@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508197}
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/browser/service_worker/link_header_support.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/browser/service_worker/service_worker_database.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/common/BUILD.gn
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/common/origin_trials/OWNERS
[add] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/common/origin_trials/trial_policy_impl.cc
[add] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/common/origin_trials/trial_policy_impl.h
[delete] https://crrev.com/5004f01e55433edf3f1582d7d0f04c0804f2afad/content/common/origin_trials/trial_token_validator.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/renderer/BUILD.gn
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/renderer/DEPS
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/renderer/origin_trials/web_trial_token_validator_impl.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/renderer/origin_trials/web_trial_token_validator_impl.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/test/BUILD.gn
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/test/fuzzer/DEPS
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/content/test/fuzzer/origin_trial_token_fuzzer.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/BUILD.gn
[add] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_policy.h
[rename] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_token.cc
[rename] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_token.h
[rename] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_token_unittest.cc
[rename] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_token_validator.cc
[add] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_token_validator.h
[rename] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/common/origin_trials/trial_token_validator_unittest.cc
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/public/platform/Platform.h
[delete] https://crrev.com/5004f01e55433edf3f1582d7d0f04c0804f2afad/third_party/WebKit/public/platform/WebOriginTrialTokenStatus.h
[modify] https://crrev.com/db4232d04f791905c88919cf9b845137cf65b125/third_party/WebKit/public/platform/WebTrialTokenValidator.h

Blockedon: 490074
Status: ExternalDependency (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d0e9823bd635cde189575e408604734b32752c1

commit 9d0e9823bd635cde189575e408604734b32752c1
Author: Alex Vallée <avallee@chromium.org>
Date: Tue Nov 07 21:40:42 2017

[OriginTrials] Fixup issues from crrev.com/508197.

Follow up change with responses to:
https://chromium-review.googlesource.com/c/chromium/src/+/591932#message-9f2f11f55b56e983f4987497e668966b0a363d31

- Move validator construction to factory function
- Delete references to policy in Platform.h
- DCHECK that the policy_ is not null.
- Cleanup in default Platform.cpp skeleton implementation.

Bug:  738505 
Change-Id: Ib0ba872fb58215704b4fb7c640f50774a7343299
Reviewed-on: https://chromium-review.googlesource.com/749862
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514605}
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/content/browser/service_worker/link_header_support.cc
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/content/common/origin_trials/trial_policy_impl.cc
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/content/common/origin_trials/trial_policy_impl.h
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/third_party/WebKit/common/origin_trials/trial_token_validator.cc
[modify] https://crrev.com/9d0e9823bd635cde189575e408604734b32752c1/third_party/WebKit/public/platform/Platform.h

Comment 7 by lfg@chromium.org, Apr 24 2018

Cc: aval...@chromium.org
Owner: lfg@chromium.org
Status: Started (was: ExternalDependency)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee

commit 6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Fri Apr 27 00:28:40 2018

[OriginTrials] Migrate origin trials from content to blink.

As part of onion soup, this CL completes the move of origin
trials from content/ to third_party/blink/.

Bug:  738505 

Change-Id: Ieb11641f0872a6c47c09a3ea3ec4315cfbc89e68
Reviewed-on: https://chromium-review.googlesource.com/1012782
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Alex Vallee <avallee@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554217}
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/DEPS
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/common/chrome_content_client.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/common/chrome_content_client_unittest.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/common/origin_trials/OWNERS
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/common/origin_trials/chrome_origin_trial_policy.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/common/origin_trials/chrome_origin_trial_policy.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/chrome/renderer/DEPS
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/app/content_main_runner.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/common/BUILD.gn
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/common/origin_trials/OWNERS
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/common/origin_trials/trial_policy_impl.cc
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/common/origin_trials/trial_policy_impl.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/public/common/BUILD.gn
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/public/common/content_client.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/public/common/content_client.h
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/public/common/origin_trial_policy.cc
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/public/common/origin_trial_policy.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/renderer/BUILD.gn
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/renderer/origin_trials/OWNERS
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/renderer/origin_trials/web_trial_token_validator_impl.cc
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/content/renderer/origin_trials/web_trial_token_validator_impl.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/shell/common/shell_content_client.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/shell/common/shell_content_client.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/shell/common/shell_origin_trial_policy.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/content/shell/common/shell_origin_trial_policy.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/docs/origin_trials_integration.md
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/common/origin_trials/OWNERS
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/common/origin_trials/trial_token.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/common/origin_trials/trial_token_validator.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/common/origin_trials/trial_token_validator_unittest.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/common/origin_trials/OWNERS
[add] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/common/origin_trials/origin_trial_policy.h
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/third_party/blink/public/common/origin_trials/trial_policy.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/common/origin_trials/trial_token.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/common/origin_trials/trial_token_validator.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/public/platform/platform.h
[delete] https://crrev.com/f65e31264d11b06644dd6efae1d2c4e5e9d5200d/third_party/blink/public/platform/web_trial_token_validator.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/renderer/core/origin_trials/origin_trial_context.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/renderer/core/origin_trials/origin_trial_context.h
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/renderer/core/origin_trials/origin_trial_context_test.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/tools/origin_trials/OWNERS
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/webrunner/common/webrunner_content_client.cc
[modify] https://crrev.com/6c24cdae1e1526f42cff6f587700fd9ccfe8c7ee/webrunner/common/webrunner_content_client.h

Comment 9 by lfg@chromium.org, Apr 27 2018

Status: Fixed (was: Started)

Sign in to add a comment