New issue
Advanced search Search tips

Issue 738502 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 888086
Owner: ----
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[WPT Export] Make valid patch failures more obvious

Project Member Reported by jeffcarp@chromium.org, Jun 30 2017

Issue description

Via  crbug.com/736767 

If a provisional PR can't be made due to a patch failure, the exporter shouldn't fail silently. Right now we rely on CL owners to notice if their changes mysteriously don't get exported.
 
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability
Mergedinto: 743149
Status: Duplicate (was: Assigned)
Blocking: -707006
Cc: robertma@chromium.org jeffcarp@chromium.org
Labels: -Type-Bug Type-Feature
Owner: ----
Status: Available (was: Duplicate)
Currently, when an in-flight CL cannot be exported, wpt-export will not do anything except printing some logs.

However, once the CL lands, both wpt-import and wpt-export will turn red: wpt-import cannot reapply this exportable-not-exported change, hence aborting automatic imports; wpt-export errs with non-zero exit code (but other exportable changes can still be exported).

At that point, ecosystem-infra rotation will definitely notice and should be able to find the culprit CL relatively easily to fix it up.

The ideal scenario is that we never need a posteriori fixup, which currently relies on the authors of wpt changes to notice that no exports have been made. We could improve the visibility by proactively sending replies to the CL prompting the authors about patch failures, though we have to be careful about spamming.

Low priority.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: -743149 888086
Status: Duplicate (was: Untriaged)
Duping this into issue 888086, which is much newer, but more concrete about *how* to make the patch failure obvious.

Sign in to add a comment