The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffa4d260f96dc587cdc4cb9fcf5f992f5cda08dc

commit ffa4d260f96dc587cdc4cb9fcf5f992f5cda08dc
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Jul 19 22:16:00 2017

[CrOS Tether] Fix UI issues with Tether connection dialog.

(1) The user would click "connect", then the dialog would close temporarily
before reopening. The issue was as follows: When currentRouteChanged() was
called, we would store whether the dialog should be shown and wait for the
network to be updated with Tether properties (e.g., signal strength) before
showing the dialog in networkPropertiesChanged_(). However, once a connection
attempt started, we would receive an additional update on that network,
resulting in networkPropertiesChanged_() being called again and the dialog being
shown again by mistake.

(2) The user would attempt a connection attempt, which would bring up the
dialog. If the user clicked "not now" (closing the dialog), then clicked
"connect" again (opening the dialog), then "not now" again (closing the
dialog), the dialog would open again. The issue was that if the user opened the
dialog from the network detail page, we create a new location on the back stack,
then when we close the dialog, we would remove that item from the stack by
navigating backward; the handling for this route change would cause the dialog
to be opened again.

(3) The connection dialog called private function onDialogCanceled_() when it
was closed, but this function does not actually exist on the
TetherConnectionDialog Polymer element (I believe that this function was part of
an earlier version of this element that was eventually deleted). Since this
handler function was unused, I removed it.

Bug: 672263,  738501 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I396109a589956e616322ba8bc8b7e7867bf5ea66
Reviewed-on: https://chromium-review.googlesource.com/576116
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488012}
[modify] https://crrev.com/ffa4d260f96dc587cdc4cb9fcf5f992f5cda08dc/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/ffa4d260f96dc587cdc4cb9fcf5f992f5cda08dc/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/ffa4d260f96dc587cdc4cb9fcf5f992f5cda08dc/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html