New issue
Advanced search Search tips

Issue 738500 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

"Open in new tab" from context menu does not show animation

Project Member Reported by mdjones@chromium.org, Jun 30 2017

Issue description

The incorrect layout is showing when a tab is created in the background so the correct animation is not triggered.

Cause of regression: 6320ff4c5350c77ba43e49ed3c745f5a77ebe079
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53de0751f94184164ec43a3fbf0da9d26ce13104

commit 53de0751f94184164ec43a3fbf0da9d26ce13104
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Jun 30 19:48:09 2017

[Home] Fix open tab animation from context menu

Some of the new tab creation animations in Chrome Home depend on the
active layout being the tab switcher. Logic was added to block the
transition to the SimpleAnimationLayout which, unfortunately, breaks
the open in background animation. This change now conditions who
handles the animation based on which layout is showing at the time of
tab creation.

BUG= 738500 

Change-Id: I92422139e1baf2414871119a72a8df40b4e9b565
Reviewed-on: https://chromium-review.googlesource.com/557945
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483791}
[modify] https://crrev.com/53de0751f94184164ec43a3fbf0da9d26ce13104/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

Status: Fixed (was: Started)

Sign in to add a comment