[WPT Import] Put new skip expectations for manual tests in NeverFixTests. |
|||||||
Issue descriptionIn general currently we're keeping skip expectations for manual tests in NeverFixTests. But the importer is putting skip expectations in TestExpectations: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py?l=246 It would be nice if it put new expectations with the rest of the expectations automatically. NB: It might actually be better to keep special separate file wpt tests without automation that we want to skip, since NeverFixTests doesn't quite seem to be the right place to track this...
,
Jul 5 2017
mgiuca@ suggested that if we put manual tests in a separate place, it might be a new file called ManualTests or something similar.
,
Jul 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
,
Aug 16
,
Sep 26
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/317fdb1438147f1fe9c77412b0e89d424166523a commit 317fdb1438147f1fe9c77412b0e89d424166523a Author: kyle Ju <kyleju@chromium.org> Date: Tue Nov 13 18:55:22 2018 Move manual tests from TextExpectation file to WontFix file. Bug: 738489 Change-Id: I0251f741bee780b3cbb88b13a29b67238b8c0cf5 Reviewed-on: https://chromium-review.googlesource.com/c/1269759 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#607680} [modify] https://crrev.com/317fdb1438147f1fe9c77412b0e89d424166523a/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater.py [modify] https://crrev.com/317fdb1438147f1fe9c77412b0e89d424166523a/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater_unittest.py
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6b67cf88ac3e17decb6fd1e41179574bd572900 commit d6b67cf88ac3e17decb6fd1e41179574bd572900 Author: Robert Ma <robertma@chromium.org> Date: Thu Nov 15 22:32:18 2018 Move expectations for manual tests to NeverFixTests New expectations for manual WPT will be appended to NeverFixTests following https://crrev.com/c/1269759. This CL moves the existing expectations from TestExpectations to NeverFixTests. Steps: 1. Move all "external/wpt.*-manual.*[ Skip ]" lines without platform specifiers from TestExpectations to NeverFixTests. 2. Replace Skip with WontFix and strip the bug links. 3. Move all manual WPT lines in NeverFixTests to the end of the file and sort. Bug: 738489 , 626703 Change-Id: Ie5a22053630e01791e1b13dc371038251ed16489 Reviewed-on: https://chromium-review.googlesource.com/c/1334666 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#608553} [modify] https://crrev.com/d6b67cf88ac3e17decb6fd1e41179574bd572900/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/d6b67cf88ac3e17decb6fd1e41179574bd572900/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 15
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by foolip@chromium.org
, Jul 3 2017