New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment
link

Issue 738489: [WPT Import] Put new skip expectations for manual tests in NeverFixTests.

Reported by qyears...@chromium.org, Jun 30 2017 Project Member

Issue description

In general currently we're keeping skip expectations for manual tests in NeverFixTests.

But the importer is putting skip expectations in TestExpectations:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py?l=246

It would be nice if it put new expectations with the rest of the expectations automatically.

NB: It might actually be better to keep special separate file wpt tests without automation that we want to skip, since NeverFixTests doesn't quite seem to be the right place to track this...
 

Comment 1 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 2 by qyears...@chromium.org, Jul 5 2017

Components: -Blink>Infra
Labels: -Type-Task Type-Feature
mgiuca@ suggested that if we put manual tests in a separate place, it might be a new file called ManualTests or something similar.

Comment 3 by sheriffbot@chromium.org, Jul 6 2018

Project Member
Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by robertma@chromium.org, Jul 9 2018

Owner: robertma@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by robertma@chromium.org, Aug 16

Cc: robertma@chromium.org
Labels: -Hotlist-Recharge-Cold Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Assigned)

Comment 6 by foolip@chromium.org, Sep 26

Owner: kyleju@chromium.org
Status: Assigned (was: Available)

Comment 7 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/317fdb1438147f1fe9c77412b0e89d424166523a

commit 317fdb1438147f1fe9c77412b0e89d424166523a
Author: kyle Ju <kyleju@chromium.org>
Date: Tue Nov 13 18:55:22 2018

Move manual tests from TextExpectation file to WontFix file.

Bug:  738489 
Change-Id: I0251f741bee780b3cbb88b13a29b67238b8c0cf5
Reviewed-on: https://chromium-review.googlesource.com/c/1269759
Commit-Queue: Kyle Ju <kyleju@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607680}
[modify] https://crrev.com/317fdb1438147f1fe9c77412b0e89d424166523a/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater.py
[modify] https://crrev.com/317fdb1438147f1fe9c77412b0e89d424166523a/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater_unittest.py

Comment 8 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6b67cf88ac3e17decb6fd1e41179574bd572900

commit d6b67cf88ac3e17decb6fd1e41179574bd572900
Author: Robert Ma <robertma@chromium.org>
Date: Thu Nov 15 22:32:18 2018

Move expectations for manual tests to NeverFixTests

New expectations for manual WPT will be appended to NeverFixTests
following https://crrev.com/c/1269759. This CL moves the existing
expectations from TestExpectations to NeverFixTests.

Steps:
1. Move all "external/wpt.*-manual.*[ Skip ]" lines without platform
   specifiers from TestExpectations to NeverFixTests.
2. Replace Skip with WontFix and strip the bug links.
3. Move all manual WPT lines in NeverFixTests to the end of the file
   and sort.

Bug:  738489 , 626703
Change-Id: Ie5a22053630e01791e1b13dc371038251ed16489
Reviewed-on: https://chromium-review.googlesource.com/c/1334666
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608553}
[modify] https://crrev.com/d6b67cf88ac3e17decb6fd1e41179574bd572900/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/d6b67cf88ac3e17decb6fd1e41179574bd572900/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by robertma@chromium.org, Nov 15

Status: Fixed (was: Assigned)

Sign in to add a comment