v8_inspector::String16 Comprises 150kb of libchrome.so on Android |
||
Issue descriptionWhile investigating Chrome's binary size here: https://bugs.chromium.org/p/chromium/issues/detail?id=733470 I stumbled upon the fact that moving v8_inspector::String16 constructors out-of-line shrinks libchrome.so by 150kb! CL: https://codereview.chromium.org/2962213002/ Will do some performance sanity checks, but given that this is for inspector, and so likely doesn't affect core JS speed, it's likely a worthy trade-off for the size reduction.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/19ffed65ba3adc0f4e3103b14a5b31726d75414d commit 19ffed65ba3adc0f4e3103b14a5b31726d75414d Author: agrieve <agrieve@chromium.org> Date: Thu Jul 13 00:22:02 2017 Add js-perf-test to exercise v8_inspector::String16 BUG= chromium:738469 Review-Url: https://codereview.chromium.org/2962213002 Cr-Commit-Position: refs/heads/master@{#46612} [modify] https://crrev.com/19ffed65ba3adc0f4e3103b14a5b31726d75414d/test/js-perf-test/Inspector/debugger.js [modify] https://crrev.com/19ffed65ba3adc0f4e3103b14a5b31726d75414d/test/js-perf-test/Inspector/run.js [add] https://crrev.com/19ffed65ba3adc0f4e3103b14a5b31726d75414d/test/js-perf-test/Inspector/runtime.js [modify] https://crrev.com/19ffed65ba3adc0f4e3103b14a5b31726d75414d/test/js-perf-test/JSTests.json
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/8089fb9805190c85b637c1da209a35ce511004ab commit 8089fb9805190c85b637c1da209a35ce511004ab Author: agrieve <agrieve@chromium.org> Date: Mon Jul 17 01:38:54 2017 Make String16 consturctors non-inline to save binary size (150kb) BUG= chromium:738469 Review-Url: https://codereview.chromium.org/2975133002 Cr-Commit-Position: refs/heads/master@{#46690} [modify] https://crrev.com/8089fb9805190c85b637c1da209a35ce511004ab/src/inspector/string-16.cc [modify] https://crrev.com/8089fb9805190c85b637c1da209a35ce511004ab/src/inspector/string-16.h
,
Jul 17 2017
150kb win shown here: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&rev=487027 roll conveniently contained only one commit :)
,
Jul 17 2017
It looks like it makes inspector perf test a a little faster (@46690), maybe because code better fits memory page. https://chromeperf.appspot.com/report?sid=d4241a1d0f8fd3663cf44ad6ef4eb62ba40d1a50e3cb13d31dd1a2dc7e33f5ac Thanks a lot!
,
Jul 17 2017
Cool! Thanks for the link! |
||
►
Sign in to add a comment |
||
Comment 1 by agrieve@chromium.org
, Jun 30 2017