Makes sense. Device reporting currently gather version via version_loader::GetVersion(VERSION_FULL) so if we include this info in there it will get uploaded automatically.

Ivan, can you tackle adding the TPM information to our version reporting for M61? mnissler@ can point you at an API to get the TPM version info which you can include in version_loader::GetVersion().

Drew, sure.

Mattias, any pointers or should I just take a look at the CLs at the linked crbug?

Ivan: Version information is currently exposed via this command:

tpm-manager get_version_info

Note that you'll not be able to run this directly from Chrome though, so we'll have to find a way to get the information to Chrome. UMA is implemented in cryptohomed, so maybe it makes sense to add a DBus call to surface this? Note that I also intend to add the output of the command to chrome://system and feedback reports, but that's probably not helping you?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/0143e1b0a141eb02192f018b04e4358f39efb5fb

commit 0143e1b0a141eb02192f018b04e4358f39efb5fb
Author: Ivan Sandrk <isandrk@google.com>
Date: Fri Aug 04 02:23:21 2017

system_api: Add kCryptohomeTpmGetVersion.

BUG= chromium:738462 
TEST=none

Change-Id: I5628c2a1c850ffcd5194ffbc691aed07d738dc6a
Reviewed-on: https://chromium-review.googlesource.com/600410
Commit-Ready: Ivan Šandrk <isandrk@chromium.org>
Tested-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/0143e1b0a141eb02192f018b04e4358f39efb5fb/dbus/cryptohome/dbus-constants.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f7cce12f464964cf11dc6ad93329ac01956a9b5

commit 6f7cce12f464964cf11dc6ad93329ac01956a9b5
Author: Ivan Sandrk <isandrk@google.com>
Date: Thu Aug 24 12:56:28 2017

Add TPM version information to device reporting

Google corp asks whether firmware version information for chips being part of Chrome OS devices can be made available via device status reporting.

For firmware that is uploaded to the chip on each boot, this isn't necessary since you can just check the rootfs corresponding to the OS version to figure out what firmware gets used.

Some chips, such as TPMs/H1s, webcams(?) etc. have persistent memory though, so reporting their firmware version would make sense.

The corresponding CrOS code is up for review at https://chromium-review.googlesource.com/c/600214

Bug:  chromium:738462 
Change-Id: I1cee715cfe11012720b0e4982d40e7e0f6ead958
Reviewed-on: https://chromium-review.googlesource.com/606650
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497017}
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chromeos/system/version_loader.cc
[modify] https://crrev.com/6f7cce12f464964cf11dc6ad93329ac01956a9b5/chromeos/system/version_loader.h

Note that this is required by google.com admins.

There's also a ChromiumOS part to this on the following link (messed up BUG number in the description of it so it didn't show in this bug):
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/600214

This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M61.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/bd62f16b59c51bad2a07d6538a808f8aa816a061

commit bd62f16b59c51bad2a07d6538a808f8aa816a061
Author: Ivan Sandrk <isandrk@google.com>
Date: Tue Aug 29 17:52:03 2017

system_api: Add kCryptohomeTpmGetVersion.

BUG= chromium:738462 
TEST=none
TBR=isandrk@google.com
TBR=derat@google.com

Change-Id: I5628c2a1c850ffcd5194ffbc691aed07d738dc6a
Reviewed-on: https://chromium-review.googlesource.com/600410
Commit-Ready: Ivan Šandrk <isandrk@chromium.org>
Tested-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit 0143e1b0a141eb02192f018b04e4358f39efb5fb)
Reviewed-on: https://chromium-review.googlesource.com/641790
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>

[modify] https://crrev.com/bd62f16b59c51bad2a07d6538a808f8aa816a061/dbus/cryptohome/dbus-constants.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1bb67e2230897509c2e59cb78a907df8d2963e4

commit d1bb67e2230897509c2e59cb78a907df8d2963e4
Author: Ivan Sandrk <isandrk@google.com>
Date: Wed Aug 30 09:40:08 2017

[Merge to M61] Add TPM version information to device reporting

Google corp asks whether firmware version information for chips being part of Chrome OS devices can be made available via device status reporting.

For firmware that is uploaded to the chip on each boot, this isn't necessary since you can just check the rootfs corresponding to the OS version to figure out what firmware gets used.

Some chips, such as TPMs/H1s, webcams(?) etc. have persistent memory though, so reporting their firmware version would make sense.

The corresponding CrOS code is up for review at https://chromium-review.googlesource.com/c/600214

TBR=isandrk@google.com

(cherry picked from commit 6f7cce12f464964cf11dc6ad93329ac01956a9b5)

Bug:  chromium:738462 
Change-Id: I1cee715cfe11012720b0e4982d40e7e0f6ead958
Reviewed-on: https://chromium-review.googlesource.com/606650
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497017}
Reviewed-on: https://chromium-review.googlesource.com/642967
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#994}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chromeos/system/version_loader.cc
[modify] https://crrev.com/d1bb67e2230897509c2e59cb78a907df8d2963e4/chromeos/system/version_loader.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53cac4033cee7611c41bbde3fd9016f9c8bbbab4

commit 53cac4033cee7611c41bbde3fd9016f9c8bbbab4
Author: Maajid <maajid@chromium.org>
Date: Wed Aug 30 19:48:29 2017

Revert "[Merge to M61] Add TPM version information to device reporting"

This reverts commit d1bb67e2230897509c2e59cb78a907df8d2963e4.

Reason for revert: Breaks the build: no member named 'kCryptohomeTpmGetVersion' in namespace 'cryptohome'

Original change's description:
> [Merge to M61] Add TPM version information to device reporting
> 
> Google corp asks whether firmware version information for chips being part of Chrome OS devices can be made available via device status reporting.
> 
> For firmware that is uploaded to the chip on each boot, this isn't necessary since you can just check the rootfs corresponding to the OS version to figure out what firmware gets used.
> 
> Some chips, such as TPMs/H1s, webcams(?) etc. have persistent memory though, so reporting their firmware version would make sense.
> 
> The corresponding CrOS code is up for review at https://chromium-review.googlesource.com/c/600214
> 
> TBR=isandrk@google.com
> 
> (cherry picked from commit 6f7cce12f464964cf11dc6ad93329ac01956a9b5)
> 
> Bug:  chromium:738462 
> Change-Id: I1cee715cfe11012720b0e4982d40e7e0f6ead958
> Reviewed-on: https://chromium-review.googlesource.com/606650
> Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#497017}
> Reviewed-on: https://chromium-review.googlesource.com/642967
> Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3163@{#994}
> Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

TBR=hashimoto@chromium.org,achuith@chromium.org,pastarmovj@chromium.org,isandrk@chromium.org

Change-Id: Idf5c38793125d6a6686bafc4adb610c2b2005ae4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:738462 
Reviewed-on: https://chromium-review.googlesource.com/644186
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1002}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chromeos/system/version_loader.cc
[modify] https://crrev.com/53cac4033cee7611c41bbde3fd9016f9c8bbbab4/chromeos/system/version_loader.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a165caa77d602cd00090a107f3a0675a08efee

commit 77a165caa77d602cd00090a107f3a0675a08efee
Author: Ivan Sandrk <isandrk@google.com>
Date: Thu Aug 31 12:49:24 2017

Reland "[Merge to M61] Add TPM version information to device reporting"

This is a reland of d1bb67e2230897509c2e59cb78a907df8d2963e4
Original change's description:
> [Merge to M61] Add TPM version information to device reporting
> 
> Google corp asks whether firmware version information for chips being part of Chrome OS devices can be made available via device status reporting.
> 
> For firmware that is uploaded to the chip on each boot, this isn't necessary since you can just check the rootfs corresponding to the OS version to figure out what firmware gets used.
> 
> Some chips, such as TPMs/H1s, webcams(?) etc. have persistent memory though, so reporting their firmware version would make sense.
> 
> The corresponding CrOS code is up for review at https://chromium-review.googlesource.com/c/600214
> 
> TBR=isandrk@google.com
> 
> (cherry picked from commit 6f7cce12f464964cf11dc6ad93329ac01956a9b5)
> 
> Bug:  chromium:738462 
> Change-Id: I1cee715cfe11012720b0e4982d40e7e0f6ead958
> Reviewed-on: https://chromium-review.googlesource.com/606650
> Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#497017}
> Reviewed-on: https://chromium-review.googlesource.com/642967
> Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3163@{#994}
> Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

Bug:  chromium:738462 
Change-Id: I4950849fb9013785dbc9803ea95dfbeb39742d29
Reviewed-on: https://chromium-review.googlesource.com/645866
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1031}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chromeos/system/version_loader.cc
[modify] https://crrev.com/77a165caa77d602cd00090a107f3a0675a08efee/chromeos/system/version_loader.h

As verified in M64.0.3282.190 10176.76.0 stable glimmer, the firmware version is reported in device status as observed on CPanel.