devil.android.tools.system_app_test fails on Android M+ |
||
Issue description
To reproduce:
1) Plug a device with Android M or higher.
2) $ ./devil/bin/run_py_devicetests devil.android.tools.system_app_test.SystemAppTest.testDoubleEnableModification
[1/1] devil.android.tools.system_app_test.SystemAppTest.testDoubleEnableModification failed unexpectedly:
Traceback (most recent call last):
File "/usr/local/google/code/clankium/src/third_party/catapult/devil/devil/android/tools/system_app_test.py", line 47, in testDoubleEnableModification
mock_device.EnableRoot.assert_called_once()
File "/usr/local/google/home/perezju/.local/lib/python2.7/site-packages/mock/mock.py", line 915, in assert_called_once
raise AssertionError(msg)
AssertionError: Expected 'EnableRoot' to have been called once. Called 2 times.
0 tests passed, 0 skipped, 1 failure.
The second call to EnableRoot happens at:
https://cs.chromium.org/chromium/src/third_party/catapult/devil/devil/android/tools/system_app.py?rcl=6d102fd0828209a8f9c0fb39eab1e846f3114e84&l=101
This causes presubmit to fail when such a device is plugged to the workstation.
,
Jun 30 2017
Patch with fix: https://codereview.chromium.org/2967603003
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69b83ca4ebb1da72a1ed1923a334c405a2347846 commit 69b83ca4ebb1da72a1ed1923a334c405a2347846 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu Jul 06 11:19:23 2017 Roll src/third_party/catapult/ 52495f00b..eb1f97c62 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/52495f00b0cc..eb1f97c620f8 $ git log 52495f00b..eb1f97c62 --date=short --no-merges --format='%ad %ae %s' 2017-07-06 perezju [devil] Fix bug in devil.android.tools.system_app_test Created with: roll-dep src/third_party/catapult BUG= 738450 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Icc499e2ab2d44053984f051927055cec7598d560 Reviewed-on: https://chromium-review.googlesource.com/561216 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#484544} [modify] https://crrev.com/69b83ca4ebb1da72a1ed1923a334c405a2347846/DEPS
,
Jul 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by perezju@chromium.org
, Jun 30 2017Actually, this always fails, because it's not a device test: $ ./devil/bin/run_py_tests devil.android.tools.system_app_test.SystemAppTest.testDoubleEnableModification [1/1] devil.android.tools.system_app_test.SystemAppTest.testDoubleEnableModification failed unexpectedly: Traceback (most recent call last): File "/usr/local/google/code/clankium/src/third_party/catapult/devil/devil/android/tools/system_app_test.py", line 47, in testDoubleEnableModification mock_device.EnableRoot.assert_called_once() File "/usr/local/google/home/perezju/.local/lib/python2.7/site-packages/mock/mock.py", line 915, in assert_called_once raise AssertionError(msg) AssertionError: Expected 'EnableRoot' to have been called once. Called 2 times. 0 tests passed, 0 skipped, 1 failure. Not sure how this got landed?