New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738435 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Sign in to chrome window is displayed, when mail.google.com url is loaded for the first time in iOS11

Project Member Reported by rakurati@chromium.org, Jun 30 2017

Issue description

App Version: 60.0.3112.52
iOS Version: 11.0.0
Device: iPhone, iPad
URL: mail.google.com

Steps to reproduce:
1. Fresh install chrome 
2. Launch chrome and sign in to chrome
3. Type mail.google.com in omnibox and tap on go button
4. Repeat step 3 in new tab few more times.

Observed results:
At step 3: Sign in to chrome window is displayed.
At step 4: After multiple times (in the attached video step 3 is repeated thrice) of loading mail.google.com the gmail inbox page is displayed.

Expected results:
The gmail should login with the chrome sign in account.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes on M59 in iOS 11
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M60 in iOS11

Link to video/image:

iOS11 behavior:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8VG1zTWdGRVZTcTQ/view?usp=sharing
iOS10 behavior:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8TzBiMVFBRUZVbFk/view?usp=sharing

 
Cc: peterlaurens@chromium.org
Labels: ReleaseBlock-Stable M-61
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Cc: eugene...@chromium.org
Components: -UI>Browser Services>SignIn
Owner: msarda@chromium.org
Looks like Mirror/SignIn issue.
Cc: msarda@chromium.org
Owner: jlebel@chromium.org
This is probably a problem with the way the reconcilor works on iOS 11. I'm assigning this to Jerome as he is working on sign-in for iOS now.

Jerome: This bug is a good moment to get familiarized with the AccountReconcilor and how that works for Chrome iOS. Let's chat about this before you start on it.

It looks like this is a stable blocker for M61, so this is higher priority than starting on Dice.

Comment 4 by cma...@chromium.org, Jul 18 2017

 jlebel@ do you have update on this?

Comment 5 Deleted

Comment 6 by jlebel@chromium.org, Jul 19 2017

I'm working on it.

Comment 7 by jlebel@chromium.org, Jul 19 2017

This is probably related to  crbug.com/739390  and rdar://33184203.

WKWebView in iOS 11 should always be part of view hierarchy.
We landed a workaround for  crbug.com/739390 
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8

commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Jul 20 12:46:32 2017

iOS 11 WKWebView load is broken

In iOS 11, WKWebView has issues (time outs) when loading request if the
view is not part of the hierarchy. The WKWebView is now added to the
hierarchy but off screen.

Bug:  738435 ,  739390 
Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
Reviewed-on: https://chromium-review.googlesource.com/577807
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488213}
[modify] https://crrev.com/28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8/components/signin/ios/browser/account_consistency_service.mm

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40de2a142623043bb744f808ca5652340b2c00b8

commit 40de2a142623043bb744f808ca5652340b2c00b8
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Mon Jul 31 11:27:05 2017

Revert "iOS 11 WKWebView load is broken"

This reverts commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> iOS 11 WKWebView load is broken
> 
> In iOS 11, WKWebView has issues (time outs) when loading request if the
> view is not part of the hierarchy. The WKWebView is now added to the
> hierarchy but off screen.
> 
> Bug:  738435 ,  739390 
> Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
> Reviewed-on: https://chromium-review.googlesource.com/577807
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488213}

TBR=rohitrao@chromium.org,msarda@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,jlebel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  738435 ,  739390 
Change-Id: Ic57820325fef5ac86b93b4f02f449b97f0b458e0
Reviewed-on: https://chromium-review.googlesource.com/591671
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490743}
[modify] https://crrev.com/40de2a142623043bb744f808ca5652340b2c00b8/components/signin/ios/browser/account_consistency_service.mm

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/731e8f89b4d1db6fecc2384c3825e95c4d8f206d

commit 731e8f89b4d1db6fecc2384c3825e95c4d8f206d
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Aug 01 17:43:49 2017

Revert "iOS 11 WKWebView load is broken"

This reverts commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> iOS 11 WKWebView load is broken
>
> In iOS 11, WKWebView has issues (time outs) when loading request if the
> view is not part of the hierarchy. The WKWebView is now added to the
> hierarchy but off screen.
>
> Bug:  738435 ,  739390 
> Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
> Reviewed-on: https://chromium-review.googlesource.com/577807
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488213}

TBR=eugenebut@chromium.org, jlebel@chromium.org, justincohen@chromium.org, msarda@chromium.org, rohitrao@chromium.org


(cherry picked from commit 40de2a142623043bb744f808ca5652340b2c00b8)

Bug:  750739 ,  738435 ,  739390 
Change-Id: Ic57820325fef5ac86b93b4f02f449b97f0b458e0
Reviewed-on: https://chromium-review.googlesource.com/591671
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490743}
Reviewed-on: https://chromium-review.googlesource.com/596308
Cr-Commit-Position: refs/branch-heads/3163@{#211}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/731e8f89b4d1db6fecc2384c3825e95c4d8f206d/components/signin/ios/browser/account_consistency_service.mm

Status: Verified (was: Fixed)
Verified in 61.0.3163.67 beta, iPhone 7 iOS11, 
The user is logged in to gmail with the chrome sign in account.
Looks good.
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 10 2017

Labels: -Merge-TBD

Sign in to add a comment