New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738416 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : 'Saved password details' overlay closes after pressing 'Enter' Key

Reported by ngu...@etouch.net, Jun 30 2017

Issue description

Chrome Version :61.0.3145.0 02c80fa9c3cc98fe3ae5e94e881f4a05d9cd174c-refs/heads/master@{#483234} 
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1.Launch Chrome and navigate to 'https://www.facebook.com/?sk=welcome' and save password
2.Now navigate to 'chrome://settings/passwords' ,select 'Edit Password' option  and hit 'Enter' key and Observe.

Actual : 'Saved password details ' overlay closes after pressing 'Enter' Keyword
Expected : 'Saved password details' overlay should not close after Pressing 'Enter' Keyword

This is regression issue, broken in ‘M - 59’ and will soon update other info :
Manual bisect:
Good Build :59.0.3056.0
Bad Build :59.0.3057.0
 
 
Actual_Result.mp4
2.0 MB View Download
Expected_Result.mp4
1.1 MB View Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 59.0.3056.0,  Revision Range - 460603
Bad build  : 59.0.3057.0,  Revision Range - 460966

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/75d1fbdea6f82d547d7eec45d659ab5491f24e7a..e6a2ed91fb2df3c4f234ca8824cfb570f902897c

The Suspecting CL:
-------------------
Review-Url: https://codereview.chromium.org/2783063002

dschuyler@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 3 by dpa...@chromium.org, Jun 30 2017

Labels: Proj-MaterialDesign-WebUI
Status: WontFix (was: Assigned)
Thanks but it looks like the enter key should close the dialog, because of the Done default button. Enter performs the default action, which is "Done". Is there some functionality that is failing, please undo my WontFix and tell me more if so.

The CL also mentioned that it intentionally adds the ability to use the Enter key to close the dialog so I'm marking this WAI, wontFix. If there's disagreement to that please let me or bettes@ know.

Sign in to add a comment