Regression : 'Saved password details' overlay closes after pressing 'Enter' Key
Reported by
ngu...@etouch.net,
Jun 30 2017
|
|||
Issue descriptionChrome Version :61.0.3145.0 02c80fa9c3cc98fe3ae5e94e881f4a05d9cd174c-refs/heads/master@{#483234} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) What steps will reproduce the problem? 1.Launch Chrome and navigate to 'https://www.facebook.com/?sk=welcome' and save password 2.Now navigate to 'chrome://settings/passwords' ,select 'Edit Password' option and hit 'Enter' key and Observe. Actual : 'Saved password details ' overlay closes after pressing 'Enter' Keyword Expected : 'Saved password details' overlay should not close after Pressing 'Enter' Keyword This is regression issue, broken in ‘M - 59’ and will soon update other info : Manual bisect: Good Build :59.0.3056.0 Bad Build :59.0.3057.0
,
Jun 30 2017
FYI, if you want the enter key to not automatically trigger the action-button you should add an ignore-enter-key attribute on the dialog, see 1 and 2. [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js?q=cr_dialog.js&sq=package:chromium&dr&l=36 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/reset_page/powerwash_dialog.html?type=cs&q=ignore-enter-key&sq=package:chromium&l=14
,
Jun 30 2017
,
Jul 1 2017
Thanks but it looks like the enter key should close the dialog, because of the Done default button. Enter performs the default action, which is "Done". Is there some functionality that is failing, please undo my WontFix and tell me more if so. The CL also mentioned that it intentionally adds the ability to use the Enter key to close the dialog so I'm marking this WAI, wontFix. If there's disagreement to that please let me or bettes@ know. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kkaluri@chromium.org
, Jun 30 2017Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)