New issue
Advanced search Search tips

Issue 738379 link

Starred by 1 user
Status: Fixed
Owner:
tommi@chromium.org
Closed: Jul 2017
Cc:
guidou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Allow audio elements playing a mediaStream to ignore the video state

Project Member Reported by guidou@chromium.org, Jun 30 2017 
Currently, when WebMediaPlayerMS gets a MediaStream that has both audio and video tracks, it waits for the first video frame in order to have all the metadata for the stream in order to start playing.

This is according to spec when the stream is assigned to a video element.
However, when the stream is assigned to an audio element it should not wait for video since the only required metadata is the one for audio.

Comment 1 by guidou@chromium.org, Jun 30 2017

Components: Blink>Media>Audio Blink>WebRTC
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by tommi@chromium.org, Jul 19 2017

Cc: guidou@chromium.org
Owner: tommi@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d166660f0442053339311e0763b08f1805ba88f

commit 0d166660f0442053339311e0763b08f1805ba88f
Author: Tommi <tommi@chromium.org>
Date: Fri Jul 21 13:40:22 2017

Allow <audio> elements to start rendering audio without waiting for video.
Video frames might never arrive. Waiting is appropriate for a <video> tag,
but not for <audio>.

TBR=hubbe@chromium.org

Bug:  738379 
Change-Id: I3f6c886c32b06f6def8024ca585179ca81a6ef29
Reviewed-on: https://chromium-review.googlesource.com/575998
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488645}
[modify] https://crrev.com/0d166660f0442053339311e0763b08f1805ba88f/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/0d166660f0442053339311e0763b08f1805ba88f/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/0d166660f0442053339311e0763b08f1805ba88f/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/0d166660f0442053339311e0763b08f1805ba88f/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/0d166660f0442053339311e0763b08f1805ba88f/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/0d166660f0442053339311e0763b08f1805ba88f/third_party/WebKit/public/platform/WebMediaPlayerClient.h

Comment 5 by tommi@chromium.org, Jul 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment