New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Hindi name of text Bookmark doesn't seen properly.

Reported by dchau...@etouch.net, Jun 30 2017

Issue description

Chrome Version: 61.0.3145.0 (Official Build) 0a9d03ce07a9bec7a397bbb08c2bec0fe0e91d66-refs/heads/master@{#483574} 32/64-bit.
OS: Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome and change browser language to Hindi.
2. Navigate to chrome://bookmarks and observe text बुकमार्क at header.

Text बुकमार्क seems to be chopped from bottom end.
Text बुकमार्क should seen properly.

This is a regression issue, broken in M-60 series, below is manual regression range.

Good build: 60.0.3086.0
Bad build: 60.0.3087.0

Note: This issue is not seen on Mac and Linux OS.

Kindly review the attached screen-shot for reference.
 
Bookmark_Screenshot.png
5.1 KB View Download
Actual behavior.mp4
280 KB View Download

Comment 1 by dchau...@etouch.net, Jun 30 2017

Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/9c5604209f8fc4438c7e141696089c3d2985928b..71f3bd1682b75efac412a7431adae78afb8a903b?pretty=fuller&n=10000

Suspecting: r468296

@tsergeant: Kindly help to reassign, if your changes are not related to this issue.

Comment 2 by jasteen@google.com, Aug 11 2017

Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Assigned)
This is not a localization bug. Can't confirm if it's still relevant to the current English UI.
Labels: -Needs-TestConfirmation
Still we are able to reproduce the issue on stable #60.0.3112.90 & latest Canary-62.0.3184.0 .
Please find the attached screenshot for reference.
@tsergeant, Could you please take a look and update the thread accordingly.

Thanks..!!
738370.PNG
139 KB View Download
Status: Assigned (was: Unconfirmed)
Cc: tsergeant@chromium.org
Owner: calamity@chromium.org
Passing over to Chris to take a look. Seems like the line-height of the title just needs adjusting.

Comment 6 by jasteen@google.com, Aug 31 2017

Good day,

We would just like to follow up on this. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ac1a9a33103cda63ddab3d9b74a88a677d4295d

commit 8ac1a9a33103cda63ddab3d9b74a88a677d4295d
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Aug 31 02:10:18 2017

[cr-toolbar] Fix title line-height.

This fixes an issue where titles were being clipped in MD Bookmarks and Settings.

Bug:  738370 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2931eef51c4f63f227ab7039896eac7c958b51de
Reviewed-on: https://chromium-review.googlesource.com/634088
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498718}
[modify] https://crrev.com/8ac1a9a33103cda63ddab3d9b74a88a677d4295d/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/8ac1a9a33103cda63ddab3d9b74a88a677d4295d/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/8ac1a9a33103cda63ddab3d9b74a88a677d4295d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html

Status: Fixed (was: Assigned)
Labels: TE-Verified-62.0.3202.0 TE-Verified-M62
Update : 
Retested above issue on Windows(7,8,10) machines using latest Canary chrome#62.0.3202.0 Issue is fixed now and it is working as intended.

Kindly review an attached screen cast.

Thank you!
LatestCanary_behavior.mp4
230 KB View Download

Sign in to add a comment