New issue
Advanced search Search tips

Issue 738366 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Import from Edge does not work

Reported by mwro...@opera.com, Jun 30 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 OPR/45.0.2552.898

Steps to reproduce the problem:
1. open Edge browser
2. Create few bookmarks/favourites favorites bar in Edge
3. close Edge
4. open chrome browser and: settings -> Import bookmarks and settings -> Microsoft Edge

What is the expected behavior?
favorites imported and visible in chrome bookmarks bar

What went wrong?
favorites not imported and not visible in chrome bookmarks bar

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: n/a
OS Version: 10.0
Flash Version: 

On e.g. Win 10 1607 (OS Build: 14393.1358) Edge saves favorites to ESE db. when FavoritesESEEnabled registry key is not defined. However import utils:

https://chromium.googlesource.com/chromium/src.git/+/master/chrome/common/importer/edge_importer_utils_win.cc#76

recognize this situation as 'Edge saves favorites in legacy mode: to Favorites directory) which is wrong.

When FavoritesESEEnabled registry key is not available, favorites should be importer from ESE db, not from Favorites directory.
 

Comment 1 by ajha@chromium.org, Jul 4 2017

Cc: ajha@chromium.org
Components: UI>Browser>Bookmarks
Labels: Needs-Feedback
Somehow, I was unable to reproduce the issue on the latest stable(59.0.3071.115) on Windows-10. Bookmarks from Edge were imported to Chrome without any issues. Attached is the screen-cast of the same.

mwrobel@: Could you please confirm if the issue is still seen on the latest stable(59.0.3071.115)?


738366.mp4
519 KB View Download

Comment 2 by mwro...@opera.com, Jul 4 2017

Which Win 10 version are you using?
(in old version where Edge saves favorites 'in legacy' mode: to Favorites directory there is no problem. This problem occurs only in newer version of win 10 e.g. Win 10 1607 (OS Build: 14393.1358))
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 4 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "ajha@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by mwro...@opera.com, Jul 5 2017

@ajha@chromium.org

I confirm this bug on win10 version 1703 (fresh installation)
Cc: pnangunoori@chromium.org
Status: Untriaged (was: Unconfirmed)
Tested on Chrome Stable #59.0.3071.115, Canary #61.0.3161.0 on Windows 10 Enterprise 64-bit (10.0, Build 10586) and able to reproduce the issue. Attached screencast for reference.

This is a non-regression issue and able to reproduce from M-49 #49.0.2581.0. Marking it as untriaged so that issue gets addressed.

Note: Earlier versions of Chrome did not support importing of favorites from Edge.

Thanks.

738366.webm
4.2 MB View Download

Comment 6 by mwro...@opera.com, Jul 27 2017

@ajha@chromium.org

I think that https://chromium.googlesource.com/chromium/src.git/+/master/chrome/common/importer/edge_importer_utils_win.cc#76

additionally needs to check which win 10 version is it:

e.g. during my tests I found out that:

- win 10, version 10240 (from 2015) works fine with current implementation (FavoritesESEEnabled registry not available -> legacy mode)

- win 10, version 1607 (from 2017) needs correction ((FavoritesESEEnabled registry not available -> read fro ESE db)

You need to find out which win 10 version is one which changes behaviour.

Hey, this issue still exists. Behavior is exactly the same as in the video posted above.
Google Chrome 64.0.3282.186
Windows 10 1709 build 17074.1002
Microsoft Edge 42.17074.1002.0
Owner: davidbienvenu@chromium.org
Status: Assigned (was: Untriaged)
I'll look at this.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23e1d3e449f965c5080d9f96eaf59cd7553911e6

commit 23e1d3e449f965c5080d9f96eaf59cd7553911e6
Author: David Bienvenu <davidbienvenu@chromium.org>
Date: Fri Aug 31 16:19:50 2018

fix bookmarks import from Edge on Win 10

Bug:  738366 
Change-Id: Id43c70fbaa946a30c3265b8a4cf20bbef81361ad
Reviewed-on: https://chromium-review.googlesource.com/1197908
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588050}
[modify] https://crrev.com/23e1d3e449f965c5080d9f96eaf59cd7553911e6/chrome/browser/importer/edge_importer_browsertest_win.cc
[modify] https://crrev.com/23e1d3e449f965c5080d9f96eaf59cd7553911e6/chrome/common/importer/edge_importer_utils_win.cc

Status: Fixed (was: Assigned)

Sign in to add a comment