New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738363 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Create EarlGrey matcher for PrivacyButton()

Project Member Reported by baxley@chromium.org, Jun 30 2017

Issue description

IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY is used in multiple tests. It would be better to have a matcher in chrome_matchers.h
 
Owner: liaoyuke@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/055a634eebece6cce56a45263e31c7cd3bb71711

commit 055a634eebece6cce56a45263e31c7cd3bb71711
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Jul 10 21:10:40 2017

Create EarlGrey matcher for settings menu privacy button

IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY is used in multiple tests,
so this CL creates a matcher in chrome_matchers.h.

Bug:  738363 
Change-Id: If0ab68ce67397aa0a0819055fa147aef8f046984
Reviewed-on: https://chromium-review.googlesource.com/563473
Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485389}
[modify] https://crrev.com/055a634eebece6cce56a45263e31c7cd3bb71711/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/055a634eebece6cce56a45263e31c7cd3bb71711/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
[modify] https://crrev.com/055a634eebece6cce56a45263e31c7cd3bb71711/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/055a634eebece6cce56a45263e31c7cd3bb71711/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/055a634eebece6cce56a45263e31c7cd3bb71711/ios/chrome/test/earl_grey/chrome_matchers.mm

Status: Fixed (was: Assigned)

Sign in to add a comment