New issue
Advanced search Search tips

Issue 738359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Ship all unpacked images in assets catalog

Project Member Reported by sdefresne@chromium.org, Jun 30 2017

Issue description

When images are compiled in an asset catalog (Assets.car), then app thinning kicks in and only a subset of the resources is shipped to end user devices (https://developer.apple.com/library/content/documentation/IDEs/Conceptual/AppDistributionGuide/AppThinning/AppThinning.html).

We should ship all images that are not in datapack (i.e. accessed using -imageNamed: vs accessing via IDR_...) in assets catalog to benefit from this optimisation to the app size.

Here's a list of all such assets:

./activity_services_reading_list.png
./activity_services_reading_list@2x.png
./activity_services_reading_list@3x.png
./app_icon_placeholder.png
./app_icon_placeholder@2x.png
./app_icon_placeholder@3x.png
./autofill_card_american_express.png
./autofill_card_american_express@2x.png
./autofill_card_american_express@2x~ipad.png
./autofill_card_american_express@3x.png
./autofill_card_american_express~ipad.png
./autofill_card_diners.png
./autofill_card_diners@2x.png
./autofill_card_diners@2x~ipad.png
./autofill_card_diners@3x.png
./autofill_card_diners~ipad.png
./autofill_card_discover.png
./autofill_card_discover@2x.png
./autofill_card_discover@2x~ipad.png
./autofill_card_discover@3x.png
./autofill_card_discover~ipad.png
./autofill_card_generic.png
./autofill_card_generic@2x.png
./autofill_card_generic@2x~ipad.png
./autofill_card_generic@3x.png
./autofill_card_generic~ipad.png
./autofill_card_jcb.png
./autofill_card_jcb@2x.png
./autofill_card_jcb@2x~ipad.png
./autofill_card_jcb@3x.png
./autofill_card_jcb~ipad.png
./autofill_card_mastercard.png
./autofill_card_mastercard@2x.png
./autofill_card_mastercard@2x~ipad.png
./autofill_card_mastercard@3x.png
./autofill_card_mastercard~ipad.png
./autofill_card_unionpay.png
./autofill_card_unionpay@2x.png
./autofill_card_unionpay@2x~ipad.png
./autofill_card_unionpay@3x.png
./autofill_card_unionpay~ipad.png
./autofill_card_visa.png
./autofill_card_visa@2x.png
./autofill_card_visa@2x~ipad.png
./autofill_card_visa@3x.png
./autofill_card_visa~ipad.png
./autofill_close.png
./autofill_close@2x.png
./autofill_close@3x.png
./autofill_close_pressed.png
./autofill_close_pressed@2x.png
./autofill_close_pressed@3x.png
./autofill_keyboard_background.png
./autofill_keyboard_background@2x.png
./autofill_keyboard_background@3x.png
./autofill_keyboard_background_left.png
./autofill_keyboard_background_left@2x.png
./autofill_keyboard_background_right.png
./autofill_keyboard_background_right@2x.png
./autofill_left_sep.png
./autofill_left_sep@2x.png
./autofill_left_sep@3x.png
./autofill_left_sep_RTL.png
./autofill_left_sep_RTL@2x.png
./autofill_left_sep_RTL@3x.png
./autofill_middle_sep.png
./autofill_middle_sep@2x.png
./autofill_middle_sep@3x.png
./autofill_next.png
./autofill_next@2x.png
./autofill_next@3x.png
./autofill_next_inactive.png
./autofill_next_inactive@2x.png
./autofill_next_inactive@3x.png
./autofill_next_pressed.png
./autofill_next_pressed@2x.png
./autofill_next_pressed@3x.png
./autofill_prev.png
./autofill_prev@2x.png
./autofill_prev@3x.png
./autofill_prev_inactive.png
./autofill_prev_inactive@2x.png
./autofill_prev_inactive@3x.png
./autofill_prev_pressed.png
./autofill_prev_pressed@2x.png
./autofill_prev_pressed@3x.png
./autofill_right_sep.png
./autofill_right_sep@2x.png
./autofill_right_sep@3x.png
./autofill_right_sep_RTL.png
./autofill_right_sep_RTL@2x.png
./autofill_right_sep_RTL@3x.png
./bookmark_bar_innershadow.png
./bookmark_bar_innershadow@2x.png
./bookmark_bar_innershadow@3x.png
./bookmark_bar_shadow.png
./bookmark_bar_shadow@2x.png
./bookmark_bar_shadow@3x.png
./bookmark_black_delete.png
./bookmark_black_delete@2x.png
./bookmark_black_delete@3x.png
./bookmark_black_edit.png
./bookmark_black_edit@2x.png
./bookmark_black_edit@3x.png
./bookmark_black_move.png
./bookmark_black_move@2x.png
./bookmark_black_move@3x.png
./bookmark_black_select.png
./bookmark_black_select@2x.png
./bookmark_black_select@3x.png
./bookmark_blue_check.png
./bookmark_blue_check@2x.png
./bookmark_blue_check@3x.png
./bookmark_blue_folder.png
./bookmark_blue_folder@2x.png
./bookmark_blue_folder@3x.png
./bookmark_gray_back.png
./bookmark_gray_back@2x.png
./bookmark_gray_back@3x.png
./bookmark_gray_check.png
./bookmark_gray_check@2x.png
./bookmark_gray_check@3x.png
./bookmark_gray_close.png
./bookmark_gray_close@2x.png
./bookmark_gray_close@3x.png
./bookmark_gray_edit.png
./bookmark_gray_edit@2x.png
./bookmark_gray_edit@3x.png
./bookmark_gray_folder.png
./bookmark_gray_folder@2x.png
./bookmark_gray_folder@3x.png
./bookmark_gray_menu.png
./bookmark_gray_menu@2x.png
./bookmark_gray_menu@3x.png
./bookmark_gray_new_folder.png
./bookmark_gray_new_folder@2x.png
./bookmark_gray_new_folder@3x.png
./bookmark_gray_star_large.png
./bookmark_gray_star_large@2x.png
./bookmark_gray_star_large@3x.png
./bookmark_more.png
./bookmark_more@2x.png
./bookmark_more@3x.png
./bookmark_white_close.png
./bookmark_white_close@2x.png
./bookmark_white_close@3x.png
./bookmark_white_delete.png
./bookmark_white_delete@2x.png
./bookmark_white_delete@3x.png
./bookmark_white_edit.png
./bookmark_white_edit@2x.png
./bookmark_white_edit@3x.png
./bookmark_white_move.png
./bookmark_white_move@2x.png
./bookmark_white_move@3x.png
./bookmarks_bar_bg.png
./bookmarks_bar_bg@2x.png
./bookmarks_bar_bg@2x~ipad.png
./bookmarks_bar_bg_pressed@2x~ipad.png
./bookmarks_bar_bg_pressed~ipad.png
./bookmarks_bar_bg~ipad.png
./bookmarks_bar_breadcrumb.png
./bookmarks_bar_breadcrumb@2x.png
./bookmarks_bar_breadcrumb@2x~ipad.png
./bookmarks_bar_breadcrumb~ipad.png
./bookmarks_bar_edit.png
./bookmarks_bar_edit@2x.png
./bookmarks_bar_edit@2x~ipad.png
./bookmarks_bar_edit_moreshadow.png
./bookmarks_bar_edit_moreshadow@2x.png
./bookmarks_bar_edit_pressed.png
./bookmarks_bar_edit_pressed@2x.png
./bookmarks_bar_edit_pressed@2x~ipad.png
./bookmarks_bar_edit_pressed_moreshadow.png
./bookmarks_bar_edit_pressed_moreshadow@2x.png
./bookmarks_bar_edit_pressed~ipad.png
./bookmarks_bar_edit~ipad.png
./bookmarks_bar_left@2x~ipad.png
./bookmarks_bar_left~ipad.png
./bookmarks_button_bg.png
./bookmarks_button_bg@2x.png
./bookmarks_button_border.png
./bookmarks_button_border@2x.png
./border_frame_bottom.png
./border_frame_bottom@2x.png
./border_frame_bottom@3x.png
./border_frame_incognito_bottom.png
./border_frame_incognito_bottom@2x.png
./border_frame_incognito_bottom@3x.png
./border_frame_incognito_left.png
./border_frame_incognito_left@2x.png
./border_frame_incognito_left@3x.png
./border_frame_incognito_right.png
./border_frame_incognito_right@2x.png
./border_frame_incognito_right@3x.png
./border_frame_incognito_top.png
./border_frame_incognito_top@2x.png
./border_frame_incognito_top@3x.png
./border_frame_left.png
./border_frame_left@2x.png
./border_frame_left@3x.png
./border_frame_right.png
./border_frame_right@2x.png
./border_frame_right@3x.png
./border_frame_top.png
./border_frame_top@2x.png
./border_frame_top@3x.png
./card_close_button.png
./card_close_button@2x.png
./card_close_button@3x.png
./card_close_button_incognito.png
./card_close_button_incognito@2x.png
./card_close_button_incognito@3x.png
./card_close_button_pressed.png
./card_close_button_pressed@2x.png
./card_close_button_pressed@3x.png
./card_frame_shadow.png
./card_frame_shadow@2x.png
./card_frame_shadow@3x.png
./collapse.png
./collapse@2x.png
./collapse@3x.png
./collapse_incognito.png
./collapse_incognito@2x.png
./collapse_incognito@3x.png
./collapse_pressed.png
./collapse_pressed@2x.png
./collapse_pressed@3x.png
./collapse_pressed_incognito.png
./collapse_pressed_incognito@2x.png
./collapse_pressed_incognito@3x.png
./content_suggestions_no_image.png
./content_suggestions_no_image@2x.png
./content_suggestions_no_image@3x.png
./content_suggestions_offline.png
./content_suggestions_offline@2x.png
./content_suggestions_offline@3x.png
./custom_row_voice.png
./custom_row_voice@2x.png
./custom_row_voice@2x~ipad.png
./custom_row_voice@3x.png
./custom_row_voice_pressed.png
./custom_row_voice_pressed@2x.png
./custom_row_voice_pressed@2x~ipad.png
./custom_row_voice_pressed@3x.png
./custom_row_voice_pressed~ipad.png
./custom_row_voice~ipad.png
./default_avatar.png
./default_avatar@2x.png
./default_avatar@2x~ipad.png
./default_avatar@3x.png
./default_avatar~ipad.png
./default_favicon.png
./default_favicon@2x.png
./default_favicon@3x.png
./default_favicon_incognito.png
./default_favicon_incognito@2x.png
./default_favicon_incognito@3x.png
./disclosure_open.png
./disclosure_open@2x.png
./distillation_fail.png
./distillation_fail@2x.png
./distillation_fail@3x.png
./distillation_success.png
./distillation_success@2x.png
./distillation_success@3x.png
./ecoutez_bottom_toolbar.png
./ecoutez_bottom_toolbar@2x.png
./ecoutez_bottom_toolbar@3x.png
./ecoutez_button_white_circle.png
./ecoutez_button_white_circle@2x.png
./ecoutez_tts_off.png
./ecoutez_tts_off@2x.png
./ecoutez_tts_off@3x.png
./ecoutez_tts_on.png
./ecoutez_tts_on@2x.png
./ecoutez_tts_on@3x.png
./encryption_error.png
./encryption_error@2x.png
./encryption_error@3x.png
./expand_less.png
./expand_less@2x.png
./expand_less@3x.png
./fatal_error.png
./fatal_error@2x.png
./fatal_error@3x.png
./feedback_sent.png
./feedback_sent@2x.png
./feedback_sent@3x.png
./FeedbackKitFeedbackPrompt.bundle/Resources/heart_icon.png
./FeedbackKitFeedbackPrompt.bundle/Resources/heart_icon@2x.png
./FeedbackKitFeedbackPrompt.bundle/Resources/ic_qu_rate_app.png
./FeedbackKitFeedbackPrompt.bundle/Resources/ic_qu_rate_app@2x.png
./FeedbackKitFeedbackPrompt.bundle/Resources/ic_qu_rate_app@3x.png
./find_bg@2x~ipad.png
./find_bg~ipad.png
./find_close.png
./find_close@2x.png
./find_close@3x.png
./find_close_incognito.png
./find_close_incognito@2x.png
./find_close_incognito@3x.png
./find_close_pressed.png
./find_close_pressed@2x.png
./find_close_pressed@3x.png
./find_next.png
./find_next@2x.png
./find_next@3x.png
./find_next_disabled.png
./find_next_disabled@2x.png
./find_next_disabled@3x.png
./find_next_disabled_incognito.png
./find_next_disabled_incognito@2x.png
./find_next_disabled_incognito@3x.png
./find_next_incognito.png
./find_next_incognito@2x.png
./find_next_incognito@3x.png
./find_next_pressed.png
./find_next_pressed@2x.png
./find_next_pressed@3x.png
./find_next_pressed_incognito.png
./find_next_pressed_incognito@2x.png
./find_next_pressed_incognito@3x.png
./find_prev.png
./find_prev@2x.png
./find_prev@3x.png
./find_prev_disabled.png
./find_prev_disabled@2x.png
./find_prev_disabled@3x.png
./find_prev_disabled_incognito.png
./find_prev_disabled_incognito@2x.png
./find_prev_disabled_incognito@3x.png
./find_prev_incognito.png
./find_prev_incognito@2x.png
./find_prev_incognito@3x.png
./find_prev_pressed.png
./find_prev_pressed@2x.png
./find_prev_pressed@3x.png
./find_prev_pressed_incognito.png
./find_prev_pressed_incognito@2x.png
./find_prev_pressed_incognito@3x.png
./GoogleKitContentViews.bundle/ic_report_problem_red.png
./GoogleKitContentViews.bundle/ic_report_problem_red@2x.png
./GoogleKitContentViews.bundle/ic_report_problem_red@3x.png
./GoogleKitCore.bundle/button_blue.png
./GoogleKitCore.bundle/button_blue@2x.png
./GoogleKitCore.bundle/button_blue@3x.png
./GoogleKitCore.bundle/button_blue_highlighted.png
./GoogleKitCore.bundle/button_blue_highlighted@2x.png
./GoogleKitCore.bundle/button_blue_highlighted@3x.png
./GoogleKitCore.bundle/button_dark.png
./GoogleKitCore.bundle/button_dark@2x.png
./GoogleKitCore.bundle/button_dark@3x.png
./GoogleKitCore.bundle/button_dark_highlighted.png
./GoogleKitCore.bundle/button_dark_highlighted@2x.png
./GoogleKitCore.bundle/button_dark_highlighted@3x.png
./GoogleKitCore.bundle/button_light.png
./GoogleKitCore.bundle/button_light@2x.png
./GoogleKitCore.bundle/button_light@3x.png
./GoogleKitCore.bundle/button_light_highlighted.png
./GoogleKitCore.bundle/button_light_highlighted@2x.png
./GoogleKitCore.bundle/button_light_highlighted@3x.png
./GoogleKitCore.bundle/button_red.png
./GoogleKitCore.bundle/button_red@2x.png
./GoogleKitCore.bundle/button_red@3x.png
./GoogleKitCore.bundle/button_red_highlighted.png
./GoogleKitCore.bundle/button_red_highlighted@2x.png
./GoogleKitCore.bundle/button_red_highlighted@3x.png
./GoogleKitCore.bundle/cell_background_selected_dark.png
./GoogleKitCore.bundle/cell_background_selected_dark@2x.png
./GoogleKitCore.bundle/cell_disclosure_accessory.png
./GoogleKitCore.bundle/cell_disclosure_accessory@2x.png
./GoogleKitCore.bundle/cell_disclosure_accessory@3x.png
./GoogleKitCore.bundle/cell_divider.png
./GoogleKitCore.bundle/cell_divider@2x.png
./GoogleKitCore.bundle/checkbox.png
./GoogleKitCore.bundle/checkbox@2x.png
./GoogleKitCore.bundle/checkbox_checked.png
./GoogleKitCore.bundle/checkbox_checked@2x.png
./GoogleKitCore.bundle/checkmark.png
./GoogleKitCore.bundle/checkmark@2x.png
./GoogleKitCore.bundle/vertical_divider.png
./GoogleKitCore.bundle/vertical_divider@2x.png
./GoogleKitDialogs.bundle/arrow_bottom.png
./GoogleKitDialogs.bundle/arrow_bottom@2x.png
./GoogleKitDialogs.bundle/arrow_left.png
./GoogleKitDialogs.bundle/arrow_left@2x.png
./GoogleKitDialogs.bundle/arrow_right.png
./GoogleKitDialogs.bundle/arrow_right@2x.png
./GoogleKitDialogs.bundle/arrow_top.png
./GoogleKitDialogs.bundle/arrow_top@2x.png
./GoogleKitDialogs.bundle/background.png
./GoogleKitDialogs.bundle/background@2x.png
./GoogleKitDialogs.bundle/bottom.png
./GoogleKitDialogs.bundle/bottom@2x.png
./GoogleKitDialogs.bundle/corner_bottom_left.png
./GoogleKitDialogs.bundle/corner_bottom_left@2x.png
./GoogleKitDialogs.bundle/corner_bottom_right.png
./GoogleKitDialogs.bundle/corner_bottom_right@2x.png
./GoogleKitDialogs.bundle/corner_top_left.png
./GoogleKitDialogs.bundle/corner_top_left@2x.png
./GoogleKitDialogs.bundle/corner_top_right.png
./GoogleKitDialogs.bundle/corner_top_right@2x.png
./GoogleKitDialogs.bundle/ic_report_problem_red.png
./GoogleKitDialogs.bundle/ic_report_problem_red@2x.png
./GoogleKitDialogs.bundle/ic_report_problem_red@3x.png
./GoogleKitDialogs.bundle/left.png
./GoogleKitDialogs.bundle/left@2x.png
./GoogleKitDialogs.bundle/right.png
./GoogleKitDialogs.bundle/right@2x.png
./GoogleKitDialogs.bundle/top.png
./GoogleKitDialogs.bundle/top@2x.png
./GoogleKitPanel.bundle/divider.png
./GoogleKitPanel.bundle/divider@2x.png
./GoogleKitPanel.bundle/ic_arrow_drop_down_white.png
./GoogleKitPanel.bundle/ic_arrow_drop_down_white@2x.png
./GoogleKitPanel.bundle/ic_arrow_drop_down_white@3x.png
./GoogleKitPanel.bundle/ic_settings_sm_lightalt.png
./GoogleKitPanel.bundle/ic_settings_sm_lightalt@2x.png
./GoogleKitPanel.bundle/ic_settings_sm_lightreg.png
./GoogleKitPanel.bundle/ic_settings_sm_lightreg@2x.png
./GoogleKitPanel.bundle/ic_settings_white.png
./GoogleKitPanel.bundle/ic_settings_white@2x.png
./GoogleKitPanel.bundle/ic_settings_white@3x.png
./GoogleKitProgressBar.bundle/ipad-progress-bar.png
./GoogleKitProgressBar.bundle/ipad-progress-bar@2x.png
./GoogleKitProgressBar.bundle/iphone-progress-bar.png
./GoogleKitProgressBar.bundle/iphone-progress-bar@2x.png
./GoogleKitSwitch.bundle/switch_label_I.png
./GoogleKitSwitch.bundle/switch_label_I@2x.png
./GoogleKitSwitch.bundle/switch_label_O.png
./GoogleKitSwitch.bundle/switch_label_O@2x.png
./GoogleKitSwitch.bundle/switch_label_off.png
./GoogleKitSwitch.bundle/switch_label_off@2x.png
./GoogleKitSwitch.bundle/switch_label_on.png
./GoogleKitSwitch.bundle/switch_label_on@2x.png
./GoogleKitSwitch.bundle/switch_mask_rect.png
./GoogleKitSwitch.bundle/switch_mask_rect@2x.png
./GoogleKitSwitch.bundle/switch_thumb_rect_flat.png
./GoogleKitSwitch.bundle/switch_thumb_rect_flat@2x.png
./GoogleKitSwitch.bundle/switch_track_rect_flat.png
./GoogleKitSwitch.bundle/switch_track_rect_flat@2x.png
./GoogleKitUINavigation.bundle/navbar_button.png
./GoogleKitUINavigation.bundle/navbar_button@2x.png
./GoogleKitUINavigation.bundle/navbar_button_highlighted.png
./GoogleKitUINavigation.bundle/navbar_button_highlighted@2x.png
./GoogleKitUINavigation.bundle/navbar_floating.png
./GoogleKitUINavigation.bundle/navbar_floating@2x.png
./GoogleKitUINavigation.bundle/navbar_full.png
./GoogleKitUINavigation.bundle/navbar_full@2x.png
./GoogleKitUINavigation.bundle/navbar_full_80.png
./GoogleKitUINavigation.bundle/navbar_full_80@2x.png
./GoogleKitUINavigation.bundle/navbar_full_landscape.png
./GoogleKitUINavigation.bundle/navbar_full_landscape@2x.png
./GoogleKitUINavigation.bundle/navbar_full_landscape_80.png
./GoogleKitUINavigation.bundle/navbar_full_landscape_80@2x.png
./GoogleKitUINavigation.bundle/navbar_shadow.png
./GoogleKitUINavigation.bundle/navbar_shadow@2x.png
./GoogleKitUINavigation.bundle/qtm_ic_arrow_back.png
./GoogleKitUINavigation.bundle/qtm_ic_arrow_back@2x.png
./GoogleKitUINavigation.bundle/qtm_ic_arrow_back@3x.png
./GoogleKitUINavigation.bundle/qtm_ic_arrow_forward.png
./GoogleKitUINavigation.bundle/qtm_ic_arrow_forward@2x.png
./GoogleKitUINavigation.bundle/qtm_ic_arrow_forward@3x.png
./GoogleKitWeb.bundle/sheet_shadow.png
./GoogleKitWeb.bundle/sheet_shadow@2x.png
./Icon-120.png
./Icon-152.png
./Icon-167.png
./Icon-180.png
./Icon-29.png
./Icon-40.png
./Icon-58.png
./Icon-76.png
./Icon-80.png
./Icon-87.png
./incognito_icon.png
./incognito_icon@2x.png
./incognito_icon@3x.png
./incognito_marker_typing.png
./incognito_marker_typing@2x.png
./incognito_marker_typing@3x.png
./infobar_close.png
./infobar_close@2x.png
./infobar_close@3x.png
./infobar_downloading.png
./infobar_downloading@2x.png
./infobar_downloading@3x.png
./infobar_popup_blocker.png
./infobar_popup_blocker@2x.png
./infobar_popup_blocker@3x.png
./infobar_shadow.png
./infobar_shadow@2x.png
./infobar_update.png
./infobar_update@2x.png
./infobar_update@3x.png
./infobar_warning.png
./infobar_warning@2x.png
./infobar_warning@3x.png
./keyboard_accessory_qr_scanner.png
./keyboard_accessory_qr_scanner@2x.png
./keyboard_accessory_qr_scanner@3x.png
./keyboard_accessory_voice_search.png
./keyboard_accessory_voice_search@2x.png
./keyboard_accessory_voice_search@3x.png
./keyboard_bg_portrait_tablet.png
./keyboard_button.png
./keyboard_button@2x.png
./keyboard_button@2x~ipad.png
./keyboard_button@3x.png
./keyboard_button~ipad.png
./MaterialIcons_ic_arrow_back.bundle/ic_arrow_back.png
./MaterialIcons_ic_arrow_back.bundle/ic_arrow_back@2x.png
./MaterialIcons_ic_arrow_back.bundle/ic_arrow_back@3x.png
./MaterialIcons_ic_arrow_back.bundle/ic_arrow_back_ios.png
./MaterialIcons_ic_arrow_back.bundle/ic_arrow_back_ios@2x.png
./MaterialIcons_ic_arrow_back.bundle/ic_arrow_back_ios@3x.png
./MaterialIcons_ic_check.bundle/ic_check.png
./MaterialIcons_ic_check.bundle/ic_check@2x.png
./MaterialIcons_ic_check.bundle/ic_check@3x.png
./MaterialIcons_ic_check_circle.bundle/ic_check_circle.png
./MaterialIcons_ic_check_circle.bundle/ic_check_circle@2x.png
./MaterialIcons_ic_check_circle.bundle/ic_check_circle@3x.png
./MaterialIcons_ic_chevron_right.bundle/ic_chevron_right.png
./MaterialIcons_ic_chevron_right.bundle/ic_chevron_right@2x.png
./MaterialIcons_ic_chevron_right.bundle/ic_chevron_right@3x.png
./MaterialIcons_ic_info.bundle/ic_info.png
./MaterialIcons_ic_info.bundle/ic_info@2x.png
./MaterialIcons_ic_info.bundle/ic_info@3x.png
./MaterialIcons_ic_radio_button_unchecked.bundle/ic_radio_button_unchecked.png
./MaterialIcons_ic_radio_button_unchecked.bundle/ic_radio_button_unchecked@2x.png
./MaterialIcons_ic_radio_button_unchecked.bundle/ic_radio_button_unchecked@3x.png
./MaterialIcons_ic_reorder.bundle/ic_reorder.png
./MaterialIcons_ic_reorder.bundle/ic_reorder@2x.png
./MaterialIcons_ic_reorder.bundle/ic_reorder@3x.png
./ntp_bookmarks.png
./ntp_bookmarks@2x.png
./ntp_bookmarks@3x.png
./ntp_bottom_bar_shadow.png
./ntp_bottom_bar_shadow@2x.png
./ntp_delete_button.png
./ntp_delete_button@2x.png
./ntp_google_search_box.png
./ntp_google_search_box@2x.png
./ntp_google_search_box@3x.png
./ntp_incognito.png
./ntp_incognito@2x.png
./ntp_mv_placeholder_bg.png
./ntp_mv_placeholder_bg@2x.png
./ntp_mv_placeholder_bg@3x.png
./ntp_mv_recentbar@2x~ipad.png
./ntp_mv_recentbar~ipad.png
./ntp_mv_recentpress@2x~ipad.png
./ntp_mv_recentpress~ipad.png
./ntp_mv_search.png
./ntp_mv_search@2x.png
./ntp_mv_thumbnail_container.png
./ntp_mv_thumbnail_container@2x.png
./ntp_mv_thumbnail_container@3x.png
./ntp_mv_thumbnail_empty.png
./ntp_mv_thumbnail_empty@2x.png
./ntp_mv_thumbnail_empty@2x~ipad.png
./ntp_mv_thumbnail_empty~ipad.png
./ntp_mv_welcome_favicon.png
./ntp_mv_welcome_favicon@2x.png
./ntp_opentabs@2x.png
./ntp_opentabs@3x.png
./ntp_opentabs_clock.png
./ntp_opentabs_clock@2x.png
./ntp_opentabs_clock@3x.png
./ntp_opentabs_header@2x~ipad.png
./ntp_opentabs_header~ipad.png
./ntp_opentabs_laptop.png
./ntp_opentabs_laptop@2x.png
./ntp_opentabs_laptop@3x.png
./ntp_opentabs_last_row@2x~ipad.png
./ntp_opentabs_last_row_h@2x~ipad.png
./ntp_opentabs_last_row_h~ipad.png
./ntp_opentabs_last_row~ipad.png
./ntp_opentabs_list_item@2x~ipad.png
./ntp_opentabs_list_item_h@2x~ipad.png
./ntp_opentabs_list_item_h~ipad.png
./ntp_opentabs_list_item~ipad.png
./ntp_opentabs_phone.png
./ntp_opentabs_phone@2x.png
./ntp_opentabs_phone@3x.png
./ntp_opentabs_recent_arrow.png
./ntp_opentabs_recent_arrow@2x.png
./ntp_opentabs_recent_arrow@3x.png
./ntp_opentabs_tablet.png
./ntp_opentabs_tablet@2x.png
./ntp_opentabs_tablet@3x.png
./ntp_recently_closed.png
./ntp_recently_closed@2x.png
./ntp_recently_closed@3x.png
./omnibox_background.png
./omnibox_background@2x.png
./omnibox_background@3x.png
./omnibox_transparent_background.png
./omnibox_transparent_background@2x.png
./omnibox_transparent_background@3x.png
./PlugIns/search_widget_extension.appex/quick_action_camera_search.png
./PlugIns/search_widget_extension.appex/quick_action_camera_search@2x.png
./PlugIns/search_widget_extension.appex/quick_action_camera_search@3x.png
./PlugIns/search_widget_extension.appex/quick_action_incognito_search.png
./PlugIns/search_widget_extension.appex/quick_action_incognito_search@2x.png
./PlugIns/search_widget_extension.appex/quick_action_incognito_search@3x.png
./PlugIns/search_widget_extension.appex/quick_action_search.png
./PlugIns/search_widget_extension.appex/quick_action_search@2x.png
./PlugIns/search_widget_extension.appex/quick_action_search@3x.png
./PlugIns/search_widget_extension.appex/quick_action_voice_search.png
./PlugIns/search_widget_extension.appex/quick_action_voice_search@2x.png
./PlugIns/search_widget_extension.appex/quick_action_voice_search@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_arrow_back.bundle/ic_arrow_back.png
./PlugIns/today_extension.appex/MaterialIcons_ic_arrow_back.bundle/ic_arrow_back@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_arrow_back.bundle/ic_arrow_back@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_arrow_back.bundle/ic_arrow_back_ios.png
./PlugIns/today_extension.appex/MaterialIcons_ic_arrow_back.bundle/ic_arrow_back_ios@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_arrow_back.bundle/ic_arrow_back_ios@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_check.bundle/ic_check.png
./PlugIns/today_extension.appex/MaterialIcons_ic_check.bundle/ic_check@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_check.bundle/ic_check@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_check_circle.bundle/ic_check_circle.png
./PlugIns/today_extension.appex/MaterialIcons_ic_check_circle.bundle/ic_check_circle@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_check_circle.bundle/ic_check_circle@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_chevron_right.bundle/ic_chevron_right.png
./PlugIns/today_extension.appex/MaterialIcons_ic_chevron_right.bundle/ic_chevron_right@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_chevron_right.bundle/ic_chevron_right@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_info.bundle/ic_info.png
./PlugIns/today_extension.appex/MaterialIcons_ic_info.bundle/ic_info@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_info.bundle/ic_info@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_radio_button_unchecked.bundle/ic_radio_button_unchecked.png
./PlugIns/today_extension.appex/MaterialIcons_ic_radio_button_unchecked.bundle/ic_radio_button_unchecked@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_radio_button_unchecked.bundle/ic_radio_button_unchecked@3x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_reorder.bundle/ic_reorder.png
./PlugIns/today_extension.appex/MaterialIcons_ic_reorder.bundle/ic_reorder@2x.png
./PlugIns/today_extension.appex/MaterialIcons_ic_reorder.bundle/ic_reorder@3x.png
./PlugIns/today_extension.appex/todayview_clipboard.png
./PlugIns/today_extension.appex/todayview_clipboard@2x.png
./PlugIns/today_extension.appex/todayview_clipboard@3x.png
./PlugIns/today_extension.appex/todayview_new_tab.png
./PlugIns/today_extension.appex/todayview_new_tab@2x.png
./PlugIns/today_extension.appex/todayview_new_tab@3x.png
./PlugIns/today_extension.appex/todayview_physical_web.png
./PlugIns/today_extension.appex/todayview_physical_web@2x.png
./PlugIns/today_extension.appex/todayview_physical_web@3x.png
./PlugIns/today_extension.appex/todayview_voice_search.png
./PlugIns/today_extension.appex/todayview_voice_search@2x.png
./PlugIns/today_extension.appex/todayview_voice_search@3x.png
./popup_background.png
./popup_background@2x.png
./popup_background@3x.png
./ptr_close.png
./ptr_close@2x.png
./ptr_close@3x.png
./ptr_close_active.png
./ptr_close_active@2x.png
./ptr_close_active@3x.png
./ptr_new_tab.png
./ptr_new_tab@2x.png
./ptr_new_tab@3x.png
./ptr_new_tab_active.png
./ptr_new_tab_active@2x.png
./ptr_new_tab_active@3x.png
./ptr_reload.png
./ptr_reload@2x.png
./ptr_reload@3x.png
./ptr_reload_active.png
./ptr_reload_active@2x.png
./ptr_reload_active@3x.png
./quick_action_new_incognito_tab@2x.png
./quick_action_new_incognito_tab@3x.png
./quick_action_new_tab@2x.png
./quick_action_new_tab@3x.png
./quick_action_qr_scanner@2x.png
./quick_action_qr_scanner@3x.png
./quick_action_voice_search@2x.png
./quick_action_voice_search@3x.png
./reading_list_empty_state.png
./reading_list_empty_state@2x.png
./reading_list_empty_state@3x.png
./reading_list_share_icon.png
./reading_list_share_icon@2x.png
./reading_list_share_icon@3x.png
./reading_list_side_swipe.png
./reading_list_side_swipe@2x.png
./reading_list_side_swipe@3x.png
./reading_list_toolbar_icon.png
./reading_list_toolbar_icon@2x.png
./reading_list_toolbar_icon@3x.png
./settings_accounts_add_account.png
./settings_accounts_add_account@2x.png
./settings_accounts_add_account@3x.png
./settings_error.png
./settings_error@2x.png
./settings_error@3x.png
./settings_sync.png
./settings_sync@2x.png
./settings_sync@3x.png
./side_swipe_navigation_back.png
./side_swipe_navigation_back@2x.png
./side_swipe_navigation_back@3x.png
./side_swipe_navigation_content_shadow.png
./side_swipe_navigation_content_shadow@2x.png
./side_swipe_navigation_content_shadow@3x.png
./signin_confirmation_more.png
./signin_confirmation_more@2x.png
./signin_confirmation_more@3x.png
./signin_promo_close_gray.png
./signin_promo_close_gray@2x.png
./signin_promo_close_gray@3x.png
./signin_promo_logo_chromium_color.png
./signin_promo_logo_chromium_color@2x.png
./signin_promo_logo_chromium_color@3x.png
./SSOAuth.bundle/add.png
./SSOAuth.bundle/add@2x.png
./SSOAuth.bundle/add@3x.png
./SSOAuth.bundle/check.png
./SSOAuth.bundle/check@2x.png
./SSOAuth.bundle/check@3x.png
./SSOAuth.bundle/close.png
./SSOAuth.bundle/close@2x.png
./SSOAuth.bundle/close@3x.png
./SSOAuth.bundle/default_avatar.png
./SSOAuth.bundle/default_avatar@2x.png
./SSOAuth.bundle/default_avatar@3x.png
./SSOAuth.bundle/drop_down.png
./SSOAuth.bundle/drop_down@2x.png
./SSOAuth.bundle/drop_down@3x.png
./tabstrip_background_tab@2x~ipad.png
./tabstrip_background_tab~ipad.png
./tabstrip_foreground_tab@2x~ipad.png
./tabstrip_foreground_tab~ipad.png
./tabstrip_incognito_background_tab@2x~ipad.png
./tabstrip_incognito_background_tab~ipad.png
./tabstrip_incognito_foreground_tab@2x~ipad.png
./tabstrip_incognito_foreground_tab~ipad.png
./tabstrip_new_tab@2x~ipad.png
./tabstrip_new_tab_incognito@2x~ipad.png
./tabstrip_new_tab_incognito_pressed@2x~ipad.png
./tabstrip_new_tab_incognito_pressed~ipad.png
./tabstrip_new_tab_incognito~ipad.png
./tabstrip_new_tab_pressed@2x~ipad.png
./tabstrip_new_tab_pressed~ipad.png
./tabstrip_new_tab~ipad.png
./tabstrip_tab_close@2x~ipad.png
./tabstrip_tab_close_incognito@2x~ipad.png
./tabstrip_tab_close_incognito_pressed@2x~ipad.png
./tabstrip_tab_close_incognito_pressed~ipad.png
./tabstrip_tab_close_incognito~ipad.png
./tabstrip_tab_close_pressed@2x~ipad.png
./tabstrip_tab_close_pressed~ipad.png
./tabstrip_tab_close~ipad.png
./tabstrip_toggle_button_gradient@2x~ipad.png
./tabstrip_toggle_button_gradient@3x~ipad.png
./tabstrip_toggle_button_gradient~ipad.png
./tabswitcher_full_history.png
./tabswitcher_full_history@2x.png
./tabswitcher_full_history@3x.png
./tabswitcher_incognito.png
./tabswitcher_incognito@2x.png
./tabswitcher_incognito@3x.png
./tabswitcher_laptop.png
./tabswitcher_laptop@2x.png
./tabswitcher_laptop@3x.png
./tabswitcher_menu.png
./tabswitcher_menu@2x.png
./tabswitcher_menu@3x.png
./tabswitcher_new_tab.png
./tabswitcher_new_tab@2x.png
./tabswitcher_new_tab@3x.png
./tabswitcher_new_tab_fab.png
./tabswitcher_new_tab_fab@2x.png
./tabswitcher_new_tab_fab@3x.png
./tabswitcher_open_tabs.png
./tabswitcher_open_tabs@2x.png
./tabswitcher_open_tabs@3x.png
./tabswitcher_other_devices.png
./tabswitcher_other_devices@2x.png
./tabswitcher_other_devices@3x.png
./tabswitcher_overflow_arrow.png
./tabswitcher_overflow_arrow@2x.png
./tabswitcher_overflow_arrow@3x.png
./tabswitcher_phone.png
./tabswitcher_phone@2x.png
./tabswitcher_phone@3x.png
./tabswitcher_recently_closed.png
./tabswitcher_recently_closed@2x.png
./tabswitcher_recently_closed@3x.png
./tabswitcher_tab_switcher_button.png
./tabswitcher_tab_switcher_button@2x.png
./tabswitcher_tab_switcher_button@3x.png
./tabswitcher_tablet.png
./tabswitcher_tablet@2x.png
./tabswitcher_tablet@3x.png
./toolbar_dark_newtab.png
./toolbar_dark_newtab@2x.png
./toolbar_dark_newtab@3x.png
./toolbar_dark_newtab_active.png
./toolbar_dark_newtab_active@2x.png
./toolbar_dark_newtab_active@3x.png
./toolbar_dark_newtab_incognito.png
./toolbar_dark_newtab_incognito@2x.png
./toolbar_dark_newtab_incognito@3x.png
./toolbar_dark_newtab_incognito_active.png
./toolbar_dark_newtab_incognito_active@2x.png
./toolbar_dark_newtab_incognito_active@3x.png

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/943e2ed8dd865bd67418babaaee0d72a20df91c8

commit 943e2ed8dd865bd67418babaaee0d72a20df91c8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Jun 30 17:47:44 2017

Refactor assets catalog declaration and compilation.

Add a template "imageset" to declare compile a single .imageset
directory into a bundle compiled asset catalog. This template
works by copying the images in a brand new .xcassets bundle in
$target_gen_dir and declaring a bundle_data pointing to that
.xcassets.

Refactor all target declaring .imageset resources to use the new
template. This should ensure that only the resources used are in
the generated Assets.car file (as the compilation is done at the
.xcassets level, so may have included unused resources previously).

Refactor target that referenced images copied from the material
design icons repository to use the newly tracked resources.

Bug: 734054,738359
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I629dd2c845b52f6ffbf5a314e570305f9c819592
Reviewed-on: https://chromium-review.googlesource.com/558351
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483748}
[add] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/build/config/ios/dummy.py
[add] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/build/config/ios/imageset.gni
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/components/cronet/ios/BUILD.gn
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/components/cronet/tools/dummy.py
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/app/resources/BUILD.gn
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/downloads/BUILD.gn
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/first_run/BUILD.gn
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/icons/BUILD.gn
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/Contents.json
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back_2x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back_3x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/Contents.json
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right_2x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right_3x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/Contents.json
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close_2x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close_3x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/Contents.json
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info_2x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info_3x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/Contents.json
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search_2x.png
[delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search_3x.png
[modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[add] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/third_party/material_design_icons/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126104abf29d343a9c3cea8983dcb15228ec0cbe

commit 126104abf29d343a9c3cea8983dcb15228ec0cbe
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Jul 03 16:00:41 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/activity_services/resources.

Bug: 738359
Change-Id: I0f912fce055edab049caf9fe650e94130be4d1b7
Reviewed-on: https://chromium-review.googlesource.com/558936
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484012}
[modify] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/BUILD.gn
[add] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/BUILD.gn
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/Contents.json
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-60@2x.png
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-60@3x.png
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-76.png
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-76@2x.png
[delete] https://crrev.com/065872a8ca42e1302dec5102c1576efcc9ba8b04/ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/Contents.json
[add] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list.imageset/Contents.json
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list.imageset/activity_services_reading_list.png
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list.imageset/activity_services_reading_list@2x.png
[rename] https://crrev.com/126104abf29d343a9c3cea8983dcb15228ec0cbe/ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list.imageset/activity_services_reading_list@3x.png

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c915ebabbfce16d43ff0e188414093c425910003

commit c915ebabbfce16d43ff0e188414093c425910003
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Jul 03 16:22:41 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/settings/resources.

Bug: 738359
Change-Id: I0403f99fa3fe601399404c24bec11652a4d934ff
Reviewed-on: https://chromium-review.googlesource.com/558921
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484013}
[modify] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/BUILD.gn
[add] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/BUILD.gn
[add] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/app_icon_placeholder.imageset/Contents.json
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/app_icon_placeholder.imageset/app_icon_placeholder.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/app_icon_placeholder.imageset/app_icon_placeholder@2x.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/app_icon_placeholder.imageset/app_icon_placeholder@3x.png
[add] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/encryption_error.imageset/Contents.json
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/encryption_error.imageset/encryption_error.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/encryption_error.imageset/encryption_error@2x.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/encryption_error.imageset/encryption_error@3x.png
[add] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_accounts_add_account.imageset/Contents.json
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_accounts_add_account.imageset/settings_accounts_add_account.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_accounts_add_account.imageset/settings_accounts_add_account@2x.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_accounts_add_account.imageset/settings_accounts_add_account@3x.png
[add] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_error.imageset/Contents.json
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_error.imageset/settings_error.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_error.imageset/settings_error@2x.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_error.imageset/settings_error@3x.png
[add] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_sync.imageset/Contents.json
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_sync.imageset/settings_sync.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_sync.imageset/settings_sync@2x.png
[rename] https://crrev.com/c915ebabbfce16d43ff0e188414093c425910003/ios/chrome/browser/ui/settings/resources/settings_sync.imageset/settings_sync@3x.png

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2541c478ddb42e82cfb019d50eca544878ed6464

commit 2541c478ddb42e82cfb019d50eca544878ed6464
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Jul 03 17:08:23 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/bookmarks/resources.

Bug: 738359
Change-Id: I9c02d29a77c9687328e1b37d0c4d290330247a16
Reviewed-on: https://chromium-review.googlesource.com/558941
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484022}
[modify] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/BUILD.gn
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/BUILD.gn
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_innershadow.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_innershadow.imageset/bookmark_bar_innershadow.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_innershadow.imageset/bookmark_bar_innershadow@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_innershadow.imageset/bookmark_bar_innershadow@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_shadow.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_shadow.imageset/bookmark_bar_shadow.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_shadow.imageset/bookmark_bar_shadow@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_bar_shadow.imageset/bookmark_bar_shadow@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_delete.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_delete.imageset/bookmark_black_delete.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_delete.imageset/bookmark_black_delete@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_delete.imageset/bookmark_black_delete@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_edit.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_edit.imageset/bookmark_black_edit.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_edit.imageset/bookmark_black_edit@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_edit.imageset/bookmark_black_edit@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_move.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_move.imageset/bookmark_black_move.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_move.imageset/bookmark_black_move@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_move.imageset/bookmark_black_move@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_select.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_select.imageset/bookmark_black_select.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_select.imageset/bookmark_black_select@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_black_select.imageset/bookmark_black_select@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_check.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_check.imageset/bookmark_blue_check.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_check.imageset/bookmark_blue_check@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_check.imageset/bookmark_blue_check@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/bookmark_blue_folder.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/bookmark_blue_folder@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/bookmark_blue_folder@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_back.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_back.imageset/bookmark_gray_back.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_back.imageset/bookmark_gray_back@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_back.imageset/bookmark_gray_back@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_check.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_check.imageset/bookmark_gray_check.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_check.imageset/bookmark_gray_check@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_check.imageset/bookmark_gray_check@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_close.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_close.imageset/bookmark_gray_close.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_close.imageset/bookmark_gray_close@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_close.imageset/bookmark_gray_close@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_edit.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_edit.imageset/bookmark_gray_edit.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_edit.imageset/bookmark_gray_edit@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_edit.imageset/bookmark_gray_edit@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder.imageset/bookmark_gray_folder.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder.imageset/bookmark_gray_folder@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder.imageset/bookmark_gray_folder@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_menu.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_menu.imageset/bookmark_gray_menu.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_menu.imageset/bookmark_gray_menu@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_menu.imageset/bookmark_gray_menu@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_new_folder.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_new_folder.imageset/bookmark_gray_new_folder.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_new_folder.imageset/bookmark_gray_new_folder@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_new_folder.imageset/bookmark_gray_new_folder@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star_large.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star_large.imageset/bookmark_gray_star_large.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star_large.imageset/bookmark_gray_star_large@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star_large.imageset/bookmark_gray_star_large@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_more.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_more.imageset/bookmark_more.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_more.imageset/bookmark_more@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_more.imageset/bookmark_more@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_close.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_close.imageset/bookmark_white_close.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_close.imageset/bookmark_white_close@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_close.imageset/bookmark_white_close@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_delete.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_delete.imageset/bookmark_white_delete.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_delete.imageset/bookmark_white_delete@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_delete.imageset/bookmark_white_delete@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_edit.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_edit.imageset/bookmark_white_edit.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_edit.imageset/bookmark_white_edit@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_edit.imageset/bookmark_white_edit@3x.png
[add] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_move.imageset/Contents.json
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_move.imageset/bookmark_white_move.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_move.imageset/bookmark_white_move@2x.png
[rename] https://crrev.com/2541c478ddb42e82cfb019d50eca544878ed6464/ios/chrome/browser/ui/bookmarks/resources/bookmark_white_move.imageset/bookmark_white_move@3x.png

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6c3dbedab6908fb7e036be8b0e152b493a3523f

commit d6c3dbedab6908fb7e036be8b0e152b493a3523f
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Jul 03 17:21:02 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/web/resources (and move them to correct
location ios/chrome/browser/autofill/resources).

Bug: 738359
Change-Id: Ibf6aa6c18903852c5032b25a57b0e2ff3795d65e
Reviewed-on: https://chromium-review.googlesource.com/558922
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484023}
[modify] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/BUILD.gn
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/BUILD.gn
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@2x~ipad.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@3x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa~ipad.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close.imageset/autofill_close.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close.imageset/autofill_close@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close.imageset/autofill_close@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close_pressed.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close_pressed.imageset/autofill_close_pressed.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close_pressed.imageset/autofill_close_pressed@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_close_pressed.imageset/autofill_close_pressed@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background.imageset/autofill_keyboard_background.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background.imageset/autofill_keyboard_background@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background.imageset/autofill_keyboard_background@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background_left.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background_left.imageset/autofill_keyboard_background_left.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background_left.imageset/autofill_keyboard_background_left@2x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background_right.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background_right.imageset/autofill_keyboard_background_right.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_keyboard_background_right.imageset/autofill_keyboard_background_right@2x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep.imageset/autofill_left_sep.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep.imageset/autofill_left_sep@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep.imageset/autofill_left_sep@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep_RTL.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep_RTL.imageset/autofill_left_sep_RTL.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep_RTL.imageset/autofill_left_sep_RTL@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_left_sep_RTL.imageset/autofill_left_sep_RTL@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_middle_sep.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_middle_sep.imageset/autofill_middle_sep.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_middle_sep.imageset/autofill_middle_sep@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_middle_sep.imageset/autofill_middle_sep@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next.imageset/autofill_next.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next.imageset/autofill_next@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next.imageset/autofill_next@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_inactive.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_inactive.imageset/autofill_next_inactive.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_inactive.imageset/autofill_next_inactive@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_inactive.imageset/autofill_next_inactive@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_pressed.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_pressed.imageset/autofill_next_pressed.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_pressed.imageset/autofill_next_pressed@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_next_pressed.imageset/autofill_next_pressed@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev.imageset/autofill_prev.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev.imageset/autofill_prev@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev.imageset/autofill_prev@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_inactive.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_inactive.imageset/autofill_prev_inactive.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_inactive.imageset/autofill_prev_inactive@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_inactive.imageset/autofill_prev_inactive@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_pressed.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_pressed.imageset/autofill_prev_pressed.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_pressed.imageset/autofill_prev_pressed@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_prev_pressed.imageset/autofill_prev_pressed@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep.imageset/autofill_right_sep.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep.imageset/autofill_right_sep@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep.imageset/autofill_right_sep@3x.png
[add] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep_RTL.imageset/Contents.json
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep_RTL.imageset/autofill_right_sep_RTL.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep_RTL.imageset/autofill_right_sep_RTL@2x.png
[rename] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/autofill/resources/autofill_right_sep_RTL.imageset/autofill_right_sep_RTL@3x.png
[modify] https://crrev.com/d6c3dbedab6908fb7e036be8b0e152b493a3523f/ios/chrome/browser/web/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe92043ec81ca6bd728b50161615c96e4f2a72bd

commit fe92043ec81ca6bd728b50161615c96e4f2a72bd
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 08:32:49 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/search_widget_extension.

Bug: 738359
Change-Id: I08b2b02c160cd8e33d23fee7809d45f0af5b9e65
Reviewed-on: https://chromium-review.googlesource.com/558968
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484067}
[modify] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/BUILD.gn
[add] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/BUILD.gn
[add] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_camera_search.imageset/Contents.json
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_camera_search.imageset/quick_action_camera_search.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_camera_search.imageset/quick_action_camera_search@2x.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_camera_search.imageset/quick_action_camera_search@3x.png
[add] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_incognito_search.imageset/Contents.json
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_incognito_search.imageset/quick_action_incognito_search.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_incognito_search.imageset/quick_action_incognito_search@2x.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_incognito_search.imageset/quick_action_incognito_search@3x.png
[add] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_search.imageset/Contents.json
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_search.imageset/quick_action_search.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_search.imageset/quick_action_search@2x.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_search.imageset/quick_action_search@3x.png
[add] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_voice_search.imageset/Contents.json
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_voice_search.imageset/quick_action_voice_search.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_voice_search.imageset/quick_action_voice_search@2x.png
[rename] https://crrev.com/fe92043ec81ca6bd728b50161615c96e4f2a72bd/ios/chrome/search_widget_extension/resources/quick_action_voice_search.imageset/quick_action_voice_search@3x.png

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bef8389f9f0e4e0f832db360a777a82e94e0d9a

commit 3bef8389f9f0e4e0f832db360a777a82e94e0d9a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 08:35:29 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/content_suggestions.

Bug: 738359
Change-Id: Ia023714379f885ecfba2ee7b8186f709e6166d71
Reviewed-on: https://chromium-review.googlesource.com/558967
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484068}
[modify] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[add] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/BUILD.gn
[add] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image.imageset/Contents.json
[rename] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image.imageset/content_suggestions_no_image.png
[rename] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image.imageset/content_suggestions_no_image@2x.png
[rename] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image.imageset/content_suggestions_no_image@3x.png
[add] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline.imageset/Contents.json
[rename] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline.imageset/content_suggestions_offline.png
[rename] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline.imageset/content_suggestions_offline@2x.png
[rename] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline.imageset/content_suggestions_offline@3x.png

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a610960559b0f6c03b24c024146cf9ba28627bb

commit 6a610960559b0f6c03b24c024146cf9ba28627bb
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 08:35:59 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/reading_list.

Bug: 738359
Change-Id: Ide42849540277371ab57035c2698439f35303e01
Reviewed-on: https://chromium-review.googlesource.com/558986
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484069}
[modify] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/BUILD.gn
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/BUILD.gn
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_fail.imageset/Contents.json
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_fail.imageset/distillation_fail.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_fail.imageset/distillation_fail@2x.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_fail.imageset/distillation_fail@3x.png
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_success.imageset/Contents.json
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_success.imageset/distillation_success.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_success.imageset/distillation_success@2x.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/distillation_success.imageset/distillation_success@3x.png
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_empty_state.imageset/Contents.json
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_empty_state.imageset/reading_list_empty_state.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_empty_state.imageset/reading_list_empty_state@2x.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_empty_state.imageset/reading_list_empty_state@3x.png
[delete] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/reading_list/resources/reading_list_icon.png
[delete] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/reading_list/resources/reading_list_icon@2x.png
[delete] https://crrev.com/3bef8389f9f0e4e0f832db360a777a82e94e0d9a/ios/chrome/browser/ui/reading_list/resources/reading_list_icon@3x.png
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_share_icon.imageset/Contents.json
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_share_icon.imageset/reading_list_share_icon.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_share_icon.imageset/reading_list_share_icon@2x.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_share_icon.imageset/reading_list_share_icon@3x.png
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_side_swipe.imageset/Contents.json
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_side_swipe.imageset/reading_list_side_swipe.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_side_swipe.imageset/reading_list_side_swipe@2x.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_side_swipe.imageset/reading_list_side_swipe@3x.png
[add] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_toolbar_icon.imageset/Contents.json
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_toolbar_icon.imageset/reading_list_toolbar_icon.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_toolbar_icon.imageset/reading_list_toolbar_icon@2x.png
[rename] https://crrev.com/6a610960559b0f6c03b24c024146cf9ba28627bb/ios/chrome/browser/ui/reading_list/resources/reading_list_toolbar_icon.imageset/reading_list_toolbar_icon@3x.png

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4

commit f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 09:04:01 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui.

Bug: 738359
Change-Id: I8d664edc94839cfc71ca458fc76ad0fba723a55c
Reviewed-on: https://chromium-review.googlesource.com/558985
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484072}
[modify] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/BUILD.gn
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice.imageset/Contents.json
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice.imageset/custom_row_voice.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice.imageset/custom_row_voice@2x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice.imageset/custom_row_voice@2x~ipad.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice.imageset/custom_row_voice@3x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice.imageset/custom_row_voice~ipad.png
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice_pressed.imageset/Contents.json
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice_pressed.imageset/custom_row_voice_pressed.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice_pressed.imageset/custom_row_voice_pressed@2x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice_pressed.imageset/custom_row_voice_pressed@2x~ipad.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice_pressed.imageset/custom_row_voice_pressed@3x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/custom_row_voice_pressed.imageset/custom_row_voice_pressed~ipad.png
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon.imageset/Contents.json
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon.imageset/default_favicon.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon.imageset/default_favicon@2x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon.imageset/default_favicon@3x.png
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon_incognito.imageset/Contents.json
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon_incognito.imageset/default_favicon_incognito.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon_incognito.imageset/default_favicon_incognito@2x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/default_favicon_incognito.imageset/default_favicon_incognito@3x.png
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_bg_portrait_tablet.imageset/Contents.json
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_bg_portrait_tablet.imageset/keyboard_bg_portrait_tablet.png
[add] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_button.imageset/Contents.json
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_button.imageset/keyboard_button.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_button.imageset/keyboard_button@2x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_button.imageset/keyboard_button@2x~ipad.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_button.imageset/keyboard_button@3x.png
[rename] https://crrev.com/f2244ba9ce6fb6656b08a1c72b5e48fabc4c65c4/ios/chrome/browser/ui/resources/keyboard_button.imageset/keyboard_button~ipad.png

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c886fe3db03d15ac4d9ac227289b090f7a199a

commit d9c886fe3db03d15ac4d9ac227289b090f7a199a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 13:08:21 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/contextual_search.

Bug: 738359
Change-Id: I173f9193fdb06f12bd50a7985089805d17387c99
Reviewed-on: https://chromium-review.googlesource.com/559046
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484093}
[modify] https://crrev.com/d9c886fe3db03d15ac4d9ac227289b090f7a199a/ios/chrome/browser/ui/contextual_search/BUILD.gn
[add] https://crrev.com/d9c886fe3db03d15ac4d9ac227289b090f7a199a/ios/chrome/browser/ui/contextual_search/resources/BUILD.gn
[add] https://crrev.com/d9c886fe3db03d15ac4d9ac227289b090f7a199a/ios/chrome/browser/ui/contextual_search/resources/expand_less.imageset/Contents.json
[rename] https://crrev.com/d9c886fe3db03d15ac4d9ac227289b090f7a199a/ios/chrome/browser/ui/contextual_search/resources/expand_less.imageset/expand_less.png
[rename] https://crrev.com/d9c886fe3db03d15ac4d9ac227289b090f7a199a/ios/chrome/browser/ui/contextual_search/resources/expand_less.imageset/expand_less@2x.png
[rename] https://crrev.com/d9c886fe3db03d15ac4d9ac227289b090f7a199a/ios/chrome/browser/ui/contextual_search/resources/expand_less.imageset/expand_less@3x.png

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea

commit ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 13:16:43 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/app/safe_mode.

Bug: 738359
Change-Id: I49c4678b035010e9f4797ee1174c12bcf99de600
Reviewed-on: https://chromium-review.googlesource.com/558999
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484094}
[modify] https://crrev.com/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea/ios/chrome/app/safe_mode/BUILD.gn
[add] https://crrev.com/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea/ios/chrome/app/safe_mode/resources/BUILD.gn
[add] https://crrev.com/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea/ios/chrome/app/safe_mode/resources/fatal_error.imageset/Contents.json
[rename] https://crrev.com/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea/ios/chrome/app/safe_mode/resources/fatal_error.imageset/fatal_error.png
[rename] https://crrev.com/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea/ios/chrome/app/safe_mode/resources/fatal_error.imageset/fatal_error@2x.png
[rename] https://crrev.com/ac8557fa39cfd41eb953e2b9d9cddbb7e8596fea/ios/chrome/app/safe_mode/resources/fatal_error.imageset/fatal_error@3x.png

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c07c31d41c40dfa513593cb10fb5fcc98a533a6

commit 8c07c31d41c40dfa513593cb10fb5fcc98a533a6
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 14:07:31 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/infobars (and move infobar_update
to ios/chrome/browser/upgrade to be close to code using it).

Bug: 738359
Change-Id: I96d7832460fd75e2deb1f81bbb73eef361685202
Reviewed-on: https://chromium-review.googlesource.com/559051
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484100}
[modify] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/BUILD.gn
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/BUILD.gn
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_close.imageset/Contents.json
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_close.imageset/infobar_close.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_close.imageset/infobar_close@2x.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_close.imageset/infobar_close@3x.png
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_downloading.imageset/Contents.json
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_downloading.imageset/infobar_downloading.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_downloading.imageset/infobar_downloading@2x.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_downloading.imageset/infobar_downloading@3x.png
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker.imageset/Contents.json
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker.imageset/infobar_popup_blocker.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker.imageset/infobar_popup_blocker@2x.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker.imageset/infobar_popup_blocker@3x.png
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_shadow.imageset/Contents.json
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_shadow.imageset/infobar_shadow.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_shadow.imageset/infobar_shadow@2x.png
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_warning.imageset/Contents.json
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_warning.imageset/infobar_warning.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_warning.imageset/infobar_warning@2x.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/ui/infobars/resources/infobar_warning.imageset/infobar_warning@3x.png
[modify] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/upgrade/BUILD.gn
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/upgrade/resources/BUILD.gn
[add] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/upgrade/resources/infobar_update.imageset/Contents.json
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/upgrade/resources/infobar_update.imageset/infobar_update.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/upgrade/resources/infobar_update.imageset/infobar_update@2x.png
[rename] https://crrev.com/8c07c31d41c40dfa513593cb10fb5fcc98a533a6/ios/chrome/browser/upgrade/resources/infobar_update.imageset/infobar_update@3x.png

Initial comment forgot to list the following large files that would benefit most from app thinning:

./stack_view_background_noise.jpg
./stack_view_background_noise@2x.jpg
./stack_view_background_noise@2x~ipad.jpg
./stack_view_background_noise@3x.jpg
./stack_view_background_noise~ipad.jpg

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f30b0253478c753f1d193a3df0f59d998765cd

commit 68f30b0253478c753f1d193a3df0f59d998765cd
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 14:55:06 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/overscroll_actions.

Bug: 738359
Change-Id: I6923e55b67b5eb6b6848ebf0c0f0fad2879b54c2
Reviewed-on: https://chromium-review.googlesource.com/559057
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484105}
[modify] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/BUILD.gn
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/BUILD.gn
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close.imageset/Contents.json
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close.imageset/ptr_close.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close.imageset/ptr_close@2x.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close.imageset/ptr_close@3x.png
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active.imageset/Contents.json
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active.imageset/ptr_close_active.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active.imageset/ptr_close_active@2x.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active.imageset/ptr_close_active@3x.png
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab.imageset/Contents.json
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab.imageset/ptr_new_tab.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab.imageset/ptr_new_tab@2x.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab.imageset/ptr_new_tab@3x.png
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active.imageset/Contents.json
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active.imageset/ptr_new_tab_active.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active.imageset/ptr_new_tab_active@2x.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active.imageset/ptr_new_tab_active@3x.png
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload.imageset/Contents.json
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload.imageset/ptr_reload.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload.imageset/ptr_reload@2x.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload.imageset/ptr_reload@3x.png
[add] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active.imageset/Contents.json
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active.imageset/ptr_reload_active.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active.imageset/ptr_reload_active@2x.png
[rename] https://crrev.com/68f30b0253478c753f1d193a3df0f59d998765cd/ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active.imageset/ptr_reload_active@3x.png

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f

commit 224cc9e8342585c0a7ca6d45c9ec6a617988fc3f
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 15:22:28 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/tab_switcher.

Bug: 738359
Change-Id: I4163f1efb005b1b62dc796e2b856ee4a5d6a1d42
Reviewed-on: https://chromium-review.googlesource.com/559095
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484106}
[modify] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/BUILD.gn
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_full_history.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_full_history.imageset/tabswitcher_full_history.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_full_history.imageset/tabswitcher_full_history@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_full_history.imageset/tabswitcher_full_history@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_incognito.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_incognito.imageset/tabswitcher_incognito.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_incognito.imageset/tabswitcher_incognito@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_incognito.imageset/tabswitcher_incognito@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_laptop.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_laptop.imageset/tabswitcher_laptop.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_laptop.imageset/tabswitcher_laptop@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_laptop.imageset/tabswitcher_laptop@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_menu.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_menu.imageset/tabswitcher_menu.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_menu.imageset/tabswitcher_menu@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_menu.imageset/tabswitcher_menu@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab.imageset/tabswitcher_new_tab.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab.imageset/tabswitcher_new_tab@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab.imageset/tabswitcher_new_tab@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab_fab.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab_fab.imageset/tabswitcher_new_tab_fab.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab_fab.imageset/tabswitcher_new_tab_fab@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_new_tab_fab.imageset/tabswitcher_new_tab_fab@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_open_tabs.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_open_tabs.imageset/tabswitcher_open_tabs.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_open_tabs.imageset/tabswitcher_open_tabs@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_open_tabs.imageset/tabswitcher_open_tabs@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_other_devices.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_other_devices.imageset/tabswitcher_other_devices.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_other_devices.imageset/tabswitcher_other_devices@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_other_devices.imageset/tabswitcher_other_devices@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_overflow_arrow.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_overflow_arrow.imageset/tabswitcher_overflow_arrow.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_overflow_arrow.imageset/tabswitcher_overflow_arrow@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_overflow_arrow.imageset/tabswitcher_overflow_arrow@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_phone.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_phone.imageset/tabswitcher_phone.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_phone.imageset/tabswitcher_phone@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_phone.imageset/tabswitcher_phone@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_recently_closed.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_recently_closed.imageset/tabswitcher_recently_closed.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_recently_closed.imageset/tabswitcher_recently_closed@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_recently_closed.imageset/tabswitcher_recently_closed@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_button.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_button.imageset/tabswitcher_tab_switcher_button.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_button.imageset/tabswitcher_tab_switcher_button@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_button.imageset/tabswitcher_tab_switcher_button@3x.png
[add] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tablet.imageset/Contents.json
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tablet.imageset/tabswitcher_tablet.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tablet.imageset/tabswitcher_tablet@2x.png
[rename] https://crrev.com/224cc9e8342585c0a7ca6d45c9ec6a617988fc3f/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tablet.imageset/tabswitcher_tablet@3x.png

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e9d75c302c4757699ed780d7563b9e256d68ef7

commit 6e9d75c302c4757699ed780d7563b9e256d68ef7
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 15:36:17 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/app.

Bug: 738359
Change-Id: I162f3db1c4fe8e2d8ab995c3f3c3647cc99738f0
Reviewed-on: https://chromium-review.googlesource.com/559060
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484111}
[modify] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/BUILD.gn
[add] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_new_incognito_tab.imageset/Contents.json
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_new_incognito_tab.imageset/quick_action_new_incognito_tab@2x.png
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_new_incognito_tab.imageset/quick_action_new_incognito_tab@3x.png
[add] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_new_tab.imageset/Contents.json
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_new_tab.imageset/quick_action_new_tab@2x.png
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_new_tab.imageset/quick_action_new_tab@3x.png
[add] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_qr_scanner.imageset/Contents.json
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_qr_scanner.imageset/quick_action_qr_scanner@2x.png
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_qr_scanner.imageset/quick_action_qr_scanner@3x.png
[add] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_voice_search.imageset/Contents.json
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_voice_search.imageset/quick_action_voice_search@2x.png
[rename] https://crrev.com/6e9d75c302c4757699ed780d7563b9e256d68ef7/ios/chrome/app/resources/quick_action_voice_search.imageset/quick_action_voice_search@3x.png

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/296640bfa342b8029ca29f86d6cca424134d35c5

commit 296640bfa342b8029ca29f86d6cca424134d35c5
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 15:45:44 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/authentication.

Bug: 738359
Change-Id: I01b54da04ce906910b2f7b0302fbbab8122fe5f9
Reviewed-on: https://chromium-review.googlesource.com/559099
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484114}
[modify] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/BUILD.gn
[add] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/BUILD.gn
[add] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_confirmation_more.imageset/Contents.json
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_confirmation_more.imageset/signin_confirmation_more.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_confirmation_more.imageset/signin_confirmation_more@2x.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_confirmation_more.imageset/signin_confirmation_more@3x.png
[add] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_close_gray.imageset/Contents.json
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_close_gray.imageset/signin_promo_close_gray.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_close_gray.imageset/signin_promo_close_gray@2x.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_close_gray.imageset/signin_promo_close_gray@3x.png
[add] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chrome_color.imageset/Contents.json
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chrome_color.imageset/signin_promo_logo_chrome_color.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chrome_color.imageset/signin_promo_logo_chrome_color@2x.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chrome_color.imageset/signin_promo_logo_chrome_color@3x.png
[add] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chromium_color.imageset/Contents.json
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chromium_color.imageset/signin_promo_logo_chromium_color.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chromium_color.imageset/signin_promo_logo_chromium_color@2x.png
[rename] https://crrev.com/296640bfa342b8029ca29f86d6cca424134d35c5/ios/chrome/browser/ui/authentication/resources/signin_promo_logo_chromium_color.imageset/signin_promo_logo_chromium_color@3x.png

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da2ebceadf127b3a7e9e52ef412deead53f12f3

commit 6da2ebceadf127b3a7e9e52ef412deead53f12f3
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 04 15:53:41 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/today_extension.

Bug: 738359
Change-Id: I50eefb9072efdc1b54e349959380e8a01561c51e
Reviewed-on: https://chromium-review.googlesource.com/559086
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484119}
[modify] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/BUILD.gn
[add] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/BUILD.gn
[add] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_clipboard.imageset/Contents.json
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_clipboard.imageset/todayview_clipboard.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_clipboard.imageset/todayview_clipboard@2x.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_clipboard.imageset/todayview_clipboard@3x.png
[add] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_new_tab.imageset/Contents.json
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_new_tab.imageset/todayview_new_tab.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_new_tab.imageset/todayview_new_tab@2x.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_new_tab.imageset/todayview_new_tab@3x.png
[add] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_physical_web.imageset/Contents.json
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_physical_web.imageset/todayview_physical_web.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_physical_web.imageset/todayview_physical_web@2x.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_physical_web.imageset/todayview_physical_web@3x.png
[add] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_voice_search.imageset/Contents.json
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_voice_search.imageset/todayview_voice_search.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_voice_search.imageset/todayview_voice_search@2x.png
[rename] https://crrev.com/6da2ebceadf127b3a7e9e52ef412deead53f12f3/ios/chrome/today_extension/resources/todayview_voice_search.imageset/todayview_voice_search@3x.png

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d

commit 6bfb1db6f18ff42035d554e46731cbb2e4a3f33d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Jul 05 08:24:45 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/popup_menu.

Bug: 738359
Change-Id: I150f0e1de79046e7d99fc172e88697f1b7693d75
Reviewed-on: https://chromium-review.googlesource.com/559088
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484217}
[modify] https://crrev.com/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d/ios/chrome/browser/ui/popup_menu/BUILD.gn
[add] https://crrev.com/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d/ios/chrome/browser/ui/popup_menu/resources/BUILD.gn
[add] https://crrev.com/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/Contents.json
[rename] https://crrev.com/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/popup_background.png
[rename] https://crrev.com/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/popup_background@2x.png
[rename] https://crrev.com/6bfb1db6f18ff42035d554e46731cbb2e4a3f33d/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/popup_background@3x.png

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/653629983f3b601fb40769a4bc4f2f11157766ee

commit 653629983f3b601fb40769a4bc4f2f11157766ee
Author: sdefresne <sdefresne@google.com>
Date: Wed Jul 05 08:52:10 2017

Components: Internals
Labels: -Type-Bug Type-Task
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40

commit 5b48c121491cb93f23c3dba26b9cccb4f6a0fe40
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 09:27:39 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/ntp.

Bug: 738359
Change-Id: I1f594099a8129670883c82431728915b92e9126e
Reviewed-on: https://chromium-review.googlesource.com/558943
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484513}
[modify] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/BUILD.gn
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/BUILD.gn
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg_pressed.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg_pressed.imageset/bookmarks_bar_bg_pressed@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg_pressed.imageset/bookmarks_bar_bg_pressed~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_moreshadow.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_moreshadow.imageset/bookmarks_bar_edit_moreshadow.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_moreshadow.imageset/bookmarks_bar_edit_moreshadow@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed_moreshadow.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed_moreshadow.imageset/bookmarks_bar_edit_pressed_moreshadow.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed_moreshadow.imageset/bookmarks_bar_edit_pressed_moreshadow@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_left.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_left.imageset/bookmarks_bar_left@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_left.imageset/bookmarks_bar_left~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_button_bg.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_button_bg.imageset/bookmarks_button_bg.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_button_bg.imageset/bookmarks_button_bg@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_button_border.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_button_border.imageset/bookmarks_button_border.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/bookmarks_button_border.imageset/bookmarks_button_border@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/disclosure_open.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/disclosure_open.imageset/disclosure_open.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/disclosure_open.imageset/disclosure_open@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/incognito_icon.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/incognito_icon@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/incognito_icon@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/ntp_bookmarks.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/ntp_bookmarks@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/ntp_bookmarks@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bottom_bar_shadow.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bottom_bar_shadow.imageset/ntp_bottom_bar_shadow.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_bottom_bar_shadow.imageset/ntp_bottom_bar_shadow@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_delete_button.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_delete_button.imageset/ntp_delete_button.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_delete_button.imageset/ntp_delete_button@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_incognito.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_incognito.imageset/ntp_incognito.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_incognito.imageset/ntp_incognito@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/ntp_mv_placeholder_bg.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/ntp_mv_placeholder_bg@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/ntp_mv_placeholder_bg@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentbar.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentbar.imageset/ntp_mv_recentbar@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentbar.imageset/ntp_mv_recentbar~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentpress.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentpress.imageset/ntp_mv_recentpress@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentpress.imageset/ntp_mv_recentpress~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_search.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_search.imageset/ntp_mv_search.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_search.imageset/ntp_mv_search@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/ntp_mv_thumbnail_container.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/ntp_mv_thumbnail_container@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/ntp_mv_thumbnail_container@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_welcome_favicon.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_welcome_favicon.imageset/ntp_mv_welcome_favicon.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_mv_welcome_favicon.imageset/ntp_mv_welcome_favicon@2x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs.imageset/ntp_opentabs@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs.imageset/ntp_opentabs@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_clock.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_clock.imageset/ntp_opentabs_clock.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_clock.imageset/ntp_opentabs_clock@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_clock.imageset/ntp_opentabs_clock@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_header.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_header.imageset/ntp_opentabs_header@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_header.imageset/ntp_opentabs_header~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_laptop.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_laptop.imageset/ntp_opentabs_laptop.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_laptop.imageset/ntp_opentabs_laptop@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_laptop.imageset/ntp_opentabs_laptop@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_last_row.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_last_row.imageset/ntp_opentabs_last_row@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_last_row.imageset/ntp_opentabs_last_row~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_last_row_h.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_last_row_h.imageset/ntp_opentabs_last_row_h@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_last_row_h.imageset/ntp_opentabs_last_row_h~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_list_item.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_list_item.imageset/ntp_opentabs_list_item@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_list_item.imageset/ntp_opentabs_list_item~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_list_item_h.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_list_item_h.imageset/ntp_opentabs_list_item_h@2x~ipad.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_list_item_h.imageset/ntp_opentabs_list_item_h~ipad.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_phone.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_phone.imageset/ntp_opentabs_phone.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_phone.imageset/ntp_opentabs_phone@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_phone.imageset/ntp_opentabs_phone@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_recent_arrow.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_recent_arrow.imageset/ntp_opentabs_recent_arrow.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_recent_arrow.imageset/ntp_opentabs_recent_arrow@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_recent_arrow.imageset/ntp_opentabs_recent_arrow@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_tablet.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_tablet.imageset/ntp_opentabs_tablet.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_tablet.imageset/ntp_opentabs_tablet@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_opentabs_tablet.imageset/ntp_opentabs_tablet@3x.png
[add] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_recently_closed.imageset/Contents.json
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_recently_closed.imageset/ntp_recently_closed.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_recently_closed.imageset/ntp_recently_closed@2x.png
[rename] https://crrev.com/5b48c121491cb93f23c3dba26b9cccb4f6a0fe40/ios/chrome/browser/ui/ntp/resources/ntp_recently_closed.imageset/ntp_recently_closed@3x.png

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50721be76f01a42d9c58522ccaa802927683fd5d

commit 50721be76f01a42d9c58522ccaa802927683fd5d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 12:16:05 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/stack_view.

Bug: 738359
Change-Id: I722eaf85df8bb942baa2f9938ad374b13de2fa05
Reviewed-on: https://chromium-review.googlesource.com/558965
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484547}
[modify] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/background_generator.mm
[modify] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/BUILD.gn
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/BUILD.gn
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_bottom.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_bottom.imageset/border_frame_bottom.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_bottom.imageset/border_frame_bottom@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_bottom.imageset/border_frame_bottom@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom.imageset/border_frame_incognito_bottom.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom.imageset/border_frame_incognito_bottom@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom.imageset/border_frame_incognito_bottom@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left.imageset/border_frame_incognito_left.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left.imageset/border_frame_incognito_left@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left.imageset/border_frame_incognito_left@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right.imageset/border_frame_incognito_right.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right.imageset/border_frame_incognito_right@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right.imageset/border_frame_incognito_right@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top.imageset/border_frame_incognito_top.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top.imageset/border_frame_incognito_top@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top.imageset/border_frame_incognito_top@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_left.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_left.imageset/border_frame_left.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_left.imageset/border_frame_left@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_left.imageset/border_frame_left@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_right.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_right.imageset/border_frame_right.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_right.imageset/border_frame_right@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_right.imageset/border_frame_right@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_top.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_top.imageset/border_frame_top.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_top.imageset/border_frame_top@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/border_frame_top.imageset/border_frame_top@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button.imageset/card_close_button.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button.imageset/card_close_button@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button.imageset/card_close_button@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito.imageset/card_close_button_incognito.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito.imageset/card_close_button_incognito@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito.imageset/card_close_button_incognito@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed.imageset/card_close_button_pressed.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed.imageset/card_close_button_pressed@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed.imageset/card_close_button_pressed@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_frame_shadow.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_frame_shadow.imageset/card_frame_shadow.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_frame_shadow.imageset/card_frame_shadow@2x.png
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/card_frame_shadow.imageset/card_frame_shadow@3x.png
[add] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.imageset/Contents.json
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.imageset/stack_view_background_noise.jpg
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.imageset/stack_view_background_noise@2x.jpg
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.imageset/stack_view_background_noise@2x~ipad.jpg
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.imageset/stack_view_background_noise@3x.jpg
[rename] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.imageset/stack_view_background_noise~ipad.jpg

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1f51778ea5d5f343c9277de54234c293c953b9

commit 6c1f51778ea5d5f343c9277de54234c293c953b9
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 12:16:13 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/tabs.

Bug: 738359
Change-Id: Ie6dc177c2ecb75487437f14c35c56612be4e23f5
Reviewed-on: https://chromium-review.googlesource.com/559097
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484548}
[modify] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/BUILD.gn
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/BUILD.gn
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab.imageset/tabstrip_background_tab@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab.imageset/tabstrip_background_tab~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab.imageset/tabstrip_foreground_tab@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab.imageset/tabstrip_foreground_tab~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab.imageset/tabstrip_incognito_background_tab@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab.imageset/tabstrip_incognito_background_tab~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab.imageset/tabstrip_incognito_foreground_tab@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab.imageset/tabstrip_incognito_foreground_tab~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab.imageset/tabstrip_new_tab@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab.imageset/tabstrip_new_tab~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito.imageset/tabstrip_new_tab_incognito@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito.imageset/tabstrip_new_tab_incognito~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed.imageset/tabstrip_new_tab_incognito_pressed@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed.imageset/tabstrip_new_tab_incognito_pressed~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed.imageset/tabstrip_new_tab_pressed@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed.imageset/tabstrip_new_tab_pressed~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close.imageset/tabstrip_tab_close@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close.imageset/tabstrip_tab_close~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito.imageset/tabstrip_tab_close_incognito@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito.imageset/tabstrip_tab_close_incognito~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed.imageset/tabstrip_tab_close_incognito_pressed@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed.imageset/tabstrip_tab_close_incognito_pressed~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed.imageset/tabstrip_tab_close_pressed@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed.imageset/tabstrip_tab_close_pressed~ipad.png
[add] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_toggle_button_gradient.imageset/Contents.json
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_toggle_button_gradient.imageset/tabstrip_toggle_button_gradient@2x~ipad.png
[rename] https://crrev.com/6c1f51778ea5d5f343c9277de54234c293c953b9/ios/chrome/browser/ui/tabs/resources/tabstrip_toggle_button_gradient.imageset/tabstrip_toggle_button_gradient~ipad.png
[delete] https://crrev.com/50721be76f01a42d9c58522ccaa802927683fd5d/ios/chrome/browser/ui/tabs/resources/tabstrip_toggle_button_gradient@3x~ipad.png

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bb2ce2874c486677e7afc9f002bd86713192a489

commit bb2ce2874c486677e7afc9f002bd86713192a489
Author: sdefresne <sdefresne@google.com>
Date: Thu Jul 06 13:03:16 2017

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/fc095c690be173910b31ee1f054fd91bdb1ec966

commit fc095c690be173910b31ee1f054fd91bdb1ec966
Author: sdefresne <sdefresne@google.com>
Date: Thu Jul 06 15:34:59 2017

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7f0266cae5e0204736c15e5e70e8c88958ba07c

commit d7f0266cae5e0204736c15e5e70e8c88958ba07c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 16:12:59 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/omnibox.

Bug: 738359
Change-Id: I3671bd91a4721abc66149f7057f2aee47545b885
Reviewed-on: https://chromium-review.googlesource.com/559084
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484617}
[modify] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/BUILD.gn
[add] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/BUILD.gn
[add] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_background.imageset/Contents.json
[rename] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_background.imageset/omnibox_background.png
[rename] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_background.imageset/omnibox_background@2x.png
[rename] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_background.imageset/omnibox_background@3x.png
[add] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_transparent_background.imageset/Contents.json
[rename] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_transparent_background.imageset/omnibox_transparent_background.png
[rename] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_transparent_background.imageset/omnibox_transparent_background@2x.png
[rename] https://crrev.com/d7f0266cae5e0204736c15e5e70e8c88958ba07c/ios/chrome/browser/ui/omnibox/resources/omnibox_transparent_background.imageset/omnibox_transparent_background@3x.png

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52771312b357bb7043f8af5337169197096fe197

commit 52771312b357bb7043f8af5337169197096fe197
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 16:19:06 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/toolbar.

Bug: 738359
Change-Id: I498b9c1adb1c3f30a6ccb9581c976904534f6bb8
Reviewed-on: https://chromium-review.googlesource.com/558966
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484618}
[modify] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/BUILD.gn
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/BUILD.gn
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/collapse.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/collapse@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/collapse@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/collapse_incognito.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/collapse_incognito@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/collapse_incognito@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/collapse_pressed.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/collapse_pressed@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/collapse_pressed@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/collapse_pressed_incognito.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/collapse_pressed_incognito@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/collapse_pressed_incognito@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/incognito_marker_typing.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/incognito_marker_typing@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/incognito_marker_typing@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner.imageset/keyboard_accessory_qr_scanner.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner.imageset/keyboard_accessory_qr_scanner@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner.imageset/keyboard_accessory_qr_scanner@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search.imageset/keyboard_accessory_voice_search.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search.imageset/keyboard_accessory_voice_search@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search.imageset/keyboard_accessory_voice_search@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/toolbar_dark_newtab.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/toolbar_dark_newtab@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/toolbar_dark_newtab@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/toolbar_dark_newtab_active.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/toolbar_dark_newtab_active@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/toolbar_dark_newtab_active@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/toolbar_dark_newtab_incognito.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/toolbar_dark_newtab_incognito@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/toolbar_dark_newtab_incognito@3x.png
[add] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/Contents.json
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/toolbar_dark_newtab_incognito_active.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/toolbar_dark_newtab_incognito_active@2x.png
[rename] https://crrev.com/52771312b357bb7043f8af5337169197096fe197/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/toolbar_dark_newtab_incognito_active@3x.png

Project Member

Comment 29 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984dfda7eb452073aad638d04d054ed1b04b2236

commit 984dfda7eb452073aad638d04d054ed1b04b2236
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 16:22:00 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/find_bar.

Bug: 738359
Change-Id: I384858ababa3d9887ca10496e2dd7f0d19b2834d
Reviewed-on: https://chromium-review.googlesource.com/559000
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484622}
[modify] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/BUILD.gn
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/BUILD.gn
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/find_bg@2x~ipad.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/find_bg~ipad.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next.imageset/find_next.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next.imageset/find_next@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next.imageset/find_next@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev.imageset/find_prev.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev.imageset/find_prev@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev.imageset/find_prev@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed@3x.png
[add] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/Contents.json
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito@2x.png
[rename] https://crrev.com/984dfda7eb452073aad638d04d054ed1b04b2236/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito@3x.png

Project Member

Comment 30 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276b86a939395e77099f2ce7531e126c9b865c0d

commit 276b86a939395e77099f2ce7531e126c9b865c0d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jul 06 16:38:26 2017

[ios] Convert loose images to imageset.

Convert all loose images (i.e. images not compiled in datapacks)
to imageset and add the correct rule to have them compiled to the
application bundle.

According to the App Thining documentation this should allow the
Apple Store to ship only the correct assets to each devices (i.e.
to implement Slicing).

Convert ios/chrome/browser/ui/side_swipe.

Bug: 738359
Change-Id: Ib5f31c34c2b29b619e4e6620a173a4a21f40235b
Reviewed-on: https://chromium-review.googlesource.com/559124
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484629}
[modify] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/BUILD.gn
[add] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/BUILD.gn
[add] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back.imageset/Contents.json
[rename] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back.imageset/side_swipe_navigation_back.png
[rename] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back.imageset/side_swipe_navigation_back@2x.png
[rename] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back.imageset/side_swipe_navigation_back@3x.png
[add] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow.imageset/Contents.json
[rename] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow.imageset/side_swipe_navigation_content_shadow.png
[rename] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow.imageset/side_swipe_navigation_content_shadow@2x.png
[rename] https://crrev.com/276b86a939395e77099f2ce7531e126c9b865c0d/ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow.imageset/side_swipe_navigation_content_shadow@3x.png

Status: Fixed (was: Started)
I've done some testing of app thinning, here are the results.

Universal Assets.car: 3.9M
iPhone 1x Assets.car: 937K
iPhone 2x Assets.car: 937K
iPhone 3x Assets.car: 1.6M
iPad 1x Assets.car: 695K
iPad 2x Assets.car: 1.3M

So this reduce the size of the installed by something between 2.3 and 3M depending on the type of device.
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c708332548f834d469be0af9659ceecb3ab3fa9

commit 7c708332548f834d469be0af9659ceecb3ab3fa9
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Jul 10 08:49:05 2017

Add option to control recompression of images by actool.

During compilation of assets catalogs, actool has the option of
recompressing the images (likely with pngcrush as used by older
version of Xcode). Add an option to wrapper script to control
whether this is enabled and disable it on iOS (as images have
already been optimised with imageoptim).

Bug: 738359
Change-Id: I8a2b855798bf5f2d221fe9dc1098f8649f77e5a4
Reviewed-on: https://chromium-review.googlesource.com/561777
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485208}
[modify] https://crrev.com/7c708332548f834d469be0af9659ceecb3ab3fa9/build/toolchain/mac/BUILD.gn
[modify] https://crrev.com/7c708332548f834d469be0af9659ceecb3ab3fa9/build/toolchain/mac/compile_xcassets.py

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/791063707cb5fa7687549aa37d2c9b65c8739bb7

commit 791063707cb5fa7687549aa37d2c9b65c8739bb7
Author: sdefresne <sdefresne@google.com>
Date: Tue Jul 11 11:26:22 2017

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eef05935dc088d9df9325ba056ec3af9d9e4d44

commit 9eef05935dc088d9df9325ba056ec3af9d9e4d44
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Jul 12 14:20:29 2017

Fix loading of the close image in InfoBarView.

The image is shipped as part of the compiled assets catalog and
need to be loaded using -imageNamed: instead of by a path.

Bug: 738359
Change-Id: Ife467b503a298e3c1811c2ab76a860f780b482ed
Reviewed-on: https://chromium-review.googlesource.com/568032
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485941}
[modify] https://crrev.com/9eef05935dc088d9df9325ba056ec3af9d9e4d44/ios/chrome/browser/ui/infobars/infobar_view.mm

Sign in to add a comment