The "background graphics" checkbox should control printing of shadows also |
||||||
Issue descriptionChrome Version:61.0.3145.0 OS: Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://welcome page (2)Hit Ctrl+P and observe the sign in button Expected:Border should not be seen when background graphics is unchecked Actual:Instead, Border is seen This is a Regression issue seen from M-61 Manual Bisect Info: ================== Good Build:61.0.3134.0 Bad Build: 61.0.3135.0
,
Jun 30 2017
Bisect Info: ============= You are probably looking for a change made after 480301 (known good), but no later than 480302 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/d6653466e313dc83a33ec049a6eef95a31dda435..de5f24293bb231a3d770b731b0aadf549cab86ae Suspecting https://chromium.googlesource.com/chromium/src/+/de5f24293bb231a3d770b731b0aadf549cab86ae from above URL @fmalita:Could you please take a look and reassign to the right owner if it is not related to your change.
,
Jun 30 2017
That CL restores the print-shadow behavior prior to https://codereview.chromium.org/2689733002https://codereview.chromium.org/2689733002. The "background graphics" checkbox controls printing of backgrounds, not shadows (e.g. http://jsbin.com/qahoqohixi/edit?output). Maybe it should disable shadows also, but that would be a new feature AFAICT. Based on the above, I don't see this as a regression and am inclined to close as WontFix. Chris, any thoughts?
,
Jun 30 2017
The "background graphics" checkbox *should* control shadows as well, since I implement shadows with an image mask.
,
Jun 30 2017
I'm not sure the implementation details matter, but I tend to agree that box-shadows should fall under "background graphics".
,
Jun 30 2017
Changing this to a feature bug.
,
Jun 30 2017
Indeed, WontFix due to working-as-expected sounds right to me.
,
Aug 24 2017
Issue 758488 has been merged into this issue.
,
Sep 26 2017
Closing, per c#7. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Jun 30 2017Status: Untriaged (was: Unconfirmed)