New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738352 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Shadow on ContentSuggestions toolbar is not displayed when the content expand

Project Member Reported by gambard@chromium.org, Jun 30 2017 
When the content suggestions NTP is created with a small content, the shadow is not displayed on the toolbar, as expected.
When the content expand (new suggestions fetched), the toolbar shadow is not updated to reflect the content being present below.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33d30412bd5fbfead77d661718628faa48dacb7

commit f33d30412bd5fbfead77d661718628faa48dacb7
Author: gambard <gambard@chromium.org>
Date: Mon Jul 03 12:38:21 2017

Update shadow when editing ContentSuggestions items

When adding or removing ContentSuggestions items, the size of the
collection may vary. This CL makes sure the audience is notified
of the change to update the shadow on the toolbar accordingly.

BUG= 738352 

Change-Id: I148239accc101390deff5117f9104a3bba814991
Reviewed-on: https://chromium-review.googlesource.com/558880
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483995}
[modify] https://crrev.com/f33d30412bd5fbfead77d661718628faa48dacb7/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 2 by gambard@chromium.org, Jul 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment