New issue
Advanced search Search tips

Issue 738331 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 667238



Sign in to add a comment

Deprecated and remove WTF's CPU() macro

Project Member Reported by tkent@chromium.org, Jun 30 2017

Issue description

Use defined(ARCH_CPU_FOO) instead.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c182971a026be191492993034bb8e4fd1c254dd

commit 9c182971a026be191492993034bb8e4fd1c254dd
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 30 08:30:55 2017

Remove WTF_CPU_32BIT and WTF_CPU_64BIT.

Use defined(ARCH_CPU_xx_BITS) instead.
This CL removes Bswapuintptrt() because it's not used.

Bug:  738331 
Change-Id: I8307d23adfa2e02e3bfe4b9b6e01b74ca2db7995
Reviewed-on: https://chromium-review.googlesource.com/557584
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483656}
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/heap/HeapPage.cpp
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/heap/HeapPage.h
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/wtf/Atomics.h
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/wtf/BitwiseOperations.h
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/wtf/ByteSwap.h
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/wtf/CPU.h
[modify] https://crrev.com/9c182971a026be191492993034bb8e4fd1c254dd/third_party/WebKit/Source/platform/wtf/README.md

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d68316c14f34b909e79180fec2d98d5737ab6e7a

commit d68316c14f34b909e79180fec2d98d5737ab6e7a
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 30 10:43:27 2017

Remove WTF_CPU_BIG_ENDIAN.

Use ARCH_CPU_BIG_ENDIAN instead.

Bug:  738331 
Change-Id: I95966a49355f51bf50e77c9657232e8cbd93fc1e
Reviewed-on: https://chromium-review.googlesource.com/557780
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483671}
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversionTest.cpp
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/wtf/ByteOrder.h
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/wtf/CPU.h
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/wtf/README.md
[modify] https://crrev.com/d68316c14f34b909e79180fec2d98d5737ab6e7a/third_party/WebKit/Source/platform/wtf/text/ASCIIFastPath.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e

commit 959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 30 11:39:46 2017

Remove CPU(X86), CPU(X86_64), CPU(ARM), CPU(ARM64), CPU(MIPS64), and CPU(MIPS).

Use ARCH_CPU_FOO macros instead.

Conversion table:
 CPU(X86) -> defined(ARCH_CPU_X86)
 CPU(X86_64) -> defined(ARCH_CPU_X86_64)
 CPU(X86) || CPU(X86_64) -> defined(ARCH_CPU_X86_FAMILY)
 CPU(ARM) -> defined(ARCH_CPU_ARMEL)
 CPU(ARM64) -> defined(ARCH_CPU_ARM64)
 CPU(ARM) || CPU(ARM64) -> defined(ARCH_CPU_ARM_FAMILY)
 CPU(MIPS64) -> remove
 CPU(MIPS) -> remove


Bug:  738331 
Change-Id: Iec61e35dad21292339505dcf72a2014d95ae284d
Reviewed-on: https://chromium-review.googlesource.com/557324
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483678}
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/audio/DenormalDisabler.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/audio/SincResampler.cpp
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/audio/VectorMath.cpp
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/graphics/cpu/x86/WebGLImageConversionSSE.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/wtf/Atomics.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/wtf/CPU.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/wtf/ContainerAnnotations.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/wtf/README.md
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/wtf/StdLibExtras.h
[modify] https://crrev.com/959b6ec7406f4fe1aaf5409e3a17e3086d2f8f1e/third_party/WebKit/Source/platform/wtf/text/ASCIIFastPath.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 3 2017

Comment 5 by tkent@chromium.org, Jul 3 2017

Owner: tkent@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment