New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738313 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 737388
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.6%-48.4% regression in v8.runtimestats.browsing_desktop at 482844:482966

Project Member Reported by bmeu...@chromium.org, Jun 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 30 2017

Cc: kochi@chromium.org
Owner: kochi@chromium.org

=== Auto-CCing suspected CL author kochi@chromium.org ===

Hi kochi@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Takayoshi Kochi
  Commit : fa75e2abb23205caa6d7f61edc89e672e83f6089
  Date   : Wed Jun 28 08:22:13 2017
  Subject: Revert of Relanding [Android] Adding Smart GO/NEXT feature in Chrome (patchset #4 id:80001 of https://codereview.chromium.org/2948593002/ )

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : v8.runtimestats.browsing_desktop
  Metric       : V8 C++:duration_avg/browse_social/browse_social_facebook_infinite_scroll
  Change       : 60.58% | 1652.65583333 -> 2653.91133333

Revision             Result                  N
chromium@482843      1652.66 +- 65.404       6      good
chromium@482882      1656.97 +- 109.139      6      good
chromium@482901      1652.99 +- 107.125      6      good
chromium@482911      1676.77 +- 78.7367      6      good
chromium@482916      1684.6 +- 197.46        6      good
chromium@482917      1668.42 +- 184.035      6      good
chromium@482918      2705.67 +- 97.8649      6      bad       <--
chromium@482920      2653.91 +- 110.348      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.facebook.infinite.scroll v8.runtimestats.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975390166360944672


For feedback, file a bug with component Speed>Bisection

Comment 4 by kochi@chromium.org, Jun 30 2017

Cc: ajit...@samsung.com
Hmm, this CL was a revert CL that should have fixed  crbug.com/737388  ...

Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 30 2017

Cc: tdres...@chromium.org
 Issue 737663  has been merged into this issue.

Comment 6 by kochi@chromium.org, Jul 10 2017

Mergedinto: 737388
Status: Duplicate (was: Assigned)
The original CL, by ajith.v landed at 481868
https://codereview.chromium.org/2948593002
and then reverted by me.  The original CL caused some regression
( issue 737388 ) but also got some *progression* - and reverting it was
detected as regression, it seems (see the graph in comment #1).

My revert change just reverted to the original performance, thus
no action can be taken for this issue.  Closing.

Sign in to add a comment