New issue
Advanced search Search tips

Issue 738298 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: sync_ != EGL_NO_SYNC_KHR in gl_fence_egl.cc

Project Member Reported by ClusterFuzz, Jun 30 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4741857715421184

Fuzzer: libFuzzer_gpu_swiftshader_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  sync_ != EGL_NO_SYNC_KHR in gl_fence_egl.cc
  base::debug::DebugBreak
  gl::GLFenceEGL::GLFenceEGL
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=483010:483203

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4741857715421184


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by piman@chromium.org, Jul 7 2017

Cc: piman@chromium.org
Owner: capn@chromium.org

Comment 2 by capn@chromium.org, Jul 10 2017

Status: Started (was: Untriaged)
It looks like eglGetCurrentDisplay() returns a pointer to the Display object, instead of its opaque identifier (1 for EGL_PRIMARY_DISPLAY). I thought we encountered this a long time ago and fixed it. Might be a regression due to recent refactorings. I'll make sure we get a test in place.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/e88da3177264ec09c9e7730dd42cfabb11457354

commit e88da3177264ec09c9e7730dd42cfabb11457354
Author: Nicolas Capens <capn@google.com>
Date: Tue Jul 11 16:41:54 2017

Fix retrieving the current Display.

eglGetCurrentDisplay() returned a pointer to the concrete egl::Display
object, instead of the opaque identifier obtained from eglGetDisplay.
This was a regression caused by
https://swiftshader-review.googlesource.com/10188

 Bug chromium:738298 

Change-Id: Id3a87fc3978f8f4efdc77d6c5eaa85743fa3672c
Reviewed-on: https://swiftshader-review.googlesource.com/10508
Tested-by: Nicolas Capens <capn@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

[modify] https://crrev.com/e88da3177264ec09c9e7730dd42cfabb11457354/src/OpenGL/libEGL/Display.cpp
[modify] https://crrev.com/e88da3177264ec09c9e7730dd42cfabb11457354/src/OpenGL/libEGL/Display.h
[modify] https://crrev.com/e88da3177264ec09c9e7730dd42cfabb11457354/src/OpenGL/libEGL/libEGL.cpp
[modify] https://crrev.com/e88da3177264ec09c9e7730dd42cfabb11457354/tests/unittests/unittests.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49bcae15aacec0838961fccf4489c9926eed0dd2

commit 49bcae15aacec0838961fccf4489c9926eed0dd2
Author: Nicolas Capens <capn@google.com>
Date: Wed Jul 12 05:26:01 2017

Roll SwiftShader a781af7..4d97f36

https://swiftshader.googlesource.com/SwiftShader.git/+log/a781af7..4d97f36

BUG= 738298 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ida9f06b57f57a77676da21e6542640916db6bae6
Reviewed-on: https://chromium-review.googlesource.com/566949
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Cr-Commit-Position: refs/heads/master@{#485867}
[modify] https://crrev.com/49bcae15aacec0838961fccf4489c9926eed0dd2/DEPS

Project Member

Comment 5 by ClusterFuzz, Jul 13 2017

ClusterFuzz has detected this issue as fixed in range 485865:485897.

Detailed report: https://clusterfuzz.com/testcase?key=4741857715421184

Fuzzer: libFuzzer_gpu_swiftshader_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  sync_ != EGL_NO_SYNC_KHR in gl_fence_egl.cc
  base::debug::DebugBreak
  gl::GLFenceEGL::GLFenceEGL
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=483010:483203
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=485865:485897

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4741857715421184


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jul 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4741857715421184 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment