Issue metadata
Sign in to add a comment
|
Chrome uses the wrong OS theme colors for Windows 10 [High Contrast] themes (dialogs and menus) |
||||||||||||||||||||||||||||||||||||
Issue descriptionChrome Version : 61.0.3135.4 OS Version: OS X 10.12.5 What steps will reproduce the problem? 1. switch to a high-contrast theme in Windows 10 and focus Chrome. Either "Ease of Access" -> High Contrast or `Control Panel\Appearance and Personalization\Personalization` will get you a dialog (different ones) for switching the Windows theme. What is the expected result? Colors should match the way the theme is described What happens instead of that? Doesn't match. For the attached theme, - only button text should be white: all other text should be yellow unless selected (white on green) or disabled (green) - Links should be bluey purple, not orange - Menus are totally different also buttons look weird. The main thing that stands out is that lots of text is button-text-white, which should be window-text-yellow. Also focus rings should be green (same as the selected-text-background). Blue is really hard to see. Menus are very hard to use. I think Windows 10 has stopped updating/using whatever theme source Chrome is using to render menus and is just using theme colors for regular dialogs to draw menus.
,
Jun 30 2017
,
Jun 30 2017
https://codereview.chromium.org/2957263002 fixes some of the white-text-that-should-be-green-or-yellow . Adding screengrabs.
,
Jun 30 2017
,
Jul 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d007b3e7c64c2fdaf91c70ed2bc89205fcdfcb41 commit d007b3e7c64c2fdaf91c70ed2bc89205fcdfcb41 Author: tapted <tapted@chromium.org> Date: Mon Jul 03 06:37:24 2017 Update dialog button text color for Harmony per the latest button spec Only use the new colors when using HarmonyTypographyProvider. Diverge from NativeTheme for this since there's too much indirection. `kButtonEnabledColor` is gfx::kChromeIconGrey, but kButtonEnabledColor is used for lots of other things. Note we still use NativeTheme when the Harmony spec is ignored (e.g. OS themes with inverted or high-constrast themes). This CL refactors the code in HarmonyTypographyProvider to be more explicit about when the Harmony spec needs to be ignored. BUG= 691891 , 738292 Review-Url: https://codereview.chromium.org/2957263002 Cr-Commit-Position: refs/heads/master@{#483954} [modify] https://crrev.com/d007b3e7c64c2fdaf91c70ed2bc89205fcdfcb41/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/d007b3e7c64c2fdaf91c70ed2bc89205fcdfcb41/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/d007b3e7c64c2fdaf91c70ed2bc89205fcdfcb41/ui/views/controls/label.h [modify] https://crrev.com/d007b3e7c64c2fdaf91c70ed2bc89205fcdfcb41/ui/views/style/typography_provider.cc
,
Aug 4 2017
,
Aug 9 2017
,
Dec 14 2017
,
Dec 15 2017
,
Dec 15 2017
,
Aug 7
|
|||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Jun 30 20175.2 KB
5.2 KB View Download