New issue
Advanced search Search tips

Issue 738287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

The "Dark Theme" Link on the "You have High Contrast mode enabled..." dialog is dead / redirects.

Project Member Reported by tapted@chromium.org, Jun 30 2017

Issue description

Chrome Version       : 61.0.3143.0
OS Version: 10.0

To repro: switch to a high-contrast theme in Windows 10 and focus Chrome. Either "Ease of Access" -> High Contrast or `Control Panel\Appearance and Personalization\Personalization` will get you a dialog (different ones) for switching the Windows theme.

It tries to navigate to https://chrome.google.com/webstore/search-themes/dark but ends up getting redirected to https://chrome.google.com/webstore/category/extensions

It should probably point to https://chrome.google.com/webstore/category/collection/dark_themes ?

But that's not a great UX either -- it's hard to pick which one to install. Ideally one of themes would be maintained by Google, but that doesn't seem to be the case.
 
Screen Shot 2017-06-30 at 12.31.28 pm.png
178 KB View Download
Labels: -Pri-3 Pri-1
Owner: dmazz...@chromium.org
Status: Assigned (was: Unconfirmed)
This seems like a bad regression we should fix.

Dominic, I think you were involved with the high contrast theme stuff.  Do you know how to route this?
I'll fix the url first, that's a good stopgap.

I'm working on making high-contrast native, a fair amount is implemented behind a flag now. I was hoping to incorporate a native dark theme into that but that depends more on UI review than anything else.

Labels: triage-dominic
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d710301bd67ccb02a6f6a1b1584e012e2320a8

commit 15d710301bd67ccb02a6f6a1b1584e012e2320a8
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Aug 11 19:42:01 2017

Update link to dark theme in high contrast bubble

The previous link didn't work, this is a good equivalent.

We're rethinking everything about high-contrast mode in bug 685242,
please comment there for long-term plans.

Bug:  738287 ,685242
Change-Id: I8f1236c8ed51d92d40e8dc2f321b5aeca6acd87d
Reviewed-on: https://chromium-review.googlesource.com/612123
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493832}
[modify] https://crrev.com/15d710301bd67ccb02a6f6a1b1584e012e2320a8/chrome/browser/ui/views/accessibility/invert_bubble_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment