New issue
Advanced search Search tips

Issue 738275 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug


Sign in to add a comment

Fuchsia fyi bot still flaking

Project Member Reported by scottmg@chromium.org, Jun 30 2017

Issue description

Some tests are occasionally hanging, https://build.chromium.org/p/chromium.fyi/builders/Fuchsia

It's not clear in this output which tests are really causing the hang, but I feel like I see these test suites more often than others, so the hanging test(s) could be "near" here.

AtomicFlagTest
ConditionVariableTest
WaitableEventTest
PlatformThreadTest


Unfortunately, I can't reproduce this locally even semi-reliably, even with CHROME_HEADLESS=1 set to emulate the bot environment (QEMU w/o KVM)

[00156.681] 02477.02680> [1356/2118] AtomicFlagTest.SimpleSingleThreadedTest (0 ms)
[00156.681] 02477.02680> [1357/2118] AtomicFlagTest.DoubleSetTest (0 ms)
[00156.681] 02477.02680> [1358/2118] AtomicFlagTest.ReadFromDifferentThread (204 ms)
[00156.682] 02477.02680> [1359/2118] AtomicFlagTest.SetOnDifferentSequenceDeathTest (47 ms)
[00156.682] 02477.02680> [1360/2118] ConditionVariableTest.StartupShutdownTest (88 ms)
[00177.583] 02477.02680> Still waiting for the following processes to finish:
[00177.684] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.EcOGKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00177.684] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.FnnJBG/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00177.685] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.GooEKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00177.685] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.nbaIll/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00177.685] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.moomcP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00177.685] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.PEJhoO/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00177.685] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.oHMOlP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00177.685] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.PjAAJn/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00192.757] 02477.02680> Still waiting for the following processes to finish:
[00192.757] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.EcOGKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00192.757] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.FnnJBG/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00192.757] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.GooEKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00192.757] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.nbaIll/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00192.757] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.moomcP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00192.757] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.PEJhoO/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00192.757] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.oHMOlP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00192.757] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.PjAAJn/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00194.926] 02477.02680> [1361/2118] WaitableEventTest.TimedWaitUntil (31 ms)
[00194.926] 02477.02680> [1362/2118] WaitableEventWatcherTest.BasicSignal (19 ms)
[00194.926] 02477.02680> [1363/2118] WaitableEventWatcherTest.BasicCancel (0 ms)
[00194.926] 02477.02680> [1364/2118] WaitableEventWatcherTest.CancelAfterSet (10191 ms)
[00194.926] 02477.02680> [1365/2118] WaitableEventWatcherTest.OutlivesMessageLoop (0 ms)
[00194.927] 02477.02680> [1366/2118] WaitableEventWatcherTest.DeleteUnder (15844 ms)
[00194.927] 02477.02680> [1367/2118] WaitableEventWatcherTest.SignalAndDelete (93 ms)
[00194.927] 02477.02680> [1368/2118] ByteOrderTest.ByteSwap16 (0 ms)
[00194.927] 02477.02680> [1369/2118] ByteOrderTest.ByteSwap32 (0 ms)
[00194.927] 02477.02680> [1370/2118] ByteOrderTest.ByteSwap64 (0 ms)
[00212.816] 02477.02680> Still waiting for the following processes to finish:
[00212.816] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.EcOGKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00212.816] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.FnnJBG/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00212.816] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.GooEKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00212.816] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.nbaIll/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00212.816] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.oHMOlP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00212.816] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.PjAAJn/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00212.816] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.ibDfgc --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00212.816] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.NookhD/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00237.799] 02477.02680> Still waiting for the following processes to finish:
[00237.799] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.EcOGKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00237.799] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.FnnJBG/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00237.799] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.GooEKP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00237.799] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.nbaIll/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00237.799] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.oHMOlP --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00237.799] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.PjAAJn/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00237.800] 02477.02680> /system/base_unittests --gtest_flagfile=/tmp/.org.chromium.Chromium.pbCaHe/.org.chromium.Chromium.ibDfgc --single-process-tests --test-launcher-filter-file=/system/testing/buildbot/filters/fuchsia.base_unittests.filter --tes
[00237.800] 02477.02680> t-launcher-output=/tmp/.org.chromium.Chromium.NookhD/test_results.xml --test-launcher-retry-limit=0 --test-launcher-timeout=450000
[00257.798] 02477.02680> Still waiting for the following processes to finish:
 
Showing comments 48 - 147 of 147 Older
Blockedon: 752220
Project Member

Comment 49 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f743817290515015639f3aee03a13d7cd046a4

commit 65f743817290515015639f3aee03a13d7cd046a4
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Aug 03 19:08:04 2017

fuchsia: Disable a couple flaky ui_base_unittests

TBR=wez@chromium.org

Bug:  752220 , 738275
Change-Id: I839aca92ea3d4421139ce0b2113983bce780dd16
Reviewed-on: https://chromium-review.googlesource.com/600493
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491812}
[modify] https://crrev.com/65f743817290515015639f3aee03a13d7cd046a4/testing/buildbot/filters/fuchsia.ui_base_unittests.filter

Blockedon: 752605
Blockedon: 752607
Project Member

Comment 52 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/82f838d6f09a9131d200a03dc030a03e4f710e9e

commit 82f838d6f09a9131d200a03dc030a03e4f710e9e
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 00:38:09 2017

Mail Fuchsia mailing list instead of individual people on bot failure

Bug: 738275
Change-Id: I37d511b77654deefb08b8ec9773c329f9ce25afe
Reviewed-on: https://chromium-review.googlesource.com/606630
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/82f838d6f09a9131d200a03dc030a03e4f710e9e/scripts/slave/gatekeeper.json

Two more at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8637 for base_unittests

[01108.826] 02994.03023> 2 tests timed out:
[01108.827] 02994.03023>     ScopedTaskEnvironmentTest.QueuedRunUntilIdle (../../base/test/scoped_task_environment_unittest.cc:66)
[01108.827] 02994.03023>     TaskSchedulerTaskTrackerTest.LoadWillPostAndRunBeforeShutdown (../../base/task_scheduler/task_tracker_unittest.cc:728)

Blockedon: 754755
Blockedon: 754756
Blockedon: 754757
Blockedon: 754770
Project Member

Comment 58 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d

commit a1d6b4b016198475f3d8819ea673b48f5c3a4d8d
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Aug 11 17:31:11 2017

fuchsia: log extra process info when test child process hangs

One suspicion is that the child process is transitioning to "DYING" but
not making it to "DEAD" and so not raising a TERMINATED signal, so the
parent process never lets go. Seeing the "exited" bool should tell us if
this is the case (but might as well print all the fields in case they're
useful.)

Ref: https://fuchsia.googlesource.com/magenta/+/HEAD/docs/syscalls/object_get_info.md

Bug:  750370 , 738275
Change-Id: I4371ef6784f7cecbab483a9be10f18b0671e54f2
Reviewed-on: https://chromium-review.googlesource.com/611382
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493784}
[modify] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/base/test/launcher/test_launcher.cc

Project Member

Comment 59 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57f39a4dfa3e75516276fa931a5c24b7deb4b85

commit e57f39a4dfa3e75516276fa931a5c24b7deb4b85
Author: Sergey Ulanov <sergeyu@google.com>
Date: Sat Aug 12 00:10:34 2017

Reduce run-time of net_unittests, and re-enable them.

Certain operations, in particular process-launching, and some forms of
I/O commonly performed by networking tests, are extremely slow, so:

- Filter out the slowest networking tests.
- Launch the test-runner with a much higher limit on tests-per-batch.
- Enabled FileStreamTest, they pass now

This is rebased version of
https://chromium-review.googlesource.com/c/580168

NOTRY=true

Bug: 745094, 738275
Change-Id: I7a355e9520cdbe7d5c5ecaae42f1cbf013b33e0c
Reviewed-on: https://chromium-review.googlesource.com/610629
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493891}
[modify] https://crrev.com/e57f39a4dfa3e75516276fa931a5c24b7deb4b85/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e57f39a4dfa3e75516276fa931a5c24b7deb4b85/testing/buildbot/filters/fuchsia.net_unittests.filter

Project Member

Comment 60 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4822834e91f44835e3fcdd49fcf9ccafe6a84ec

commit c4822834e91f44835e3fcdd49fcf9ccafe6a84ec
Author: Wez <wez@chromium.org>
Date: Sat Aug 12 01:59:30 2017

Fix PlatformThread::CurrentId() under Fuchsia.

Under Fuchsia CurrentId() was returning the pthread_t result of calling
pthread_self() as the PlatformThreadId, which under POSIX platforms is
defined to pid_t. Under Fuchsia these are an unsigned long derived from
the pthread's internal point (i.e. 64-bit), and an int (32-bit)
respectively. This is changed to use the platform thread handle, which
is a 32-bit value as well.

Bug:  751894 ,  735701 , 738275
Change-Id: Ie5ab21c3c01d609b9b2d5b6a43d04ae57990eaf3
Reviewed-on: https://chromium-review.googlesource.com/611853
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493935}
[modify] https://crrev.com/c4822834e91f44835e3fcdd49fcf9ccafe6a84ec/base/threading/platform_thread.h
[modify] https://crrev.com/c4822834e91f44835e3fcdd49fcf9ccafe6a84ec/base/threading/platform_thread_posix.cc

Project Member

Comment 61 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cdc0f4c4db9d2766b29d3a93b3617c107f9f8b0

commit 0cdc0f4c4db9d2766b29d3a93b3617c107f9f8b0
Author: Wez <wez@chromium.org>
Date: Sat Aug 12 16:45:16 2017

Fix inappropriate use of pthread_self() in PlatformThread::SetName().

We updated PlatformThread::CurrentID() to work correctly for Fuchsia
in https://chromium-review.googlesource.com/c/611853, but ironically
the Fuchsia version of PlatformThread::SetName() was still mis-using
pthread_self() as the PlatformThreadId as well, causing swathes of
tests to fail due to ThreadIdManager::Set/Get being called with
different Ids (pthread_t vs mx_handle_t) and therefore mis-matching.

TBR: scottmg@chromium.org
Bug:  751894 ,  735701 , 738275
Change-Id: I520560050c18efe624f701b4b9c5925b92bbec9a
Reviewed-on: https://chromium-review.googlesource.com/612027
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493980}
[modify] https://crrev.com/0cdc0f4c4db9d2766b29d3a93b3617c107f9f8b0/base/threading/platform_thread_fuchsia.cc

Blockedon: 755154
Project Member

Comment 63 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03145266303a0b281af67f1ad88be47fbf4f7752

commit 03145266303a0b281af67f1ad88be47fbf4f7752
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Aug 14 18:26:26 2017

fuchsia: Ensure image root common prefix is the source root

In making a small repro binary, the dependencies ended up being:
['.../out/fuchd/libbase_something.so', '.../out/fuchd/libc.so'].

The intention for common_prefix was to be the common path, but by using
os.path.commonprefix, we can end up with '.../out/fuchd/lib' in this
unlikely circumstance. Instead use the source root since that's what
we actually want.

Bug: 738275
Change-Id: I73d7993afaa248e23b280828749adfd711ceecc2
Reviewed-on: https://chromium-review.googlesource.com/613663
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494109}
[modify] https://crrev.com/03145266303a0b281af67f1ad88be47fbf4f7752/build/fuchsia/runner_common.py

Project Member

Comment 64 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/241f1d55ac1233c8028c45f767a882cdd4be31f3

commit 241f1d55ac1233c8028c45f767a882cdd4be31f3
Author: Sergey Ulanov <sergeyu@google.com>
Date: Mon Aug 14 20:22:53 2017

Add testserver support in fuchsia/test_runner.py.

net_unittests depends on a test server for some unittests. That server
is written in Python, so currently it's not possible to run it under
Fuchsia. But it's possible to run it outside qemu.
 1. Enabled user network interface when starting qemu.
 2. Enabled chrome_test_server_spawner in the test_runner.py for
    net_unittests.

Bug: 738275
Change-Id: I36eaea2cfec5ad6c45c18f41c1afd1d00b4a3fde
Reviewed-on: https://chromium-review.googlesource.com/611461
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494165}
[modify] https://crrev.com/241f1d55ac1233c8028c45f767a882cdd4be31f3/build/config/fuchsia/rules.gni
[modify] https://crrev.com/241f1d55ac1233c8028c45f767a882cdd4be31f3/build/fuchsia/runner_common.py
[modify] https://crrev.com/241f1d55ac1233c8028c45f767a882cdd4be31f3/build/fuchsia/test_runner.py
[modify] https://crrev.com/241f1d55ac1233c8028c45f767a882cdd4be31f3/testing/test.gni

Blockedon: 755282
Blockedon: 755551
Blockedon: 755552
Blockedon: -755552
Blockedon: -755551
Project Member

Comment 70 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0357c5b8c7b583831b20fe0b5daa948bc971d423

commit 0357c5b8c7b583831b20fe0b5daa948bc971d423
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Aug 15 22:52:44 2017

Fix DCHECK() in MessagePumpFuchsia

MxHandleWatchController::StopWatchingMxHandle() wasn't resetting
has_begun_ flag when called after the pump is destroyed, so the DCHECK
in WaitEnd() was failing sometimes when running net_unittests.

Bug: 738275
Change-Id: I91b21e201675beae0413bceee35f5c593aee11dc
Reviewed-on: https://chromium-review.googlesource.com/615853
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494584}
[modify] https://crrev.com/0357c5b8c7b583831b20fe0b5daa948bc971d423/base/message_loop/message_pump_fuchsia.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65fbd32e753d967539e57bb3b9fee2ec0363519f

commit 65fbd32e753d967539e57bb3b9fee2ec0363519f
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Aug 16 01:34:10 2017

Fix NetworkThrottleManager to pass TickClock to base::Timer.

NetworkThrottleManager tests use a fake TickClock, but
NetworkThrottleManager::SetTickClockForTests() wasn't passing the clock
to the timer used internally. As result some tests were failing when
running these tests under qemu (for Fuchsia). Updated the class to pass
TickClock to the timer.

Also removed the test from the filter file, so it will run on the bots.

Bug: 738275
Change-Id: Ic74858037761f8cb0b3f47d4feffe0531a50f10d
Reviewed-on: https://chromium-review.googlesource.com/611702
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494657}
[modify] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/net/base/network_throttle_manager_impl.cc
[modify] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/net/base/network_throttle_manager_impl.h
[modify] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/testing/buildbot/filters/fuchsia.net_unittests.filter

Project Member

Comment 72 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc1d87a602fde192dd734f3d553663513d51ddd6

commit bc1d87a602fde192dd734f3d553663513d51ddd6
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Aug 16 02:18:39 2017

Implement SocketPosix::IsConnected() for Fuchsia

SocketPosix::IsConnected() uses MSG_PEEK flag, which currently isn't
supported on Fuchsia (NET-121). Workaround it by implementing the same
functionality using poll().

Also updated comments for IsConnected() and IsConnectedAndActive() in 
streams_socket.h to make them clearer.

Bug: 738275
Change-Id: I75d029b9aaf92ee91ae7bb26af316624861660ca
Reviewed-on: https://chromium-review.googlesource.com/614820
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494671}
[modify] https://crrev.com/bc1d87a602fde192dd734f3d553663513d51ddd6/net/socket/socket_posix.cc
[modify] https://crrev.com/bc1d87a602fde192dd734f3d553663513d51ddd6/net/socket/stream_socket.h

Blockedon: 755848
Blockedon: 756112
Blockedon: 745094
Blockedon: 756477
Blockedon: 756578
Blockedon: 757469
Blockedon: 757477
Blockedon: 758221
The long 5h-ish timeouts on net_unittests are simply due to the interaction between --test-launcher-timeout and --test-launcher-batch-limit.

For net_unittests we set test-launcher-batch-limit very high (200). The test timeout without KVM is set to 90s, which means the per batch timeout becomes 90*200s == 5h.

In https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FFuchsia%2F9040%2F%2B%2Frecipes%2Fsteps%2Fnet_unittests%2F0%2Fstdout we can see the deadline for the hung process is exactly 5h, so the mx_object_wait_one is working fine, we just told it to wait for a very long time.
So, I think it's "just" a matter of figuring out when/why e.g. StreamSocket/TransportClientSocketTest* hangs, which looks like it fails to connect to localhost so the test fails.
Blockedon: 759644
Blockedon: 759653
Blockedon: 759658
Project Member

Comment 86 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e1392fbfb3b75912af20f6e44e115ed3a8790e4

commit 8e1392fbfb3b75912af20f6e44e115ed3a8790e4
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Aug 28 19:34:53 2017

fuchsia: Disable HttpCache.RangeGET_ParallelValidationOverlappingRanges

Bug:  758221 , 738275
Change-Id: Ib6e5f458073d41612ea083071be46bde1cb13c90
TBR: sergeyu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/638313
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497840}
[modify] https://crrev.com/8e1392fbfb3b75912af20f6e44e115ed3a8790e4/testing/buildbot/filters/fuchsia.net_unittests.filter

Blockedon: 761401
Blockedon: 761400
Blockedon: 761214
Blockedon: 764015
Blockedon: 764018
Blockedon: 764020
Blockedon: 764567
Blockedon: 767166
Project Member

Comment 95 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/586551557e5f7fb107adf6ebcfcfc0f32301d89b

commit 586551557e5f7fb107adf6ebcfcfc0f32301d89b
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Sep 22 22:41:01 2017

fuchsia: Add script to run wide on Fuchsia and collect results

Bug: 738275
Change-Id: Ic04c8473f05c63c0e2ae91b729f48e412a814865
Reviewed-on: https://chromium-review.googlesource.com/677893
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503886}
[add] https://crrev.com/586551557e5f7fb107adf6ebcfcfc0f32301d89b/tools/fuchsia/OWNERS
[add] https://crrev.com/586551557e5f7fb107adf6ebcfcfc0f32301d89b/tools/fuchsia/run-swarmed.py

Blockedon: 768116
Blockedon: 768436
Blockedon: 769822
Blockedon: 771237
Blockedon: 771239
Blockedon: 771701
Blockedon: 638891
Blockedon: 775120
Blockedon: 775119
Blockedon: 775122
Blockedon: 776242
Blockedon: 776424
Blockedon: 777916
Blockedon: 777917
Blockedon: 780508
Blockedon: 784448
Blockedon: 784449
Project Member

Comment 113 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dba81af3c91f1c82df8ae26473f46421cdf3e8b

commit 8dba81af3c91f1c82df8ae26473f46421cdf3e8b
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Nov 15 20:22:48 2017

fuchsia: Disable MemoryDumpManagerTest.PostTaskForSequencedTaskRunner

Flaked at
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/11278.

Bug: 738275
Change-Id: Iffcfb8123c332820682d8f9fac018aaf5b7cd806
Reviewed-on: https://chromium-review.googlesource.com/772039
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516804}
[modify] https://crrev.com/8dba81af3c91f1c82df8ae26473f46421cdf3e8b/testing/buildbot/filters/fuchsia.base_unittests.filter

Blockedon: 785445
Blockedon: 787259

Comment 116 by w...@chromium.org, Nov 29 2017

Blockedon: 789712
Blockedon: 763098
Blockedon: 792525
Blockedon: 793412
Blockedon: 793823
Project Member

Comment 121 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0503192a831de0fb2176f7a33efc90f85fbf1b9f

commit 0503192a831de0fb2176f7a33efc90f85fbf1b9f
Author: Wez <wez@chromium.org>
Date: Fri Jan 19 23:50:57 2018

Temporarily re-enable a load of flakey tests, to get some hang dumps.

Bug: 738275,  799268 
Change-Id: I6a2c4b313879b7d690661fe95d4d84ed03315028
Reviewed-on: https://chromium-review.googlesource.com/876987
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530664}
[modify] https://crrev.com/0503192a831de0fb2176f7a33efc90f85fbf1b9f/testing/buildbot/filters/fuchsia.base_unittests.filter

Blockedon: 809660
Blockedon: 801353
Blockedon: 809780
Blockedon: -809780
Blockedon: 810521
Blockedon: 811881
Blockedon: 813631
Blockedon: 813651
Blockedon: 813795
Blockedon: 814811
Blockedon: 815314

Comment 133 by w...@chromium.org, Feb 26 2018

Blockedon: 816620
Project Member

Comment 134 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/193277bcdc3b5c0527eec7f5e36d90588bdddc3d

commit 193277bcdc3b5c0527eec7f5e36d90588bdddc3d
Author: Wez <wez@chromium.org>
Date: Tue Feb 27 03:44:41 2018

Roll Fuchsia SDK to 739d1fd10565f97bacae8215903403b2677d8f48.

- Removes sys/resource.h, requiring some additional conditionals around
  includes of that header under OS_POSIX.
- Improves the system PRNG implementation to reduce the potential for
  lock contention.

We also clean up some test filter entries that either no longer refer
to an existing test, or are no longer required.

Bug: 707030,  801353 ,  809660 , 738275
Change-Id: Ic1f49625f20f2efc6c2509cf0f1fa8265d4e9f7f
Reviewed-on: https://chromium-review.googlesource.com/932822
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539393}
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/base/allocator/partition_allocator/partition_alloc_unittest.cc
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/base/process/process_metrics_posix.cc
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/base/process/process_util_unittest.cc
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/base/sys_info_posix.cc
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/base/threading/platform_thread_posix.cc
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/build/fuchsia/update_sdk.py
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/193277bcdc3b5c0527eec7f5e36d90588bdddc3d/testing/buildbot/filters/fuchsia.base_unittests.filter

Project Member

Comment 135 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26f4cdcf5fea1eb642e3cabd35c1bd1aaf502303

commit 26f4cdcf5fea1eb642e3cabd35c1bd1aaf502303
Author: Wez <wez@chromium.org>
Date: Thu Mar 01 07:39:27 2018

Roll Fuchsia SDK to 9d4016533477903c796470e7ab46c2e1dad31761.

- Removes sys/resource.h, requiring some additional conditionals around
  includes of that header under OS_POSIX.
- Improves the system PRNG implementation to reduce the potential for
  lock contention.

TBR: scottmg
Bug: 707030,  801353 ,  809660 , 738275,  817241 ,  817586 
Change-Id: I4e01a0b23ad66c060ac7a6776a45329775117886
Reviewed-on: https://chromium-review.googlesource.com/942685
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540093}
[modify] https://crrev.com/26f4cdcf5fea1eb642e3cabd35c1bd1aaf502303/build/fuchsia/update_sdk.py

Blockedon: 826450
Blockedon: 829507
Project Member

Comment 138 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62c715550ee24d8b24ef1069819719c2d3abafb0

commit 62c715550ee24d8b24ef1069819719c2d3abafb0
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon Jun 18 19:36:35 2018

Filter out all remaining base tests on Fuchsia.

This removes all the remaining disabled tests in the filter file for
base tests on Fuchsia and instead filters each of them individually.

Bug: 738275, 752368, 753490, 810077, 811881, 851734, 851747, 851759, 851760
Change-Id: I375954138d09ebacc05b2ad37afe1e09901e52e2
Reviewed-on: https://chromium-review.googlesource.com/1096483
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568112}
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/allocator/partition_allocator/address_space_randomization_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/files/file_proxy_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/files/file_util_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/metrics/field_trial_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/observer_list_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/process/process_util_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/synchronization/condition_variable_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/sys_info_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/threading/platform_thread_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/trace_event/process_memory_dump_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/trace_event/trace_category_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/testing/buildbot/filters/fuchsia.base_unittests.filter

Project Member

Comment 139 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42c014d0916cb84be9420e0f3542a0112bc7b797

commit 42c014d0916cb84be9420e0f3542a0112bc7b797
Author: Wez <wez@chromium.org>
Date: Thu Jun 21 11:36:14 2018

Remove extra Fuchsia-specific logging from Process and TestLauncher.

The issues that this logging was introduced to diagnose are understood
and/or resolved, so it can be removed.

Also clean up some OS_POSIX && !OS_FUCHSIA preprocessor conditionals,
and migrate TestLauncher to use the zx::job container from the SDK.

Bug:  755282 ,  750370 , 738275, 706592
Change-Id: Iedfaa62684a0b6e8524a456766186b4122e98ae0
Reviewed-on: https://chromium-review.googlesource.com/1108483
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569219}
[modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/process/process_fuchsia.cc
[modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/test/BUILD.gn
[modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/test/launcher/test_launcher.cc

Status: Assigned (was: Started)
Cc: scottmg@chromium.org
Owner: ----
Status: Available (was: Assigned)
Blockedon: 887587
Blockedon: 889278

Comment 144 by w...@chromium.org, Jan 19 (4 days ago)

Blockedon: -887587

Comment 145 by w...@chromium.org, Jan 19 (4 days ago)

Blockedon: -759653

Comment 146 by w...@chromium.org, Jan 19 (4 days ago)

Blockedon: 882906
Project Member

Comment 147 by bugdroid1@chromium.org, Jan 21 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c114317110c46d1ee35db54df79f2bcb9c5c2ffb

commit c114317110c46d1ee35db54df79f2bcb9c5c2ffb
Author: Wez <wez@chromium.org>
Date: Mon Jan 21 18:05:41 2019

[Fuchsia] Re-enable ObserverListThreadSafeTest.CrossThreadObserver test.

Bug:  750370 , 738275
Change-Id: Ibe757df500695ea1d5e6a90c6ccdce3467af80ec
Reviewed-on: https://chromium-review.googlesource.com/c/1422787
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624620}
[modify] https://crrev.com/c114317110c46d1ee35db54df79f2bcb9c5c2ffb/base/observer_list_threadsafe_unittest.cc

Showing comments 48 - 147 of 147 Older

Sign in to add a comment