New issue
Advanced search Search tips

Issue 738262 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 714735



Sign in to add a comment

WebApk fails to launch in full-screen if there's a native app with a verified intent filter

Project Member Reported by yfried...@chromium.org, Jun 30 2017

Issue description

1. Install a WebApk and a native app with matching intent filters but the native app has a verified intent filter.
2. Click to launch the webapk and notice it appears in chrome's tabbed ui

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f381948a4babe74c82462b7d41f79c370bf09ac

commit 9f381948a4babe74c82462b7d41f79c370bf09ac
Author: yfriedman <yfriedman@chromium.org>
Date: Fri Jun 30 17:44:37 2017

[WebApk] Fix broken launch when matching an app with verified intent filters.

The issue was that WebappLauncherActivity queries package manager to see
if "a valid webapk can handle this url" and that "the webapk's package
matches the webapk package I'm going to load". The problem is when a
WebApk's intent scope collides with a native app that has a verified
intent filter, the first part of the query only returns the native app's
package.

This is fixed by forcing intent resolution with the WebApk package name
of the WebApk for which we're trying to render a page and then still
checking that the WebApk is valid.

Note: we still fully respect verified intent filters and does nothing
to change intent dispatch when clicking on a link that could match a
native app with verified intent filters. This simply means that if the
WebApk is launched it'll work and changing intent dispatch is a separate
product question.

BUG= 738262 

Review-Url: https://codereview.chromium.org/2968623002
Cr-Commit-Position: refs/heads/master@{#483744}

[modify] https://crrev.com/9f381948a4babe74c82462b7d41f79c370bf09ac/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
[modify] https://crrev.com/9f381948a4babe74c82462b7d41f79c370bf09ac/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java
[modify] https://crrev.com/9f381948a4babe74c82462b7d41f79c370bf09ac/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

Status: Fixed (was: Started)

Sign in to add a comment