New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738261 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

R60 reef build is broken in ec-tools

Project Member Reported by bhthompson@google.com, Jun 30 2017

Issue description

Error is:
ec-utils-0.0.1-r3837: usb_updater.c: In function 'process_bid':
ec-utils-0.0.1-r3837: usb_updater.c:1330:27: error: 'VENDOR_CC_GET_BOARD_ID' undeclared (first use in this function)
ec-utils-0.0.1-r3837:    send_vendor_command(td, VENDOR_CC_GET_BOARD_ID,
ec-utils-0.0.1-r3837:                            ^
ec-utils-0.0.1-r3837: usb_updater.c:1330:27: note: each undeclared identifier is reported only once for each function it appears in
ec-utils-0.0.1-r3837: usb_updater.c:1356:27: error: 'VENDOR_CC_SET_BOARD_ID' undeclared (first use in this function)
ec-utils-0.0.1-r3837:    send_vendor_command(td, VENDOR_CC_SET_BOARD_ID,

First failure is https://uberchromegw.corp.google.com/i/chromeos_release/builders/reef-release%20release-R60-9592.B/builds/21

Range is https://crosland.corp.google.com/log/9592.31.0..9592.33.0

Suspect CL is https://chromium.googlesource.com/chromiumos/platform/ec/+/a2e2a6a9da6ad2144b009ee0253c0bfca62982be 

This is has also been preventing N updates on the branch as reef is used as the Android PFQ on the branch, fixing this soon is critical. 

If we don't think we can fix quickly we should revert anything suspect in the range :(.
 
It looks like the same CL made it into 59 also, we should watch that, we may need to revert there too. 

Revert for 60 is up at https://chromium-review.googlesource.com/?polygerrit=0#/c/557400/ if we need to go that route.

Comment 2 by vbendeb@google.com, Jun 30 2017

This cherry-pick is the fix: https://chromium-review.googlesource.com/557504

cr50 build in the reef tree is ignored, so it is not a problem that cr50 code there would be incomplete.

As an alternative I can remove other files but the necessary .h file from that patch/
Labels: -Pri-3 M-60 OS-Chrome Pri-1
Status: Fixed (was: Untriaged)
CL is merged 
Marking as Fixed

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment