New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738246 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

action-suffixes expand during `git cl format`

Project Member Reported by nyquist@chromium.org, Jun 30 2017

Issue description

Chrome Version: https://chromium.googlesource.com/chromium/src/+/30464ba1ec25a1ffd420bb107f1d48b4ee1e80ca
OS: All

What steps will reproduce the problem?
(1) Create a CL that uses action-suffixes in //tools/metrics/actions/actions.xml
(2) Run `git cl format`

What is the expected result?
CL should be nicely formatted, but not totally changed.

What happens instead?
The suffixes are fanned out as unique <action> entries according to the affected-action entries.

Example CL before `git cl format`:
https://chromium.googlesource.com/chromium/src/+/f1417336c3352f0e2d768c025249e9d5e96279fd
Example CL after `git cl format`:
https://chromium.googlesource.com/chromium/src/+/c44afa8a89df07c9362a0808457b9c157c9f5097

Discussed with asvitkine@, and we think the formatter logic should not do the fan-out, and instead keep them as is. The server-side logic of course has to extract the data.

Another suggestion would be to also include a name attribute for the <action-suffix>, so it will be easier to refer to them in comments within the actions that are suffix-based.
 

Sign in to add a comment