New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738215 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Makefile should force-include common.h in all source files

Project Member Reported by rspangler@chromium.org, Jun 29 2017

Issue description

Currently, source files need to include common.h before other include files - or those files need to explicitly include it.

It'd be nice if the makefile did that for us.  Coreboot's makefile does.
 
Owner: aaboagye@chromium.org
Will this have a significantly negative impact on build dependencies?
I don't think so, the vast majority of sources already include this file, just some of them not as the first in the list, which could cause problems if earlier included .h files have some conditional compilation based on CONFIG_xxx flags.


I briefly looked at adding this the way coreboot does it using the --include gcc command line option, but it messed up test builds IIRC. So, maybe making this file conditional for non test compilations is the best way to go. It has been a while though, things might have changed.
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment