Makefile should force-include common.h in all source files |
||
Issue descriptionCurrently, source files need to include common.h before other include files - or those files need to explicitly include it. It'd be nice if the makefile did that for us. Coreboot's makefile does.
,
Nov 13
I don't think so, the vast majority of sources already include this file, just some of them not as the first in the list, which could cause problems if earlier included .h files have some conditional compilation based on CONFIG_xxx flags. I briefly looked at adding this the way coreboot does it using the --include gcc command line option, but it messed up test builds IIRC. So, maybe making this file conditional for non test compilations is the best way to go. It has been a while though, things might have changed.
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||
►
Sign in to add a comment |
||
Comment 1 by reinauer@chromium.org
, Nov 9