Change high-contrast keyboard shortcut. |
|||
Issue descriptionWe're still working out the best way to deal with accidental triggerings of "high consequence" keyboard shortcuts. In the meantime shifting the high-contrast key to something harder to accidentally hit is non-controversial and likely to reduce the pain by a lot. Plan: 1: search+shift+h should stop working and display a notification that the shortcut has changed. 2: ctrl+search+h should be the new combo 3: Keyboard overlay should update with the change. #CBC-RS/TC-watchlist
,
Jul 6 2017
Drive-by observation: Ctrl+Search+H is easier to accidentally hit on external keyboards than Shift+Search+H. Is this the first keyboard shortcut to utilize Ctrl+Search? (Not counting users with function keys, where Search is used to override a function key.)
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6 commit 470ac8ad6279aeecc13ea5349dbc842ab0eb39f6 Author: afakhry <afakhry@chromium.org> Date: Fri Jul 07 02:18:34 2017 Change Toggle High Contrast accelerator Due to accidental triggering of High Contrast accelerator, we are implemnting the following plan: 1: search+shift+h should stop working and display a notification that the shortcut has changed. 2: ctrl+search+h should be the new combo 3: Keyboard overlay should update with the change. BUG= 738214 TEST=covered by tests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2971773003 Cr-Commit-Position: refs/heads/master@{#484799} [modify] https://crrev.com/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6/ash/accelerators/accelerator_table.cc [modify] https://crrev.com/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6/ash/ash_strings.grd [modify] https://crrev.com/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6/chrome/browser/resources/chromeos/keyboard_overlay_data.js [modify] https://crrev.com/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6/tools/metrics/histograms/histograms.xml
,
Jul 7 2017
,
Jul 7 2017
Re #2 yes this is the first combo to use ctrl+search. Yes, ctrl and search are next to each other on external keyboards but ctrl is much less used than shift. Most users will type "H" frequently, but relatively few will hit ctrl+H to open history and if they do they're more likely to catch a finger slip that triggers a visual change.
,
Jul 26 2017
Verified in Chrome OS 9765.7.0, 61.0.3163.13. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jim.dantin@chromium.org
, Jun 29 2017