Refactor ash usage of InputMethodManager::GetFeatureEnabled() and IsEmojiHandwritingVoiceOnImeMenuEnabled() |
||||
Issue descriptionAfter https://codereview.chromium.org/2953033002/ lands the code needs to be fixed to work with go/mustash (chrome --mash) Specifically: * Have InputMethodManagerImpl send the EHV information to ImeControllerClient, perhaps through an observer * Add methods like ShowEmojiHandwritingVoiceOnImeMenu(bool show) and SetImeMenuEnabledFeatures(bool emoji, bool handwriting, bool voice) to ash/public/interfaces/ime_controller.mojom * Store the booleans in ash ImeController * You might need to call Shell::Get()->system_tray_notifier()->NotifyRefreshIME() if the enabled state can change while the menu is open * Use ash::Shell::Get()->ime_controller() in the tray menu code to read the values To Satoru for assignment.
,
Sep 21 2017
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f61c66e8ca12331b3aee20a043887466284381bf commit f61c66e8ca12331b3aee20a043887466284381bf Author: Blake O'Hare <blakeo@chromium.org> Date: Thu Oct 05 01:55:49 2017 mash: Remove a usage of InputMethodManager from ImeMenuTray Currently ImeMenuTray is getting information about the extended input methods (emoji, handwriting, voice) from the InputMethodManager directly whenever the UI for this menu loads. Instead of querying InputMethodManager directly from ImeMenuTray, store this information in the ImeController and update from the ImeControllerClient which is conveniently an InputMethodManager::Observer. Bug: 738213 Change-Id: I6bfe9281434f6ec68a5ff4f77be10829f8e787c8 Reviewed-on: https://chromium-review.googlesource.com/675084 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lan Wei <azurewei@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506620} [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ash/ime/ime_controller.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ash/ime/ime_controller.h [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ash/public/interfaces/ime_controller.mojom [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ash/system/ime_menu/ime_menu_tray.h [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ash/system/ime_menu/ime_menu_tray_unittest.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/chrome/browser/chromeos/input_method/input_method_manager_impl.h [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/chrome/browser/ui/ash/ime_controller_client.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/chrome/browser/ui/ash/ime_controller_client.h [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/chrome/browser/ui/ash/ime_controller_client_unittest.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ui/base/ime/chromeos/input_method_manager.h [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ui/base/ime/chromeos/mock_input_method_manager.cc [modify] https://crrev.com/f61c66e8ca12331b3aee20a043887466284381bf/ui/base/ime/chromeos/mock_input_method_manager.h
,
Dec 26 2017
It looks like this CL fixed everything in the original description. Not sure why it wasn't closed.
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by satorux@chromium.org
, Jun 30 2017