Allow permission-requiring features in VR if the permission is already granted |
|||||||||||||||||
Issue descriptionChrome Version : 61.0.3143.0 Permission-requiring features are currently disabled while in VR (both in the browser and WebVR) because the permission UIs are not yet supported. ( Issue 736568 contains references to many of these.) If the user has already granted permission to an origin and the page has started using the feature, the page can continue to use the feature when inserted into the headset (the VR browser displays an indicator for some features). However, if the page does not start using the feature, for which the origin has permission, before the user enters VR (including upon navigation within VR), the page is not allowed to use the feature. Given that we allow the features at all, it's not clear why they aren't always allowed when a permission has already been granted. Such inconsistency seems likely to confuse users even more than the fact that permissions must be granted beforehand. We should always allow features for which the origin has already been granted permission. While there may be corner cases, such as the user has revoked an Android permission from Chrome, that is an unlikely corner case.
,
Jun 30 2017
,
Jul 4 2017
,
Jul 7 2017
,
Aug 11 2017
,
Sep 22 2017
,
Oct 27 2017
,
Oct 27 2017
,
Jan 17 2018
Gordon, this is blocked on the UX design. Please assign it back to me when the UX is ready.
,
Feb 7 2018
,
Feb 11 2018
,
Feb 12 2018
,
Feb 12 2018
UX spec go/chromevr-permissions
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10ae6b6d286f7d5abcfa7981b56226465185034b commit 10ae6b6d286f7d5abcfa7981b56226465185034b Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Feb 27 00:16:10 2018 VR - Enable PermissionDialog with ModalDialogView in VR When we are in VR, we can enabled the ModalDialogView for PermissionDialogs. This won't change anything for 2D users. This will also impact the auto reject of the permission requests in VR. As a result, if the permission is already granted, the website will be able to use it. (All of this is behind flag VrBrowsingNativeAndroidUi) BUG= 811134 ,779126, 738209 Change-Id: Ic30362acc53c1e7b15a9d9e54457d1c7b3776a2d Reviewed-on: https://chromium-review.googlesource.com/926882 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#539327} [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/browser/permissions/permission_manager_unittest.cc [modify] https://crrev.com/10ae6b6d286f7d5abcfa7981b56226465185034b/chrome/browser/permissions/permission_request_manager.cc
,
Mar 3 2018
,
Mar 6 2018
Amir, is this bug now fixed?
,
Mar 7 2018
,
Mar 13 2018
,
Mar 13 2018
This is covered by the permissions test cases in the "2D UI handling Test Plan". It has been verified on M66.
,
Jul 4
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by meganlindsay@chromium.org
, Jun 29 2017