All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=738203

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7vDr_AkM


Bot(s) for this bug's original alert(s):

Android Builder

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975414192887794336

Please try to reduce the size here. Attached is the analysis from tools/binary_size/diagnose_bloat.py. Adding ReleaseBlock-Stable

Deleted: diff_results.txt 25.7 KB

diff_results.txt 25.7 KB View Download

=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size


To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975414192887794336


For feedback, file a bug with component Speed>Bisection

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975411157871934896

=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size


To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975411157871934896


For feedback, file a bug with component Speed>Bisection

How is this P1 and RB-stable? Can you share the thought process here?

This is the core visitor of the V8 garbage collector used in hot paths across several components, all of which require the best possible performance we can get. We often even manually inspect generated code to make sure that we get the best instruction sequence here.

We moved to a new visitor design to allow better inlining as this path is executed basically as soon as JavaScript is executed and I am quite happy to see that this works out the way it currently does.

RB-stable is added as part of filing a bug for binary size alerts. The bug is also marked as P1 because M61 is a milestone that carries extra importance for Android builds, and any reduction in binary size would be appreciated.

If you believe the size increase is justified and cannot be mitigated without negatively impacting performance, please close the bug as "Won't Fix" (and remove the labels).

Thanks!

Sounds to me like the size increase is more than justified. Thanks for the explanation mlippautz!

Thanks a lot for keeping an eye on those issues! Increases in code size are often unintended.

In this case we are actively working on the core visitation (there are a few CLs) logic and we happily take a slight increase for best performance here.