New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738201 link

Starred by 1 user
Status: Duplicate
Merged: issue 737372
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jun 2017
Cc:
█ zpeng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug-Regression



Sign in to add a comment

80KB regression in resource_sizes (MonochromePublic.apk) at 483098:483098

Project Member Reported by zpeng@chromium.org, Jun 29 2017 
Caused by: Reland "Mojo C++ bindings: Serialize handles during message allocation"

Commit: 11be895df47331de2498478f18079696ae43529d

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=483098

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

This commit introduced 80KB of native code size increase.

Comment 1 by zpeng@chromium.org, Jun 29 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=738201

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrs7tgggM


Bot(s) for this bug's original alert(s):

Android Builder

Comment 3 by roc...@chromium.org, Jun 29 2017

Mergedinto: 737372
Status: Duplicate (was: Assigned)
Aware of this and it's expected. Working to reduce the impact to shaving off some code elsewhere in follow-up CLs. The 80 kB increase should be reduced to about a net ~12 kB increase.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 29 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size


To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975414902592404848


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jun 30 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size


To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975411156314857136


For feedback, file a bug with component Speed>Bisection
►

Sign in to add a comment