New issue
Advanced search Search tips

Issue 738200 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Touch release does not end drag

Project Member Reported by domlasko...@chromium.org, Jun 29 2017

Issue description

Windows are not dropped after dragging using touch, resulting in broken input due to unreleased capture.
 
Labels: -Pri-3 OS-Chrome Pri-1
Labels: M-60
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d60a4c6e0cbe7ed72a141f61b74c7dd10a927212

commit d60a4c6e0cbe7ed72a141f61b74c7dd10a927212
Author: domlaskowski <domlaskowski@chromium.org>
Date: Sat Jul 01 00:08:08 2017

exo: Drop window on touch release

Windows were not dropped after dragging using touch, resulting in broken
input due to unreleased capture. Phantom windows in extended desktop
mode would also stick around.

BUG= 738200 
TEST=Phantom windows disappear on touch release.

Review-Url: https://codereview.chromium.org/2968593002
Cr-Commit-Position: refs/heads/master@{#483870}

[modify] https://crrev.com/d60a4c6e0cbe7ed72a141f61b74c7dd10a927212/components/exo/shell_surface.cc
[modify] https://crrev.com/d60a4c6e0cbe7ed72a141f61b74c7dd10a927212/components/exo/shell_surface.h

Labels: Merge-Request-60
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I believe this was in response to b/63073745
Labels: -Merge-Review-60 Merge-Approved-60
Merge approved for 60.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2adbb00dda842e05020ae0597c3cf48b19503484

commit 2adbb00dda842e05020ae0597c3cf48b19503484
Author: domlaskowski <domlaskowski@chromium.org>
Date: Mon Jul 10 16:35:09 2017

[M60] exo: Drop window on touch release

Windows were not dropped after dragging using touch, resulting in broken
input due to unreleased capture. Phantom windows in extended desktop
mode would also stick around.

TBR=reveman@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG= 738200 
TEST=Phantom windows disappear on touch release.

Review-Url: https://codereview.chromium.org/2968593002
Cr-Original-Commit-Position: refs/heads/master@{#483870}
(cherry picked from commit d60a4c6e0cbe7ed72a141f61b74c7dd10a927212)
Review-Url: https://codereview.chromium.org/2976653002
Cr-Commit-Position: refs/branch-heads/3112@{#557}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/2adbb00dda842e05020ae0597c3cf48b19503484/components/exo/shell_surface.cc
[modify] https://crrev.com/2adbb00dda842e05020ae0597c3cf48b19503484/components/exo/shell_surface.h

Labels: -Hotlist-Merge-Review
Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment