New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738195 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Server hostname in VPN dialog isn't editable

Project Member Reported by yoshi@chromium.org, Jun 29 2017

Issue description

Chrome Version: 61.0.3136.5 (Official Build) dev (64-bit)
Platform: 9672.0.0 (Official Build) dev-channel samus

What steps will reproduce the problem?
(1) Open Settings > Network > VPN > Google OpenVPN 
(2) Click Configure
(3) Try editing Server hostname

What is the expected result?
The hostname should be editable.

What happens instead?
The hostname isn't editable.



 
Issue 738318 has been merged into this issue.
As a temporary workaround in 59 and 60, users can navigate to chrome://settings-frame and use the old UI.

Status: Started (was: Assigned)
It may also be possible to edit the host name in the 'Configure' dialog?

CL to fix this in the new Settings UI is up: https://chromium-review.googlesource.com/c/558626/
Labels: M-61
Components: -OS>Systems>Network UI>Shell>Networking
Labels: ReleaseBlock-Stable
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 7 2017

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 10 2017

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c307e2cda54a47cbf6ef0c1dc6155297c87bf7d1

commit c307e2cda54a47cbf6ef0c1dc6155297c87bf7d1
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jul 11 01:13:18 2017

Settings: Internet: Make VPN.Host editable

The old Settings UI allowed editing of the VPN hostname property.
We should allow that in the new Settings also.

Bug:  738195 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I56dff8a4f52d89add8940247047a667874a5d348
Reviewed-on: https://chromium-review.googlesource.com/558626
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485478}
[modify] https://crrev.com/c307e2cda54a47cbf6ef0c1dc6155297c87bf7d1/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/c307e2cda54a47cbf6ef0c1dc6155297c87bf7d1/chrome/browser/resources/settings/internet_page/internet_detail_page.js

Labels: -M-61 M-60
Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-60
Small, isolated, cros only change.

Project Member

Comment 14 by sheriffbot@chromium.org, Jul 11 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-60 Merge-Approved-60
Merge approved for 60.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 11 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f17bb6e0ad357b6c7ba41ffbb2e87b9e1b5e6f7a

commit f17bb6e0ad357b6c7ba41ffbb2e87b9e1b5e6f7a
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jul 11 23:10:27 2017

Settings: Internet: Make VPN.Host editable

The old Settings UI allowed editing of the VPN hostname property.
We should allow that in the new Settings also.

TBR=stevenjb@chromium.org

(cherry picked from commit c307e2cda54a47cbf6ef0c1dc6155297c87bf7d1)

Bug:  738195 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I56dff8a4f52d89add8940247047a667874a5d348
Reviewed-on: https://chromium-review.googlesource.com/558626
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#485478}
Reviewed-on: https://chromium-review.googlesource.com/567477
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#589}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/f17bb6e0ad357b6c7ba41ffbb2e87b9e1b5e6f7a/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/f17bb6e0ad357b6c7ba41ffbb2e87b9e1b5e6f7a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

Cc: harpreet@chromium.org krishna...@chromium.org
I can edit the hostname for VPN services, added locally by the user using the new MD and old setting page. 
The hostname for VPN services fetched by a policy are not editable. Also, I don't see any options to make the hostname editable in the admin console.

Tested on Samus (R60-9592.71.0) 
Labels: Enterprise
Please open a separate issue if we need/want to be able to edit hostname for enterprise VPN configurations.

Generally speaking only username/password fields are editable for enterprise configurations.

Is there a way to make the configuration 'recommended' instead of 'enforced'? 
Status: Verified (was: Fixed)
Marking this as verified based on #17.

aashutoshk@ - please open a separate bug for hostname not editable for enterprise VPN config.

Sign in to add a comment