See title. This is causing problems when bots have "depot_tools" in PATH, since those are preferred over the actual recipe module's. Example of failure, due to old "apply_issue.bat": https://luci-milo.appspot.com/swarming/task/3709c93352a64210
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/dc598e8223bf9a901f6f960f75f4ed3b30e1668b commit dc598e8223bf9a901f6f960f75f4ed3b30e1668b Author: Dan Jacques <dnj@chromium.org> Date: Thu Jun 29 22:17:08 2017 [bot_update] Prefix PATH, cleanup. Prefix "depot_tools" to PATH instead of appending. This will ensure that "depot_tools" pulls resources from the recipe checkout as a preference, not as a last resort. Use "env_prefixes" instead of "env" to prefix PATH. Remove Git speed limit settings, which are taken care of by the Git wrapper now. BUG= chromium:738176 TEST=expectations R=hinoka@chromium.org, iannucci@chromium.org Change-Id: I2e509a331266e867be323bc70e3bc0f08f85246f Reviewed-on: https://chromium-review.googlesource.com/556287 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/depot_tools/api.py [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/depot_tools/examples/full.py [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/trychange_oauth2_buildbot.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch_download.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle_deprecated.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/trychange.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/buildbot.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/depot_tools/examples/full.expected/win.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/apply_gerrit_ref.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/basic.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/trychange_oauth2_json_win.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/trychange_oauth2_json.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/no_shallow.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/depot_tools/examples/full.expected/basic.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/api.py [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch.json [modify] https://crrev.com/dc598e8223bf9a901f6f960f75f4ed3b30e1668b/recipes/recipe_modules/bot_update/__init__.py
Comment 1 by d...@chromium.org
, Jun 29 2017