Issue metadata
Sign in to add a comment
|
1.3%-5.9% regression in memory.top_10_mobile at 483052:483088 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 29 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975419075412595360
,
Jun 30 2017
=== Auto-CCing suspected CL author kenrb@chromium.org === Hi kenrb@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : kenrb Commit : aaef60b215683bef8c612aa8b19f39ca31c46438 Date : Wed Jun 28 18:43:06 2017 Subject: Partial revert of Remove AreCrossProcessFramesPossible on Android. Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_m_intl_taobao_com_group_purchase_html Change : 4.44% | 53748506.6667 -> 56133232.0 Revision Result N chromium@483051 53748507 +- 1699678 6 good chromium@483070 53148955 +- 1275254 6 good chromium@483075 53552752 +- 1196339 6 good chromium@483077 53860464 +- 999942 6 good chromium@483078 56177776 +- 970640 6 bad <-- chromium@483079 56085787 +- 988940 6 bad chromium@483088 56133232 +- 846698 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8975419075412595360 For feedback, file a bug with component Speed>Bisection
,
Jun 30 2017
The CL that caused this regression was a revert of a previous change, and the reason it was reverted was that it caused a memory regression in certain memory.top_10_mobile metrics on Android WebView (bug 737264). :/ Does this mean that the earlier CL also caused some memory improvements, simultaneously with the regression? FWIW, I am trying to reland the original change, but having trouble reproducing the memory regressions to verify a fix to what I believe might be the problem. I am guessing it is appropriate to close this bug, since it is caused by a revert of a previous CL?
,
Jun 30 2017
Yup, you can see a big improvement in that graph when the initial patch lands. Marking WontFix, as this was just a revert of an improvement.
,
Jul 1 2017
Issue 738165 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tdres...@chromium.org
, Jun 29 2017