App crashes on download when data saver is on |
||||
Issue descriptionChrome Version: 61.0.3145.0 (Developer Build) unknown (32-bit) OS: Android 6.0.0; Nexus 5X What steps will reproduce the problem? (1) Turn data saver on (2) Try to download something (ie. image/webpage) (3) App crashes This does not happen when the data saver is on. It is possible it is related to What is the expected result? App crashes What happens instead? App doesn't crash??
,
Jun 29 2017
Looks like related to https://codereview.chromium.org/2957023002. The request header can't contain a linebreak: https://cs.chromium.org/chromium/src/net/http/http_util.cc?rcl=588d17e4f4b4d8f73bca38924c24037ae4717dea&l=382
,
Jul 1 2017
,
Jul 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05c51a354dd12d26b49ad88960ab249002fa636f commit 05c51a354dd12d26b49ad88960ab249002fa636f Author: megjablon <megjablon@chromium.org> Date: Sat Jul 01 00:17:09 2017 Fix Data Saver download crash BUG= 738161 Review-Url: https://codereview.chromium.org/2965703003 Cr-Commit-Position: refs/heads/master@{#483871} [modify] https://crrev.com/05c51a354dd12d26b49ad88960ab249002fa636f/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f6a4c5bdc43727b8ec3820398cee35201a70edf commit 2f6a4c5bdc43727b8ec3820398cee35201a70edf Author: Megan Jablonski <megjablon@google.com> Date: Mon Jul 10 23:01:25 2017 Fix Data Saver download crash SaveFrameWithHeaders should use SPLIT_WANT_NONEMPTY to ignore terminating CRLF separators. Bug: 738161 Change-Id: Id5deaee597baa48fd90ac447f020094072ba707d Reviewed-on: https://chromium-review.googlesource.com/563820 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485436} [modify] https://crrev.com/2f6a4c5bdc43727b8ec3820398cee35201a70edf/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/2f6a4c5bdc43727b8ec3820398cee35201a70edf/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/2f6a4c5bdc43727b8ec3820398cee35201a70edf/content/browser/web_contents/web_contents_impl_unittest.cc
,
Aug 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tbansal@chromium.org
, Jun 29 2017