Deprecate "Rebaseline" expectations and blink_tool.py rebaseline-expectations |
||||||
Issue descriptionBackground: "webkit-patch rebaseline-expectations" reads lines in TestExpectations with the expectation "Rebaseline", and downloads the latest results from the continuous builders to use as baselines. This is mainly useful in the case where there is a set of tests marked [ Failure ] or [ Failure Pass ] tests in TestExpectations, and you believe these tests' current results are actually correct and consistent, and you want set the latest results as the expected baseline -- in this case you can edit Test Expectations and just change the expectation and run "webkit-patch rebaseline-expectations". But I'm not sure how many people know about and use this. If it's not actually very helpful, then some code can be simplified by removing support for this. Next step: Ask blink-dev for feedback; try to check whether anybody is using webkit-patch rebaseline-expectations. Related: We can probably also remove webkit-patch rebaseline-json, and could ask about that at the same time.
,
Jul 18
Somewhat related is that NeedsManualRebaseline is being removed by nednguyen@ in issue 621126. AFAICT there aren't any "Rebaseline" expectation in TestExpectations, and `third_party/blink/tools/blink_tool.py rebaseline-expectations` appears to do nothing at all. nednguyen@, are you planning any tooling cleanup as part of issue 621126, and might this make sense to roll into that work? (Leaving as available, please self-assign if yes.)
,
Jul 18
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d74062992950a5705ed578fe674cdf4a75e4408a commit d74062992950a5705ed578fe674cdf4a75e4408a Author: Ned Nguyen <nednguyen@google.com> Date: Tue Aug 07 22:23:33 2018 Remove support of the REBASELINE expectation from web tests along with the "rebaseline-expectations" subcommand in blink_tool.py. Also clean up the remaining references to NEEDS_MANUAL_REBASELINE left from https://crrev.com/c/1140927. Bug: 621126, 738152 Change-Id: I33c109e4343e7bf41aac6e7527237702e4cce94a Reviewed-on: https://chromium-review.googlesource.com/1164405 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581366} [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/WebKit/LayoutTests/fast/harness/results.html [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/tool/blink_tool.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/tool/commands/rebaseline.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/tool/commands/rebaseline_unittest.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/web_tests/layout_package/bot_test_expectations.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/web_tests/models/test_expectations.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/web_tests/models/test_expectations_unittest.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/web_tests/models/test_run_results_unittest.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/web_tests/update_expectations.py [modify] https://crrev.com/d74062992950a5705ed578fe674cdf4a75e4408a/third_party/blink/tools/blinkpy/web_tests/update_expectations_unittest.py
,
Oct 10
,
Oct 10
,
Nov 2
I think this is fixed. Feel free to reopen if you think there are cleanup left to be done. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Jul 2Status: Untriaged (was: Available)