New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738151 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Split pending tree duration UMA metric by tree priority

Project Member Reported by sunn...@chromium.org, Jun 29 2017

Issue description

CommitToReadyToActivateDuration (and PendingTreeRasterDuration, PendingTreeDuration) have a strong correlation with tree priority especially with gpu scheduler / async gpu raster. We should split these by tree priority e.g. Scheduling.Renderer.CommitToReadyToActivateDuration.SmoothnessTakesPriority

Also, we should fold the pending tree duration UMAs into CompositorTimingHistory IMO.

I can work on this next week.
 
Thanks for taking this up. The split based on tree priority sounds great. It would also be nice for the PendingTreeDuration UMAs to be split based on impl-side vs main-side pending trees.
We already have an UMA for commit initiated pending trees -
 CommitToReadyToActivateDuration. I think what you want is an InvalidateToReadyToActivateDuration UMA?
fwiw I think PendingTreeDuration is a better name than CommitToReadyToActivateDuration so I might steal it.
I think CommitToReadyToActivateDuration would be closer to PendingTreeRasterDuration. PendingTreeDuration also includes the commit + wait for activation time. So may be PendingTreeRasterDuration.Main/Impl?

Do we have any UMA that captures the time the pending tree waits for activation after ready to activate?
We also have CommitToActivateDuration which captures the time spent during activation too (which PendingTreeDuration does not).
Cc: -khushals...@chromium.org
Owner: khushals...@chromium.org
So...The tree priority can keep changing while we are working on a pending tree. How do we decide which bucket to put it in? :P

Comment 8 by enne@chromium.org, Jul 17 2017

Maybe we another bucket for "multiple priorities oops".
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9

commit ca2c1cf2d9748d25050bfe7f71ee40463588a6a9
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Jul 27 23:06:43 2017

cc: Split pending tree duration metrics based on main/impl side tree.

Add a metric to measure the duration to prepare the pending tree
initiated from impl-side invalidations, analogous to the commit to
ready to activate duration, and a metric to measure the
wait time for a ready to activate tree split based on main or impl side
tree.

Bug:  738151 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5201519a5510d238f6efab36493d7ce17e751636
Reviewed-on: https://chromium-review.googlesource.com/566184
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490063}
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/cc/scheduler/compositor_timing_history.h
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/cc/scheduler/compositor_timing_history_unittest.cc
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/cc/scheduler/scheduler.cc
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/cc/scheduler/scheduler_state_machine.cc
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/cc/scheduler/scheduler_state_machine.h
[modify] https://crrev.com/ca2c1cf2d9748d25050bfe7f71ee40463588a6a9/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment