New issue
Advanced search Search tips

Issue 738150 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707006



Sign in to add a comment

[WPT Export] Write test that invokes wrapper script (Tools/Scripts/wpt-export)

Project Member Reported by jeffcarp@chromium.org, Jun 29 2017

Issue description

A syntax error was introduced in crrev.com/c/556155/ but wasn't caught since the script wpt-export isn't invoked by any test.
 
Note: In general, none of the scripts in Tools/Scripts are invoked by any tests, and they're generally all thin wrappers for main functions which (should be) tested elsewhere.

Anyway, more test coverage is better, and also that particular mistake should have been caught by pylint in presubmit.
Status: WontFix (was: Assigned)
With crrev.com/c/558190/ the original purpose of this bug has been taken care of, so closing.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8727d553262a84a12529f881ff3381ab3c3aed

commit 4e8727d553262a84a12529f881ff3381ab3c3aed
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Jun 30 23:11:36 2017

In check-webkit-style, treat files in Tools/Scripts as Python.

This CL would make it so that the presubmit invokes pylint on any files
in Tools/Scripts that don't have a file extension.

R=jeffcarp

Bug:  738150 
Change-Id: I628ed0235652b53dbc46ceb3ae40a0c5411a35ef
Reviewed-on: https://chromium-review.googlesource.com/558190
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483856}
[modify] https://crrev.com/4e8727d553262a84a12529f881ff3381ab3c3aed/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
[modify] https://crrev.com/4e8727d553262a84a12529f881ff3381ab3c3aed/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py

Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment